All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Jocelyn Falempe <jfalempe@redhat.com>, dri-devel@lists.freedesktop.org
Cc: michel@daenzer.net, tzimmermann@suse.de
Subject: Re: [PATCH] mgag200 fix memmapsl configuration in GCTL6 register
Date: Tue, 18 Jan 2022 18:17:06 +0100	[thread overview]
Message-ID: <8a8bbee0-1be8-5daa-fc86-dcaae4b78f8c@redhat.com> (raw)
In-Reply-To: <fd5773a1-d780-4155-16fb-1c8f7fb73999@redhat.com>

On 1/18/22 17:52, Jocelyn Falempe wrote:
> On 18/01/2022 17:38, Javier Martinez Canillas wrote:
>> Hello Jocelyn,
>>
>> On 1/14/22 10:47, Jocelyn Falempe wrote:
> 
>>
>> My worry is if this could cause other issues so I would only do this change
>> if (is_kdump_kernel()), to make it as non intrusive as possible. And also
>> add a verbose comment about why this is needed.
> 
> This change must be done in the "first" kernel, so that when kdump 
> starts, it doesn't hang the machine by writing to the VGA interface, in 
> the early boot code.
> 

Ah, got it. The patch then makes sense to me as is in that case.

My comment about documenting why this is needed still applies though.  

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat


  reply	other threads:[~2022-01-18 17:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14  9:47 mgag200 fix memmapsl configuration in GCTL6 register Jocelyn Falempe
2022-01-14  9:47 ` [PATCH] " Jocelyn Falempe
2022-01-18 16:38   ` Javier Martinez Canillas
2022-01-18 16:52     ` Jocelyn Falempe
2022-01-18 17:17       ` Javier Martinez Canillas [this message]
2022-01-18 17:25         ` Jocelyn Falempe
2022-01-18 19:06   ` Lyude Paul
2022-01-19  8:16     ` Thomas Zimmermann
2022-01-19 10:29 ` [PATCH v2] " Jocelyn Falempe
2022-01-19 10:29   ` Jocelyn Falempe
2022-01-19 12:21   ` Thomas Zimmermann
2022-01-19 12:21     ` Thomas Zimmermann
2022-01-19 14:55     ` Thomas Zimmermann
2022-01-19 14:55       ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a8bbee0-1be8-5daa-fc86-dcaae4b78f8c@redhat.com \
    --to=javierm@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jfalempe@redhat.com \
    --cc=michel@daenzer.net \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.