Re: [PATCH net-next 2/7] dpaa_eth: add basic XDP support

From: Saeed Mahameed <saeed@kernel.org>
To: Camelia Groza <camelia.groza@nxp.com>,
	kuba@kernel.org, brouer@redhat.com, davem@davemloft.net
Cc: madalin.bucur@oss.nxp.com, ioana.ciornei@nxp.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/7] dpaa_eth: add basic XDP support
Date: Thu, 12 Nov 2020 12:42:43 -0800	[thread overview]
Message-ID: <8a8e5afd2502a57c9a86f64b30066a467afb3c2f.camel@kernel.org> (raw)
In-Reply-To: <7389fa62d9e311236f2e39c5d5d153cabc59949d.1605181416.git.camelia.groza@nxp.com>

On Thu, 2020-11-12 at 20:10 +0200, Camelia Groza wrote:
> +       if (likely(fd_format == qm_fd_contig)) {
> 
> +               xdp_act = dpaa_run_xdp(priv, (struct qm_fd *)fd,
> vaddr,
> 
> +                                      &xdp_meta_len);
> 
> +               if (xdp_act != XDP_PASS) {
> 
> +                       percpu_stats->rx_packets++;
> 
> +                       percpu_stats->rx_bytes +=
> qm_fd_get_length(fd);
> 
> +                       return qman_cb_dqrr_consume;
> 
> +               }
> 
>                 skb = contig_fd_to_skb(priv, fd);
> 
> -       else
> 
> +       } else {
> 
> +               WARN_ONCE(priv->xdp_prog, "S/G frames not supported
> under XDP\n");
> 

Why do you even allow xdp_setup() if S/G is configured ?
just block this on xdp_setup() or on S/G setup on device open()

>                 skb = sg_fd_to_skb(priv, fd);
> 
> +       }