From: Jens Axboe <axboe@kernel.dk>
To: "Michal Koutný" <mkoutny@suse.com>,
"Usama Arif" <usama.arif@bytedance.com>
Cc: io-uring@vger.kernel.org, asml.silence@gmail.com,
linux-kernel@vger.kernel.org, fam.zheng@bytedance.com
Subject: Re: [PATCH v6 5/5] io_uring: remove ring quiesce for io_uring_register
Date: Fri, 15 Jul 2022 10:00:17 -0600 [thread overview]
Message-ID: <8a9adb78-d9bb-a511-e4c1-c94cca392c9b@kernel.dk> (raw)
In-Reply-To: <20220715154444.GA17123@blackbody.suse.cz>
On 7/15/22 9:44 AM, Michal Koutn? wrote:
> Hello.
>
> On Fri, Feb 04, 2022 at 02:51:17PM +0000, Usama Arif <usama.arif@bytedance.com> wrote:
>> - percpu_ref_resurrect(ref);
>> [...]
>> - percpu_ref_reinit(&ctx->refs);
>
> It seems to me that this patch could have also changed
>
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -1911,7 +1911,7 @@ static __cold struct io_ring_ctx *io_ring_ctx_alloc(struct io_uring_params *p)
> ctx->dummy_ubuf->ubuf = -1UL;
>
> if (percpu_ref_init(&ctx->refs, io_ring_ctx_ref_free,
> - PERCPU_REF_ALLOW_REINIT, GFP_KERNEL))
> + 0, GFP_KERNEL))
> goto err;
>
> ctx->flags = p->flags;
>
> Or are there any plans to still use the reinit/resurrect functionality
> of the percpu counter?
Ah yes indeed, good catch! Would you mind sending that as an actual
patch?
--
Jens Axboe
next prev parent reply other threads:[~2022-07-15 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 14:51 [PATCH v6 0/5] io_uring: remove ring quiesce in io_uring_register Usama Arif
2022-02-04 14:51 ` [PATCH v6 1/5] io_uring: remove trace for eventfd Usama Arif
2022-02-04 14:51 ` [PATCH v6 2/5] io_uring: avoid ring quiesce while registering/unregistering eventfd Usama Arif
2022-02-04 14:51 ` [PATCH v6 3/5] io_uring: avoid ring quiesce while registering async eventfd Usama Arif
2022-02-04 14:51 ` [PATCH v6 4/5] io_uring: avoid ring quiesce while registering restrictions and enabling rings Usama Arif
2022-02-04 14:51 ` [PATCH v6 5/5] io_uring: remove ring quiesce for io_uring_register Usama Arif
2022-07-15 15:44 ` Michal Koutný
2022-07-15 16:00 ` Jens Axboe [this message]
2022-07-15 17:45 ` [PATCH] io_uring: Don't require reinitable percpu_ref Michal Koutný
2022-07-15 17:54 ` Roman Gushchin
2022-07-15 18:22 ` Jens Axboe
2022-02-04 15:53 ` [PATCH v6 0/5] io_uring: remove ring quiesce in io_uring_register Jens Axboe
2022-02-04 16:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a9adb78-d9bb-a511-e4c1-c94cca392c9b@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=fam.zheng@bytedance.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=usama.arif@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.