From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 03/11] drm/i915/execlists: Suppress redundant preemption Date: Fri, 1 Mar 2019 15:07:58 +0000 Message-ID: <8aa2a8bb-0026-f8ff-8a87-7e9b4678c8a2@linux.intel.com> References: <20190226102404.29153-1-chris@chris-wilson.co.uk> <20190226102404.29153-3-chris@chris-wilson.co.uk> <917f2c43-3322-4e28-b020-cfc82ff9ea4e@linux.intel.com> <3fbfd350-6cec-31c5-142d-b0d80e2db6af@linux.intel.com> <155144020677.6459.6927636069799080582@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id A59BF6E2F7 for ; Fri, 1 Mar 2019 15:07:59 +0000 (UTC) In-Reply-To: <155144020677.6459.6927636069799080582@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAxLzAzLzIwMTkgMTE6MzYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTAxIDExOjMxOjI2KQo+Pgo+PiBwaW5nIG9uIGJlbG93Cj4+Cj4+ IE9uIDI4LzAyLzIwMTkgMTM6MTEsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Pj4KPj4+IE9uIDI2 LzAyLzIwMTkgMTA6MjMsIENocmlzIFdpbHNvbiB3cm90ZToKPj4+PiBPbiB1bndpbmRpbmcgdGhl IGFjdGl2ZSByZXF1ZXN0IHdlIGdpdmUgaXQgYSBzbWFsbCAobGltaXRlZCB0byBpbnRlcm5hbAo+ Pj4+IHByaW9yaXR5IGxldmVscykgYm9vc3QgdG8gcHJldmVudCBpdCBmcm9tIGJlaW5nIGdhenVt cGVkIGEgc2Vjb25kIHRpbWUuCj4+Pj4gSG93ZXZlciwgdGhpcyBtZWFucyB0aGF0IGl0IGNhbiBi ZSBwcm9tb3RlZCB0byBhYm92ZSB0aGUgcmVxdWVzdCB0aGF0Cj4+Pj4gdHJpZ2dlcmVkIHRoZSBw cmVlbXB0aW9uIHJlcXVlc3QsIGNhdXNpbmcgYSBwcmVlbXB0LXRvLWlkbGUgY3ljbGUgZm9yIG5v Cj4+Pj4gY2hhbmdlLiBXZSBjYW4gYXZvaWQgdGhpcyBpZiB3ZSB0YWtlIHRoZSBib29zdCBpbnRv IGFjY291bnQgd2hlbgo+Pj4+IGNoZWNraW5nIGlmIHRoZSBwcmVlbXB0aW9uIHJlcXVlc3QgaXMg dmFsaWQuCj4+Pj4KPj4+PiB2MjogQWZ0ZXIgcHJlZW1wdGlvbiB0aGUgYWN0aXZlIHJlcXVlc3Qg d2lsbCBiZSBhZnRlciB0aGUgcHJlZW1wdGVlIGlmCj4+Pj4gdGhleSBlbmQgdXAgd2l0aCBlcXVh bCBwcmlvcml0eS4KPj4+Pgo+Pj4+IHYzOiBUdnJ0a28gcG9pbnRlZCBvdXQgdGhhdCB0aGlzLCB0 aGUgZXhpc3RpbmcgbG9naWMsIG1ha2VzCj4+Pj4gSTkxNV9QUklPUklUWV9XQUlUIG5vbi1wcmVl bXB0aWJsZS4gRG9jdW1lbnQgdGhpcyBpbnRlcmVzdGluZyBxdWlyayEKPj4+Pgo+Pj4+IHY0OiBQ cm92ZSBUdnJ0a28gd2FzIHJpZ2h0IGFib3V0IFdBSVQgYmVpbmcgbm9uLXByZWVtcHRpYmxlIGFu ZCB0ZXN0IGl0Lgo+Pj4+IHY1OiBFeGNlcHQgbm90IGFsbCBwcmlvcml0aWVzIHdlcmUgbWFkZSBl cXVhbCwgYW5kIHRoZSBXQUlUIG5vdAo+Pj4+IHByZWVtcHRpbmcKPj4+PiBpcyBvbmx5IGlmIHdl IHN0YXJ0IG9mZiBhcyAhTkVXQ0xJRU5ULgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMg V2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+Pj4gQ2M6IFR2cnRrbyBVcnN1bGlu IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Pj4gLS0tCj4+Pj4gIMKgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMzggKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0KPj4+PiAgwqAgMSBmaWxlIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25z KC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMKPj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+Pj4gaW5kZXggMGUy MGYzYmM4MjEwLi5kYmExOWJhZjY4MDggMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfbHJjLmMKPj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYwo+Pj4+IEBAIC0xNjQsNiArMTY0LDggQEAKPj4+PiAgwqAgI2RlZmluZSBXQV9UQUlMX0RX T1JEUyAyCj4+Pj4gIMKgICNkZWZpbmUgV0FfVEFJTF9CWVRFUyAoc2l6ZW9mKHUzMikgKiBXQV9U QUlMX0RXT1JEUykKPj4+PiArI2RlZmluZSBBQ1RJVkVfUFJJT1JJVFkgKEk5MTVfUFJJT1JJVFlf TkVXQ0xJRU5UKQo+Pj4+ICsKPj4+PiAgwqAgc3RhdGljIGludCBleGVjbGlzdHNfY29udGV4dF9k ZWZlcnJlZF9hbGxvYyhzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dAo+Pj4+ICpjdHgsCj4+Pj4gIMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IGludGVsX2NvbnRleHQgKmNlKTsKPj4+PiBA QCAtMTkwLDggKzE5MiwzMCBAQCBzdGF0aWMgaW5saW5lIGludCBycV9wcmlvKGNvbnN0IHN0cnVj dAo+Pj4+IGk5MTVfcmVxdWVzdCAqcnEpCj4+Pj4gIMKgIHN0YXRpYyBpbnQgZWZmZWN0aXZlX3By aW8oY29uc3Qgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4+Pj4gIMKgIHsKPj4+PiArwqDCoMKg IGludCBwcmlvID0gcnFfcHJpbyhycSk7Cj4+Pj4gKwo+Pj4+ICvCoMKgwqAgLyoKPj4+PiArwqDC oMKgwqAgKiBPbiB1bndpbmRpbmcgdGhlIGFjdGl2ZSByZXF1ZXN0LCB3ZSBnaXZlIGl0IGEgcHJp b3JpdHkgYnVtcAo+Pj4+ICvCoMKgwqDCoCAqIGVxdWl2YWxlbnQgdG8gYSBmcmVzaGx5IHN1Ym1p dHRlZCByZXF1ZXN0LiBUaGlzIHByb3RlY3RzIGl0IGZyb20KPj4+PiArwqDCoMKgwqAgKiBiZWlu ZyBnYXp1bXBlZCBhZ2FpbiwgYnV0IGl0IHdvdWxkIGJlIHByZWZlcmFibGUgaWYgd2UgZGlkbid0 Cj4+Pj4gK8KgwqDCoMKgICogbGV0IGl0IGJlIGdhenVtcGVkIGluIHRoZSBmaXJzdCBwbGFjZSEK Pj4+PiArwqDCoMKgwqAgKgo+Pj4+ICvCoMKgwqDCoCAqIFNlZSBfX3Vud2luZF9pbmNvbXBsZXRl X3JlcXVlc3RzKCkKPj4+PiArwqDCoMKgwqAgKi8KPj4+PiArwqDCoMKgIGlmICh+cHJpbyAmIEFD VElWRV9QUklPUklUWSAmJiBfX2k5MTVfcmVxdWVzdF9oYXNfc3RhcnRlZChycSkpIHsKPj4+PiAr wqDCoMKgwqDCoMKgwqAgLyoKPj4+PiArwqDCoMKgwqDCoMKgwqDCoCAqIEFmdGVyIHByZWVtcHRp b24sIHdlIGluc2VydCB0aGUgYWN0aXZlIHJlcXVlc3QgYXQgdGhlCj4+Pj4gK8KgwqDCoMKgwqDC oMKgwqAgKiBlbmQgb2YgdGhlIG5ldyBwcmlvcml0eSBsZXZlbC4gVGhpcyBtZWFucyB0aGF0IHdl IHdpbGwgYmUKPj4+PiArwqDCoMKgwqDCoMKgwqDCoCAqIF9sb3dlcl8gcHJpb3JpdHkgdGhhbiB0 aGUgcHJlZW1wdGVlIGFsbCB0aGluZ3MgZXF1YWwgKGFuZAo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKg ICogc28gdGhlIHByZWVtcHRpb24gaXMgdmFsaWQpLCBzbyBhZGp1c3Qgb3VyIGNvbXBhcmlzb24K Pj4+PiArwqDCoMKgwqDCoMKgwqDCoCAqIGFjY29yZGluZ2x5Lgo+Pj4+ICvCoMKgwqDCoMKgwqDC oMKgICovCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHByaW8gfD0gQUNUSVZFX1BSSU9SSVRZOwo+Pj4+ ICvCoMKgwqDCoMKgwqDCoCBwcmlvLS07Cj4+Pj4gK8KgwqDCoCB9Cj4+Pj4gKwo+Pj4+ICDCoMKg wqDCoMKgIC8qIFJlc3RyaWN0IG1lcmUgV0FJVCBib29zdHMgZnJvbSB0cmlnZ2VyaW5nIHByZWVt cHRpb24gKi8KPj4+PiAtwqDCoMKgIHJldHVybiBycV9wcmlvKHJxKSB8IF9fTk9fUFJFRU1QVElP TjsKPj4+PiArwqDCoMKgIHJldHVybiBwcmlvIHwgX19OT19QUkVFTVBUSU9OOwo+Pj4+ICDCoCB9 Cj4+Pj4gIMKgIHN0YXRpYyBpbnQgcXVldWVfcHJpbyhjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5l X2V4ZWNsaXN0cyAqZXhlY2xpc3RzKQo+Pj4+IEBAIC0zNTksNyArMzgzLDcgQEAgX191bndpbmRf aW5jb21wbGV0ZV9yZXF1ZXN0cyhzdHJ1Y3QKPj4+PiBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkK Pj4+PiAgwqAgewo+Pj4+ICDCoMKgwqDCoMKgIHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCAqcm4s ICphY3RpdmUgPSBOVUxMOwo+Pj4+ICDCoMKgwqDCoMKgIHN0cnVjdCBsaXN0X2hlYWQgKnVuaW5p dGlhbGl6ZWRfdmFyKHBsKTsKPj4+PiAtwqDCoMKgIGludCBwcmlvID0gSTkxNV9QUklPUklUWV9J TlZBTElEIHwgSTkxNV9QUklPUklUWV9ORVdDTElFTlQ7Cj4+Pj4gK8KgwqDCoCBpbnQgcHJpbyA9 IEk5MTVfUFJJT1JJVFlfSU5WQUxJRCB8IEFDVElWRV9QUklPUklUWTsKPj4+PiAgwqDCoMKgwqDC oCBsb2NrZGVwX2Fzc2VydF9oZWxkKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2spOwo+Pj4+IEBAIC0z OTAsOSArNDE0LDE1IEBAIF9fdW53aW5kX2luY29tcGxldGVfcmVxdWVzdHMoc3RydWN0Cj4+Pj4g aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+Pj4gIMKgwqDCoMKgwqDCoCAqIFRoZSBhY3RpdmUg cmVxdWVzdCBpcyBub3cgZWZmZWN0aXZlbHkgdGhlIHN0YXJ0IG9mIGEgbmV3IGNsaWVudAo+Pj4+ ICDCoMKgwqDCoMKgwqAgKiBzdHJlYW0sIHNvIGdpdmUgaXQgdGhlIGVxdWl2YWxlbnQgc21hbGwg cHJpb3JpdHkgYnVtcCB0byBwcmV2ZW50Cj4+Pj4gIMKgwqDCoMKgwqDCoCAqIGl0IGJlaW5nIGdh enVtcGVkIGEgc2Vjb25kIHRpbWUgYnkgYW5vdGhlciBwZWVyLgo+Pj4+ICvCoMKgwqDCoCAqCj4+ Pj4gK8KgwqDCoMKgICogT25lIGNvbnNlcXVlbmNlIG9mIHRoaXMgcHJlZW1wdGlvbiBib29zdCBp cyB0aGF0IHdlIG1heSBqdW1wCj4+Pj4gK8KgwqDCoMKgICogb3ZlciBsZXNzZXIgcHJpb3JpdGll cyAoc3VjaCBhcyBJOTE1X1BSSU9SSVRZX1dBSVQpLCBlZmZlY3RpdmVseQo+Pj4+ICvCoMKgwqDC oCAqIG1ha2luZyB0aG9zZSBwcmlvcml0aWVzIG5vbi1wcmVlbXB0aWJsZS4gVGhleSB3aWxsIGJl IG1vdmVkCj4+Pj4gZm9yd2FyZAo+Pj4KPj4+IEFmdGVyIHRoZSBwcmV2aW91cyBwYXRjaCB3YWl0 IHByaW9yaXR5IGlzIG5vbi1wcmVlbXB0aWJsZSBieSBkZWZpbml0aW9uCj4+PiBtYWtpbmcgdGhp cyBzdWdnZXN0aW9uIHByZWVtcHRpb24gYm9vc3QgaXMgbWFraW5nIGl0IHNvIG5vdCBhY2N1cmF0 ZS4KPj4+Cj4+Pj4gK8KgwqDCoMKgICogaW4gdGhlIHByaW9yaXR5IHF1ZXVlLCBidXQgdGhleSB3 aWxsIG5vdCBnYWluIGltbWVkaWF0ZSBhY2Nlc3MgdG8KPj4+PiArwqDCoMKgwqAgKiB0aGUgR1BV Lgo+Pj4+ICDCoMKgwqDCoMKgwqAgKi8KPj4+PiAtwqDCoMKgIGlmICghKHByaW8gJiBJOTE1X1BS SU9SSVRZX05FV0NMSUVOVCkpIHsKPj4+PiAtwqDCoMKgwqDCoMKgwqAgcHJpbyB8PSBJOTE1X1BS SU9SSVRZX05FV0NMSUVOVDsKPj4+PiArwqDCoMKgIGlmICh+cHJpbyAmIEFDVElWRV9QUklPUklU WSAmJiBfX2k5MTVfcmVxdWVzdF9oYXNfc3RhcnRlZChhY3RpdmUpKSB7Cj4+Pgo+Pj4gV2hhdCBp cyB0aGUgaW1wb3J0YW5jZSBvZiB0aGUgaGFzX3N0YXJ0ZWQgY2hlY2s/IEhhc24ndCB0aGUgYWN0 aXZlCj4+PiByZXF1ZXN0IGJlZW4gcnVubmluZyBieSBkZWZpbml0aW9uPwo+IAo+IE5vLiBTZW1h cGhvcmVzLiBUaGlzIGlzIGFsbCBhYm91dCBkZWZlbmRpbmcgYWdhaW5zdCBpbmNvcnJlY3QgcHJv bW90aW9uCj4gd2hpbGUgYSByZXF1ZXN0IGlzIHN0aWxsIHNwaW5uaW5nIG9uIGl0cyBkZXBlbmRl bmNpZXMgKG9yIGVsc2Ugd2UgZ2V0Cj4gcHJvbW90ZWQgYWJvdmUgdGhlbSBhbmQgUEkgaXMgYnJv a2VuKS4KCklzIGluaXRfYnJlYWRjcnVtYiBhZnRlciB0aGUgc2VtYXBob3JlLCBpZS4gX19pOTE1 X3JlcXVlc3RfaGFzX3N0YXJ0ZWQgCndpbGwgYmUgZmFsc2Ugd2hpbGUgc3Bpbm5pbmcgb24gdGhl IHNlbWFwaG9yZS4gVGhhdCBwb3NzaWJseSBtYWtlcyAKc2Vuc2UuLiBCdXQgeW91IGtub3cgd2hh dCBJJ2xsIHNheSBuZXh0LiBJdCBpcyBleHRyZW1lbHkgc3VidGxlIGFuZCAKc3ByaW5rbGVkIG92 ZXIgdGhlIGNvZGUgc28gaGVyZSB3ZSBkZWZpbml0ZWx5IG5lZWQgYSBjb21tZW50IGV4cGxhaW5p bmcgaXQuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeA==