From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:44910 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727309AbeIYOxL (ORCPT ); Tue, 25 Sep 2018 10:53:11 -0400 Subject: Re: [Intel-gfx] [PATCH 35/40] drm/i915: Fix I915_EXEC_RING_MASK To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: stable@vger.kernel.org References: <20180919195544.1511-1-chris@chris-wilson.co.uk> <20180919195544.1511-35-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: <8aa77ddf-f07f-b50c-744e-2081c8e10395@linux.intel.com> Date: Tue, 25 Sep 2018 09:46:40 +0100 MIME-Version: 1.0 In-Reply-To: <20180919195544.1511-35-chris@chris-wilson.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 19/09/2018 20:55, Chris Wilson wrote: > This was supposed to be a mask of all known rings, but it is being used > by execbuffer to filter out invalid rings, and so is instead mapping high > unused values onto valid rings. Instead of a mask of all known rings, > we need it to be the mask of all possible rings. > > Fixes: 549f7365820a ("drm/i915: Enable SandyBridge blitter ring") > Fixes: de1add360522 ("drm/i915: Decouple execbuf uAPI from internal implementation") > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: # v4.6+ > --- > include/uapi/drm/i915_drm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > index adb9fed86ef7..65b0b84419f3 100644 > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -984,7 +984,7 @@ struct drm_i915_gem_execbuffer2 { > * struct drm_i915_gem_exec_fence *fences. > */ > __u64 cliprects_ptr; > -#define I915_EXEC_RING_MASK (7<<0) > +#define I915_EXEC_RING_MASK (0x3f) > #define I915_EXEC_DEFAULT (0<<0) > #define I915_EXEC_RENDER (1<<0) > #define I915_EXEC_BSD (2<<0) > Reviewed-by: Tvrtko Ursulin Regards, Tvrtko