From: Tony Krowiak <akrowiak@linux.ibm.com>
To: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: kbuild-all@lists.01.org, freude@linux.ibm.com,
borntraeger@de.ibm.com, cohuck@redhat.com,
mjrosato@linux.ibm.com, pasic@linux.ibm.com,
alex.williamson@redhat.com, kwankhede@nvidia.com
Subject: Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset
Date: Mon, 26 Oct 2020 12:57:12 -0400 [thread overview]
Message-ID: <8aa98c96-9194-504a-8e00-3354b5ca1d6c@linux.ibm.com> (raw)
In-Reply-To: <202010230305.RyRsFmf9-lkp@intel.com>
On 10/22/20 3:44 PM, kernel test robot wrote:
> Hi Tony,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on s390/features]
> [also build test WARNING on linus/master kvms390/next linux/master v5.9 next-20201022]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20201023-011543
> base: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
> config: s390-allyesconfig (attached as .config)
> compiler: s390-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/572c94c40a76754d49f07e4e383097d2db132f8c
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20201023-011543
> git checkout 572c94c40a76754d49f07e4e383097d2db132f8c
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/s390/crypto/vfio_ap_ops.c:1119:5: warning: no previous prototype for 'vfio_ap_mdev_reset_queue' [-Wmissing-prototypes]
> 1119 | int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
This function needs to be made static because it is no longer defined in
the header file.
>
> vim +/vfio_ap_mdev_reset_queue +1119 drivers/s390/crypto/vfio_ap_ops.c
>
> 258287c994de8f Tony Krowiak 2018-09-25 1118
> ec89b55e3bce7c Pierre Morel 2019-05-21 @1119 int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1120 unsigned int retry)
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1121 {
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1122 struct ap_queue_status status;
> ec89b55e3bce7c Pierre Morel 2019-05-21 1123 int retry2 = 2;
> ec89b55e3bce7c Pierre Morel 2019-05-21 1124 int apqn = AP_MKQID(apid, apqi);
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1125
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1126 do {
> ec89b55e3bce7c Pierre Morel 2019-05-21 1127 status = ap_zapq(apqn);
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1128 switch (status.response_code) {
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1129 case AP_RESPONSE_NORMAL:
> ec89b55e3bce7c Pierre Morel 2019-05-21 1130 while (!status.queue_empty && retry2--) {
> ec89b55e3bce7c Pierre Morel 2019-05-21 1131 msleep(20);
> ec89b55e3bce7c Pierre Morel 2019-05-21 1132 status = ap_tapq(apqn, NULL);
> ec89b55e3bce7c Pierre Morel 2019-05-21 1133 }
> 024cdcdbf3cf99 Halil Pasic 2019-09-03 1134 WARN_ON_ONCE(retry2 <= 0);
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1135 return 0;
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1136 case AP_RESPONSE_RESET_IN_PROGRESS:
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1137 case AP_RESPONSE_BUSY:
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1138 msleep(20);
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1139 break;
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1140 default:
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1141 /* things are really broken, give up */
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1142 return -EIO;
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1143 }
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1144 } while (retry--);
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1145
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1146 return -EBUSY;
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1147 }
> 46a7263d4746a2 Tony Krowiak 2018-09-25 1148
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2020-10-26 16:57 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 17:11 [PATCH v11 00/14] s390/vfio-ap: dynamic configuration support Tony Krowiak
2020-10-22 17:11 ` [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset Tony Krowiak
2020-10-22 19:44 ` kernel test robot
2020-10-22 19:44 ` kernel test robot
2020-10-26 16:57 ` Tony Krowiak [this message]
2020-10-27 6:48 ` Halil Pasic
2020-10-29 23:29 ` Tony Krowiak
2020-10-30 16:13 ` Tony Krowiak
2020-10-30 17:27 ` Halil Pasic
2020-10-30 20:45 ` Tony Krowiak
2020-10-30 17:42 ` Halil Pasic
2020-10-30 20:37 ` Tony Krowiak
2020-10-31 3:43 ` Halil Pasic
2020-11-02 14:35 ` Tony Krowiak
2020-10-30 17:54 ` Halil Pasic
2020-10-30 20:53 ` Tony Krowiak
2020-10-30 21:13 ` Tony Krowiak
2020-10-30 17:56 ` Halil Pasic
2020-10-30 21:17 ` Tony Krowiak
2020-10-22 17:11 ` [PATCH v11 02/14] 390/vfio-ap: use new AP bus interface to search for queue devices Tony Krowiak
2020-10-27 7:01 ` Halil Pasic
2020-11-02 21:57 ` Tony Krowiak
2020-10-22 17:11 ` [PATCH v11 03/14] s390/vfio-ap: manage link between queue struct and matrix mdev Tony Krowiak
2020-10-27 9:33 ` Halil Pasic
2020-10-22 17:11 ` [PATCH v11 04/14] s390/zcrypt: driver callback to indicate resource in use Tony Krowiak
2020-10-27 13:01 ` Halil Pasic
2020-10-27 16:55 ` Harald Freudenberger
2020-11-13 21:30 ` Tony Krowiak
2020-11-14 0:00 ` Halil Pasic
2020-11-16 16:23 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 05/14] s390/vfio-ap: implement in-use callback for vfio_ap driver Tony Krowiak
2020-10-27 13:27 ` Halil Pasic
2020-11-13 17:14 ` Tony Krowiak
2020-11-13 23:47 ` Halil Pasic
2020-11-16 16:58 ` Tony Krowiak
2020-11-23 17:03 ` Cornelia Huck
2020-11-23 19:23 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 06/14] s390/vfio-ap: introduce shadow APCB Tony Krowiak
2020-10-28 8:11 ` Halil Pasic
2020-11-13 17:18 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 07/14] s390/vfio-ap: sysfs attribute to display the guest's matrix Tony Krowiak
2020-10-28 8:17 ` Halil Pasic
2020-11-13 17:27 ` Tony Krowiak
2020-11-13 23:12 ` Halil Pasic
2020-11-19 18:15 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device Tony Krowiak
2020-10-22 20:30 ` kernel test robot
2020-10-22 20:30 ` kernel test robot
2020-10-26 17:04 ` Tony Krowiak
2020-10-28 13:57 ` Halil Pasic
2020-11-03 22:49 ` Tony Krowiak
2020-11-04 12:52 ` Halil Pasic
2020-11-04 21:20 ` Tony Krowiak
2020-11-05 12:27 ` Halil Pasic
2020-11-13 20:36 ` Tony Krowiak
2020-11-04 13:23 ` Halil Pasic
2020-10-22 17:12 ` [PATCH v11 09/14] s390/vfio-ap: allow assignment of unavailable AP queues to mdev device Tony Krowiak
2020-10-28 15:03 ` Halil Pasic
2020-10-22 17:12 ` [PATCH v11 10/14] s390/vfio-ap: allow hot plug/unplug of AP resources using " Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 11/14] s390/zcrypt: Notify driver on config changed and scan complete callbacks Tony Krowiak
2020-10-27 17:28 ` Harald Freudenberger
2020-11-13 20:58 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 12/14] s390/vfio-ap: handle host AP config change notification Tony Krowiak
2020-10-22 21:17 ` kernel test robot
2020-10-22 21:17 ` kernel test robot
2020-10-26 17:07 ` Tony Krowiak
2020-10-26 17:21 ` Tony Krowiak
2020-11-03 9:48 ` kernel test robot
2020-11-03 9:48 ` kernel test robot
2020-11-13 21:06 ` Tony Krowiak
2020-11-13 21:06 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 13/14] s390/vfio-ap: handle AP bus scan completed notification Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 14/14] s390/vfio-ap: update docs to include dynamic config support Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aa98c96-9194-504a-8e00-3354b5ca1d6c@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=freude@linux.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.