From: Paolo Bonzini <pbonzini@redhat.com>
To: David Matlack <dmatlack@google.com>
Cc: Jim Mattson <jmattson@google.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v2 0/3] Regression test for L1 LDTR persistence bug
Date: Tue, 30 Nov 2021 09:42:08 +0100 [thread overview]
Message-ID: <8aaac107-4b90-4eb3-8c73-a5e323462707@redhat.com> (raw)
In-Reply-To: <CALzav=c63DpoBYzhkWeU20tiiH7uv1HfsUaM=RFTuAWOZSybMg@mail.gmail.com>
On 11/29/21 23:19, David Matlack wrote:
>> The selftests infrastructure already has save/restore tests at
>> instruction granularity (state_test.c) so you should have more luck that
>> way; these tests are worthwhile anyway.
> There is also (I just discovered) support for guest-triggerable
> migration in the kvm-unit-tests [1]. You could use that to trigger a
> save/restore.
There is, but I don't think it's good. Save/restore bugs almost
invariably depend on very specific processor state, and it's hard to
ensure that in kvm-unit-tests (except probabilistically, but we can do
better).
Paolo
> [1] Example:https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/blob/master/arm/gic.c#L798
>
next prev parent reply other threads:[~2021-11-30 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 19:55 [kvm-unit-tests PATCH v2 0/3] Regression test for L1 LDTR persistence bug Jim Mattson
2021-10-15 19:55 ` [kvm-unit-tests PATCH v2 1/3] x86: Fix operand size for lldt Jim Mattson
2021-10-15 19:55 ` [kvm-unit-tests PATCH v2 2/3] x86: Make set_gdt_entry usable in 64-bit mode Jim Mattson
2021-10-15 19:55 ` [kvm-unit-tests PATCH v2 3/3] x86: Add a regression test for L1 LDTR persistence bug Jim Mattson
2021-11-10 19:50 ` [kvm-unit-tests PATCH v2 0/3] Regression " Jim Mattson
2021-11-10 21:44 ` Paolo Bonzini
2021-11-29 22:19 ` David Matlack
2021-11-30 8:42 ` Paolo Bonzini [this message]
2021-11-11 17:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aaac107-4b90-4eb3-8c73-a5e323462707@redhat.com \
--to=pbonzini@redhat.com \
--cc=dmatlack@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.