From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE31C433FE for ; Fri, 4 Dec 2020 08:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F00A022581 for ; Fri, 4 Dec 2020 08:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728831AbgLDIbO (ORCPT ); Fri, 4 Dec 2020 03:31:14 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:42415 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbgLDIbO (ORCPT ); Fri, 4 Dec 2020 03:31:14 -0500 Received: from [192.168.1.155] ([95.114.158.118]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1McY0J-1kAPBb3rJt-00cyWv; Fri, 04 Dec 2020 09:28:31 +0100 Subject: Re: [PATCH] drivers: gpio: add virtio-gpio guest driver To: Michael Walle , "Enrico Weigelt, metux IT consult" Cc: Bartosz Golaszewski , "Michael S. Tsirkin" , LKML , Linus Walleij , Jason Wang , linux-gpio , virtualization@lists.linux-foundation.org, linux-riscv@lists.infradead.org References: <20201127183003.2849-1-info@metux.net> From: "Enrico Weigelt, metux IT consult" Message-ID: <8ab347b9-8b1a-f49f-d194-f98284fa6099@metux.net> Date: Fri, 4 Dec 2020 09:28:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:dUT0JUegZ42giGfrKmvHoKDvhv2oHRjR2063rWeXiFKSlSKKSyF WV3WiUrtvsZF8oudGAy6r09BIw/6WCr/bvdKoDhqqeFsgRNMxZiIcr/bEbVJVAbNONrMlLL ZKyfCItATcn+5Cjf9IiwAlWeioaYBVHkZbBmOtEJMapTGLJGku2ayhdFc+ZdiwURrgBL1zQ eYyGWJ48hhAM00fOJggdg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wJpMIBpJjRM=:Zv5F/JE0GNEQiLQcvQT3Kk pvvBPGjOoKfmD6WIu2hZZcnJuc4GTp8QcZIOCWowwKSVSAYayPuVlHPEQBSd5V6Q1xlMbogB1 ZWbgeu2rVH0pueqyXhtJgRoLMTBBdPGQ8mirjUMQ7NR1LUc9HrN2CWbR/51Ggqh4j9F9o0MuA 3acqKkusqAK1L0lguerq37BmBS7ugEVE4jJurmX+A4lhZ1+NNIpRcIr5sxHXQCmT/8aq/F1rJ KdlTugkX5k5yx9l+2MusPfQefa6xGnZpi5GRsi/CvyJh6aZDDuk3csd7iDLX6/IF/qYkGx6g1 NFg6+7jGf9gJ+bSkiuomIcRIsWd9YFvB9RV/YO+OhY1uhUajnKCIsiRRG+YX2Unkn98FNq044 wVDPk/nv94eA/WxauJpokuglPDiEl86izI+N7eEyp5db3b9Ziib556pDZqpfk Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 03.12.20 23:35, Michael Walle wrote: > Am 2020-12-03 20:00, schrieb Enrico Weigelt, metux IT consult: >> On 02.12.20 15:15, Bartosz Golaszewski wrote: >>>> +               bufwalk = name_buffer; >>>> + >>>> +               while (idx < priv->num_gpios && >>>> +                      bufwalk < (name_buffer+cf.names_size)) { >>>> +                       gpio_names[idx] = (strlen(bufwalk) ? bufwalk >>>> : NULL); >>>> +                       bufwalk += strlen(bufwalk)+1; >>>> +                       idx++; >>> >>> >>> Something's wrong with indentation here. >> >> i dont think so: the "bufwalk ..." line belongs to the while expression >> and is right under the "idx", as it should be. I didn't want to break up >> at the "<" operator. shall i do this instead ? > > Or don't break the lines at all. Both lines don't add up to more than > 100 chars, > right? IIRC checkpatch complains at 80 chars. Has that been changed ? --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5083AC433FE for ; Fri, 4 Dec 2020 08:28:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB1DD207C8 for ; Fri, 4 Dec 2020 08:28:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB1DD207C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=metux.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T+frbwz9hrBXnZZ1MdHlvDIjIskLGcgHqIGUtRgFZ98=; b=KbtvSnsoS07PKn4hT1vqqiC/A d5of5xpbDKSPaB0MhaEz9N8VENq60ucBtZmRRZdU3UzERsOtxdGwjATeV6hCcQv/DAuWI2BeFMPem +rino4Tbu3pB4FNHjXn05a9o0tJ2MhEO1O5fppp/tIJ8g8FosD9pNxJY9xZ4NuFDgHuOe4xpO/dUv mqblIzwmo9OIHiagXeOTSYDiDSpBukTnQgPYWoOlF+2tawjCRSPGvcRacoH3fiYdZ3ROxsz7OoJ35 x6Mkxp75Q2MGEgnTG99n9wWrdOJYhR51bZJGOzj6hhK+ctPI3ZLBJ3QGHaZDmiI8TC77h8C+yv3OV U8RXt6BXg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kl6SK-0006uC-Cd; Fri, 04 Dec 2020 08:28:44 +0000 Received: from mout.kundenserver.de ([212.227.17.13]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kl6SH-0006tW-Bm for linux-riscv@lists.infradead.org; Fri, 04 Dec 2020 08:28:42 +0000 Received: from [192.168.1.155] ([95.114.158.118]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1McY0J-1kAPBb3rJt-00cyWv; Fri, 04 Dec 2020 09:28:31 +0100 Subject: Re: [PATCH] drivers: gpio: add virtio-gpio guest driver To: Michael Walle , "Enrico Weigelt, metux IT consult" References: <20201127183003.2849-1-info@metux.net> From: "Enrico Weigelt, metux IT consult" Message-ID: <8ab347b9-8b1a-f49f-d194-f98284fa6099@metux.net> Date: Fri, 4 Dec 2020 09:28:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: tl X-Provags-ID: V03:K1:dUT0JUegZ42giGfrKmvHoKDvhv2oHRjR2063rWeXiFKSlSKKSyF WV3WiUrtvsZF8oudGAy6r09BIw/6WCr/bvdKoDhqqeFsgRNMxZiIcr/bEbVJVAbNONrMlLL ZKyfCItATcn+5Cjf9IiwAlWeioaYBVHkZbBmOtEJMapTGLJGku2ayhdFc+ZdiwURrgBL1zQ eYyGWJ48hhAM00fOJggdg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wJpMIBpJjRM=:Zv5F/JE0GNEQiLQcvQT3Kk pvvBPGjOoKfmD6WIu2hZZcnJuc4GTp8QcZIOCWowwKSVSAYayPuVlHPEQBSd5V6Q1xlMbogB1 ZWbgeu2rVH0pueqyXhtJgRoLMTBBdPGQ8mirjUMQ7NR1LUc9HrN2CWbR/51Ggqh4j9F9o0MuA 3acqKkusqAK1L0lguerq37BmBS7ugEVE4jJurmX+A4lhZ1+NNIpRcIr5sxHXQCmT/8aq/F1rJ KdlTugkX5k5yx9l+2MusPfQefa6xGnZpi5GRsi/CvyJh6aZDDuk3csd7iDLX6/IF/qYkGx6g1 NFg6+7jGf9gJ+bSkiuomIcRIsWd9YFvB9RV/YO+OhY1uhUajnKCIsiRRG+YX2Unkn98FNq044 wVDPk/nv94eA/WxauJpokuglPDiEl86izI+N7eEyp5db3b9Ziib556pDZqpfk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201204_032841_763746_90F00110 X-CRM114-Status: UNSURE ( 9.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio , Jason Wang , "Michael S. Tsirkin" , LKML , virtualization@lists.linux-foundation.org, Bartosz Golaszewski , linux-riscv@lists.infradead.org, Linus Walleij Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gMDMuMTIuMjAgMjM6MzUsIE1pY2hhZWwgV2FsbGUgd3JvdGU6Cj4gQW0gMjAyMC0xMi0wMyAy MDowMCwgc2NocmllYiBFbnJpY28gV2VpZ2VsdCwgbWV0dXggSVQgY29uc3VsdDoKPj4gT24gMDIu MTIuMjAgMTU6MTUsIEJhcnRvc3ogR29sYXN6ZXdza2kgd3JvdGU6Cj4+Pj4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgYnVmd2FsayA9IG5hbWVfYnVmZmVyOwo+Pj4+ICsKPj4+PiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB3aGlsZSAoaWR4IDwgcHJpdi0+bnVtX2dwaW9zICYm Cj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBidWZ3YWxr IDwgKG5hbWVfYnVmZmVyK2NmLm5hbWVzX3NpemUpKSB7Cj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdwaW9fbmFtZXNbaWR4XSA9IChzdHJsZW4oYnVm d2FsaykgPyBidWZ3YWxrCj4+Pj4gOiBOVUxMKTsKPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYnVmd2FsayArPSBzdHJsZW4oYnVmd2FsaykrMTsKPj4+ PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWR4Kys7Cj4+ Pgo+Pj4KPj4+IFNvbWV0aGluZydzIHdyb25nIHdpdGggaW5kZW50YXRpb24gaGVyZS4KPj4KPj4g aSBkb250IHRoaW5rIHNvOiB0aGUgImJ1ZndhbGsgLi4uIiBsaW5lIGJlbG9uZ3MgdG8gdGhlIHdo aWxlIGV4cHJlc3Npb24KPj4gYW5kIGlzIHJpZ2h0IHVuZGVyIHRoZSAiaWR4IiwgYXMgaXQgc2hv dWxkIGJlLiBJIGRpZG4ndCB3YW50IHRvIGJyZWFrIHVwCj4+IGF0IHRoZSAiPCIgb3BlcmF0b3Iu IHNoYWxsIGkgZG8gdGhpcyBpbnN0ZWFkID8KPiAKPiBPciBkb24ndCBicmVhayB0aGUgbGluZXMg YXQgYWxsLiBCb3RoIGxpbmVzIGRvbid0IGFkZCB1cCB0byBtb3JlIHRoYW4KPiAxMDAgY2hhcnMs Cj4gcmlnaHQ/CgpJSVJDIGNoZWNrcGF0Y2ggY29tcGxhaW5zIGF0IDgwIGNoYXJzLiBIYXMgdGhh dCBiZWVuIGNoYW5nZWQgPwoKCi0tbXR4CgoKLS0gCi0tLQpIaW53ZWlzOiB1bnZlcnNjaGzDvHNz ZWx0ZSBFLU1haWxzIGvDtm5uZW4gbGVpY2h0IGFiZ2Vow7ZydCB1bmQgbWFuaXB1bGllcnQKd2Vy ZGVuICEgRsO8ciBlaW5lIHZlcnRyYXVsaWNoZSBLb21tdW5pa2F0aW9uIHNlbmRlbiBTaWUgYml0 dGUgaWhyZW4KR1BHL1BHUC1TY2hsw7xzc2VsIHp1LgotLS0KRW5yaWNvIFdlaWdlbHQsIG1ldHV4 IElUIGNvbnN1bHQKRnJlZSBzb2Z0d2FyZSBhbmQgTGludXggZW1iZWRkZWQgZW5naW5lZXJpbmcK aW5mb0BtZXR1eC5uZXQgLS0gKzQ5LTE1MS0yNzU2NTI4NwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4 LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=