From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:33344 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754936AbcHWVMJ (ORCPT ); Tue, 23 Aug 2016 17:12:09 -0400 Received: by mail-pf0-f194.google.com with SMTP id i6so8870869pfe.0 for ; Tue, 23 Aug 2016 14:11:33 -0700 (PDT) Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64 To: Cyril Hrubis , Jeff Layton References: <1471461304.3196.101.camel@redhat.com> <1471464343.3196.125.camel@redhat.com> <20160817203746.GF21655@vapier.lan> <1471467478.3196.143.camel@redhat.com> <20160817213522.GG21655@vapier.lan> <1471470526.3196.153.camel@redhat.com> <8e1a972a-7966-139b-9d75-6d3a847a1be8@redhat.com> <20160823110343.GA4962@rei.suse.cz> <1471952179.13027.3.camel@redhat.com> <20160823113830.GB4962@rei.suse.cz> Cc: mtk.manpages@gmail.com, Florian Weimer , Mike Frysinger , libc-alpha@sourceware.org, linux-fsdevel@vger.kernel.org, Carlos O'Donell , Yuriy Kolerov From: "Michael Kerrisk (man-pages)" Message-ID: <8acbfa50-516f-d402-928f-9a391610557d@gmail.com> Date: Wed, 24 Aug 2016 09:10:21 +1200 MIME-Version: 1.0 In-Reply-To: <20160823113830.GB4962@rei.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 08/23/2016 11:38 PM, Cyril Hrubis wrote: > Hi! >> To be clear, that approach was NAK'ed by Christoph (and I think that's >> a good thing, actually -- one more nail in the non-LFS coffin). I think >> what we want merged into glibc is this patch that I sent late on >> Thursday: >> >> [glibc PATCHv2] fcntl: don't define OFD lock constants for 32-bit builds with small file offsets >> >> We'll also need your patch to the fcntl(2) manpage as well, but that's >> a separate problem. > > Hmm, the patch for man-pages should be updated as well. We need > somethign as: > > ... > This lock type is Linux-specific, and available since Linux 3.15. > On 32bit platform _FILE_OFFSET_BITS must defined to 64 (before including > any header files) to make these locks available. > ... > > Michael should I send updated patch or will you take care of this? I can do it, or you can. At the moment, I'm just holding off until I see what is accepted into glibc. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/