From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CC6C35670 for ; Sun, 23 Feb 2020 04:21:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4181D208C4 for ; Sun, 23 Feb 2020 04:21:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbgBWEVb (ORCPT ); Sat, 22 Feb 2020 23:21:31 -0500 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:60286 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726983AbgBWEVb (ORCPT ); Sat, 22 Feb 2020 23:21:31 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R671e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04455;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0TqdtHoh_1582431686; Received: from 30.27.235.101(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0TqdtHoh_1582431686) by smtp.aliyun-inc.com(127.0.0.1); Sun, 23 Feb 2020 12:21:28 +0800 Subject: Re: [PATCH] crypto: sm3 - export crypto_sm3_final function To: Herbert Xu Cc: davem@davemloft.net, ebiggers@kernel.org, pvanleeuwen@rambus.com, zohar@linux.ibm.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, gilad@benyossef.com References: <20200216090233.109416-1-tianjia.zhang@linux.alibaba.com> <20200222011926.GA18695@gondor.apana.org.au> From: Tianjia Zhang Message-ID: <8acc79e8-8b3d-856d-06d2-5322c9a66be9@linux.alibaba.com> Date: Sun, 23 Feb 2020 12:21:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200222011926.GA18695@gondor.apana.org.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2020/2/22 9:19, Herbert Xu wrote: > On Sun, Feb 16, 2020 at 05:02:33PM +0800, Tianjia Zhang wrote: >> Both crypto_sm3_update and crypto_sm3_finup have been >> exported, exporting crypto_sm3_final, to avoid having to >> use crypto_sm3_finup(desc, NULL, 0, dgst) to calculate >> the hash in some cases. >> >> Signed-off-by: Tianjia Zhang >> --- >> crypto/sm3_generic.c | 7 ++++--- >> include/crypto/sm3.h | 2 ++ >> 2 files changed, 6 insertions(+), 3 deletions(-) > > Please add this into the series that actually uses the function. > It makes no sense on its own. > > Thanks, > The actual use of this function is in sm2 and OSCCA certificates. This set of patches has been submitted to the community. Please review them.