From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs Date: Wed, 29 Mar 2017 08:52:53 +0200 Message-ID: <8acdbd65-f99d-3e0e-b61b-318cf27d7a3b@vodafone.de> References: <1490749231-16157-1-git-send-email-Felix.Kuehling@amd.com> <1490749231-16157-4-git-send-email-Felix.Kuehling@amd.com> <58DB21CB.4090800@amd.com> <58DB4D02.7020903@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <58DB4D02.7020903-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Zhang, Jerry (Junwei)" , "Kuehling, Felix" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Koenig, Christian" , "Zhou, David(ChunMing)" Cc: "Deucher, Alexander" , "Russell, Kent" QW0gMjkuMDMuMjAxNyB1bSAwNzo1OCBzY2hyaWViIFpoYW5nLCBKZXJyeSAoSnVud2VpKToKPiBI aSBGZWxpeCwKPgo+IFRoYW5rcyBmb3IgeW91ciBpbGx1c3RyYXRpb24gd2l0aCBwYXRpZW5jZS4K PiBJIGdvdCB5b3VyIG1lYW5pbmcgdGhlbiwgYW5kIHRoYW5rcyB0byBmaXggdGhhdC4KPgo+ID4g SSB0aGluayB5b3UncmUgcmlnaHQsIHRoZXJlIGFyZSBzb21lIGV4dHJhIGhpZ2ggYml0cyBpbiBz YWRkciBhbmQgCj4gZWFkZHIsIGJ1dAo+ID4gdGhleSBnZXQgZGlzY2FyZGVkIGJ5IHRoZSBtb2R1 bG8tZGl2aXNpb24gaW4gdGhlIG5leHQgcmVjdXJzaW9uIAo+IGxldmVsLiBGb3IKPiA+IGFkZGVk IGNsYXJpdHkgdGhlIG1vZHVsbyBkaXZpc2lvbiAob3IgbWFza2luZyBvZiBoaWdoIGJpdHMpIGNv dWxkIGJlIAo+IG1vdmVkIHVwCj4gPiB0byB0aGUgY2FsbGVyLgo+Cj4gSXQgbWF5IGJlIG1vcmUg Y2xlYXIgaWYgbW9kdWxvLWRpdmlzaW9uIGNhbGxlZCBiZWZvcmUgdGhlIGNhbGxlci4KClllYWgs IGluZGVlZCB0aGF0IGlzbid0IGVhc3kgdG8gZ2V0IG9uIGZpcnN0IGdsYW5jZS4KClBsZWFzZSBj bGVhbiB0aGF0IHVwIGFuZCBhbHNvIHJlbW92ZSBhbGwgdGhvc2UgV0FSTl9PTigpLCB3ZSBkb24n dCB3YW50IAp0byBzcGFtIHRoZSBzeXN0ZW0gbG9nIHdpdGggYmFja3RyYWNlcyBsaWtlIHRoaXMu CgpSZWdhcmRzLApDaHJpc3RpYW4uCgo+IEFueXdheSwKPiBSZXZpZXdlZC1ieTogSnVud2VpIFpo YW5nIDxKZXJyeS5aaGFuZ0BhbWQuY29tPgo+Cj4KPiBPbiAwMy8yOS8yMDE3IDExOjI0IEFNLCBL dWVobGluZywgRmVsaXggd3JvdGU6Cj4+IEhpIEplcnJ5LAo+Pgo+PiBMZXQgbWUgY2xhcmlmeSBt eSB1bmRlcnN0YW5kaW5nIG9mIHRoZSBwcm9ibGVtIGFuZCB0aGUgaW50ZW50aW9uIG9mIAo+PiB0 aGUgZml4Lgo+Pgo+PiBBZGRyZXNzIHJhbmdlIHBlciBwYWdlOiA0S0IKPj4gQWRkcmVzcyByYW5n ZSBwZXIgUFQgKGxldmVsIDMpOiAyTUIKPj4gQWRkcmVzcyByYW5nZSBwZXIgUEQgKGxldmVsIDIp OiAxR0IKPj4gQWRkcmVzcyByYW5nZSBwZXIgUEQgKGxldmVsIDEpOiA1MTJHQgo+PiBBZGRyZXNz IHJhbmdlIHBlciBQRCAobGV2ZWwgMCk6IDI1NlRCCj4+Cj4+IEltYWdpbmUgZm9yIGV4YW1wbGUg YSBtYXBwaW5nIHRoYXQgc3BhbnMgbXVsdGlwbGUgbGV2ZWwgMiBwYWdlIAo+PiBkaXJlY3Rvcmll cy4gU2F5Cj4+IGZyb20gMC41R0IgdG8gMi41R0IuCj4+Cj4+IEF0IGxldmVsIDA6Cj4+IGZyb20g PSAwCj4+IHRvID0gMAo+Pgo+PiBBdCBsZXZlbCAxOgo+PiBmcm9tID0gMAo+PiB0byA9IDIKPj4K Pj4gU28gZm9yIGxldmVsIDIgYW1kZ3B1X3ZtX2FsbG9jX2xldmVscyBnZXRzIGNhbGxlZCAzIHRp bWVzIChwdF9pZHggPSAKPj4gWzAuLjJdKS4KPj4gV2l0aG91dCBteSBjaGFuZ2UsIGl0IGdldHMg Y2FsbGVkIHdpdGggdGhlIHNhbWUgc2FkZHIgYW5kIGVhZGRyIDMgCj4+IHRpbWVzLiBTbyBpdAo+ PiBjYWxjdWxhdGVzIHRoZSBzYW1lICJmcm9tIiBhbmQgInRvIiBlYWNoIHRpbWU6Cj4+IGZyb20g PSAyNTYgJSA1MTIgPSAyNTYKPj4gdG8gPSA3NjcgJSA1MTIgPSAyNTUKPj4KPj4gT2J2aW91c2x5 IHRoYXQgZG9lc24ndCB3b3JrLiBXaGF0IHdlIHJlYWxseSB3YW50IGlzIHRoaXMgKGZyb20uLnRv IGluIAo+PiBsZXZlbCAyCj4+IHdoZW4gY2FsbGVkIGZvciBwdF9pZHggdmFsdWVzIGZyb20gbGV2 ZWwgMSk6Cj4+Cj4+IEZvciBwdF9pZHg9MCB3ZSB3YW50IHRvIGZpbGwgdGhlIHNlY29uZCBoYWxm IG9mIHRoZSBsZXZlbCAyIHBhZ2UgCj4+IGRpcmVjdG9yeSB3aXRoCj4+IHBhZ2UgdGFibGVzOgo+ PiBmcm9tID0gMjU2Cj4+IHRvID0gNTExCj4+Cj4+IEZvciBwdF9pZHg9MSB3ZSBuZWVkIHRvIGZp bGwgdGhlIGVudGlyZSBsZXZlbCAyIHBhZ2UgZGlyZWN0b3JpZXMgd2l0aCAKPj4gcGFnZSB0YWJs ZXM6Cj4+IGZyb20gPSAwCj4+IHRvID0gNTExCj4+Cj4+IEZvciBwdF9pZHg9MiB3ZSB3YW50IHRv IGZpbGwgdGhlIGZpcnN0IGhhbGYgb2YgdGhlIGxldmVsIDIgcGFnZSAKPj4gZGlyZWN0b3J5IHdp dGgKPj4gcGFnZSB0YWJsZXM6Cj4+IGZyb20gPSAwCj4+IHRvID0gMjU1Cj4+Cj4+IFRoaXMgY3Jl YXRlcyBhIGNvbnRpZ3VvdXMgcmFuZ2Ugb2YgcGFnZSB0YWJsZXMgYWNyb3NzIHRoZSB0aHJlZSBs ZXZlbCAKPj4gMiBwYWdlCj4+IGRpcmVjdG9yaWVzIHRoYXQgYXJlIHNwYW5uZWQgYnkgdGhlIGFs bG9jYXRpb24uIE15IGNoYW5nZSBhY2hpZXZlcyB0aGF0Lgo+Pgo+PiBJIHRoaW5rIHlvdSdyZSBy aWdodCwgdGhlcmUgYXJlIHNvbWUgZXh0cmEgaGlnaCBiaXRzIGluIHNhZGRyIGFuZCAKPj4gZWFk ZHIsIGJ1dAo+PiB0aGV5IGdldCBkaXNjYXJkZWQgYnkgdGhlIG1vZHVsby1kaXZpc2lvbiBpbiB0 aGUgbmV4dCByZWN1cnNpb24gCj4+IGxldmVsLiBGb3IKPj4gYWRkZWQgY2xhcml0eSB0aGUgbW9k dWxvIGRpdmlzaW9uIChvciBtYXNraW5nIG9mIGhpZ2ggYml0cykgY291bGQgYmUgCj4+IG1vdmVk IHVwCj4+IHRvIHRoZSBjYWxsZXIuCj4+Cj4+IFJlZ2FyZHMsCj4+ICAgIEZlbGl4Cj4+Cj4+Cj4+ IC0tIAo+PiBGIGUgbCBpIHggICBLIHUgZSBoIGwgaSBuIGcKPj4gU01UUyBTb2Z0d2FyZSBEZXZl bG9wbWVudCBFbmdpbmVlciB8IFZlcnRpY2FsIFdvcmtzdGF0aW9uL0NvbXB1dGUKPj4gMSBDb21t ZXJjZSBWYWxsZXkgRHIuIEVhc3QsIE1hcmtoYW0sIE9OIEwzVCA3WDYgQ2FuYWRhCj4+IChPKSAr MSgyODkpNjk1LTE1OTcKPj4gICAgIF8gICAgIF8gICBfICAgX19fX18gICBfX19fXwo+PiAgICAv IFwgICB8IFwgLyB8IHwgIF8gIFwgIFwgXyAgfAo+PiAgIC8gQSBcICB8IFxNLyB8IHwgfEQpICkg IC98X3wgfAo+PiAvXy8gXF9cIHxffCB8X3wgfF9fX19fLyB8X18vIFx8ICAgZmFjZWJvb2suY29t L0FNRCB8IGFtZC5jb20KPj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSAKPj4KPj4gKkZyb206KiBa aGFuZywgSmVycnkKPj4gKlNlbnQ6KiBUdWVzZGF5LCBNYXJjaCAyOCwgMjAxNyAxMDo1NDowMyBQ TQo+PiAqVG86KiBLdWVobGluZywgRmVsaXg7IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn OyBLb2VuaWcsIAo+PiBDaHJpc3RpYW47IFpob3UsCj4+IERhdmlkKENodW5NaW5nKQo+PiAqQ2M6 KiBEZXVjaGVyLCBBbGV4YW5kZXI7IFJ1c3NlbGwsIEtlbnQKPj4gKlN1YmplY3Q6KiBSZTogW1BB VENIIDMvM10gZHJtL2FtZGdwdTogRml4IG11bHRpLWxldmVsIHBhZ2UgdGFibGUgCj4+IGJ1Z3Mg Zm9yCj4+IGxhcmdlIEJPcwo+PiBPbiAwMy8yOS8yMDE3IDA5OjAwIEFNLCBGZWxpeCBLdWVobGlu ZyB3cm90ZToKPj4+IEZpeCB0aGUgc3RhcnQvZW5kIGFkZHJlc3MgY2FsY3VsYXRpb24gZm9yIGFk ZHJlc3MgcmFuZ2VzIHRoYXQgc3Bhbgo+Pj4gbXVsdGlwbGUgcGFnZSBkaXJlY3RvcmllcyBpbiBh bWRncHVfdm1fYWxsb2NfbGV2ZWxzLgo+Pj4KPj4+IEFkZCBXQVJOX09OcyBpZiBwYWdlIHRhYmxl cyBhcmVuJ3QgZm91bmQuIE90aGVyd2lzZSB0aGUgcGFnZSB0YWJsZQo+Pj4gdXBkYXRlIHdvdWxk IGp1c3QgZmFpbCBzaWxlbnRseS4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBGZWxpeCBLdWVobGlu ZyA8RmVsaXguS3VlaGxpbmdAYW1kLmNvbT4KPj4+IC0tLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfdm0uYyB8IDEzICsrKysrKysrKystLS0KPj4+ICAgMSBmaWxlIGNo YW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jIAo+Pj4gYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+Pj4gaW5kZXggODE4NzQ3Zi4uNDRhYTAz OSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5j Cj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+Pj4gQEAg LTI3OCw2ICsyNzgsOCBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV9hbGxvY19sZXZlbHMoc3RydWN0 IAo+Pj4gYW1kZ3B1X2RldmljZSAqYWRldiwKPj4+ICAgICAgICBmcm9tID0gKHNhZGRyID4+IHNo aWZ0KSAlIGFtZGdwdV92bV9udW1fZW50cmllcyhhZGV2LCBsZXZlbCk7Cj4+PiAgICAgICAgdG8g PSAoZWFkZHIgPj4gc2hpZnQpICUgYW1kZ3B1X3ZtX251bV9lbnRyaWVzKGFkZXYsIGxldmVsKTsK Pj4+Cj4+PiArICAgICBXQVJOX09OKGZyb20gPiB0byk7Cj4+PiArCj4+PiAgICAgICAgaWYgKHRv ID4gcGFyZW50LT5sYXN0X2VudHJ5X3VzZWQpCj4+PiAgICAgICAgICAgICAgICBwYXJlbnQtPmxh c3RfZW50cnlfdXNlZCA9IHRvOwo+Pj4KPj4+IEBAIC0zMTIsOCArMzE0LDExIEBAIHN0YXRpYyBp bnQgYW1kZ3B1X3ZtX2FsbG9jX2xldmVscyhzdHJ1Y3QgCj4+PiBhbWRncHVfZGV2aWNlICphZGV2 LAo+Pj4gICAgICAgICAgICAgICAgfQo+Pj4KPj4+ICAgICAgICAgICAgICAgIGlmIChsZXZlbCA8 IGFkZXYtPnZtX21hbmFnZXIubnVtX2xldmVsKSB7Cj4+PiAtICAgICAgICAgICAgICAgICAgICAg ciA9IGFtZGdwdV92bV9hbGxvY19sZXZlbHMoYWRldiwgdm0sIGVudHJ5LCAKPj4+IHNhZGRyLAo+ Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVhZGRy LCBsZXZlbCk7Cj4+PiArICAgICAgICAgICAgICAgICAgICAgdWludDY0X3Qgc3ViX3NhZGRyID0g KHB0X2lkeCA9PSBmcm9tKSA/IHNhZGRyIAo+Pj4gOiAwOwo+Pj4gKyAgICAgICAgICAgICAgICAg ICAgIHVpbnQ2NF90IHN1Yl9lYWRkciA9IChwdF9pZHggPT0gdG8pID8gZWFkZHIgOgo+Pj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKCgxIDw8IHNoaWZ0KSAtIDEpOwo+Pj4gKyAgICAg ICAgICAgICAgICAgICAgIHIgPSBhbWRncHVfdm1fYWxsb2NfbGV2ZWxzKGFkZXYsIHZtLCBlbnRy eSwgCj4+PiBzdWJfc2FkZHIsCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc3ViX2VhZGRyLCBsZXZlbCk7Cj4+Cj4+IERvIHlvdSBtZWFuIHRvIGNy ZWF0ZSBhIGZ1bGwgc3ViLXB0IGlmIHB0X2lkeCAhPSBmcm9tIGFuZCAhPSB0bz8KPj4gSSBkaWRu J3QgY2F0Y2ggaXQgdXAgY2xlYXIuCj4+Cj4+IEluIG15IHBlcnNwZWN0aXZlLCB3ZSBtYXkgbmVl ZCB0byBjbGVhciB0aGUgc2FkZHIgYW5kIGVhZGRyIHVwcGVyIAo+PiBsZXZlbCBiaXQKPj4gYmVm b3JlIGdvaW5nIG9uIHRvIGFsbG9jYXRlIHRoZSBuZXh0IGxldmVsIFBULgo+PiBPdGhlcndpc2Us IHRoZSBudW1iZXIgb2YgbmV4dCBQVCBlbnRyeSB3aWxsIGJlIGluY29ycmVjdCwgbW9yZSB0aGFu IAo+PiBudW1fZW50cmllcwo+PiBhcyB0aGUgdXBwZXIgbGV2ZWwgUFQgbnVtYmVyIGNhbGN1bGF0 ZWQgaW4uCj4+Cj4+IGUuZy4KPj4gdGhlcmUgaXMgYSBhZGRyZXNzIGNvbnRhaW5zCj4+IFBEICsg UFQxICsgUFQyICsgUFQzCj4+Cj4+IGZvciB0aGUgZmlyc3Qgcm91bmQsIHdlIGNvdWxkIGdldCBj b3JyZWN0ICJmcm9tIiBhbmQgInRvIiBhZGRyZXNzIAo+PiB3aXRoIHJpZ2h0Cj4+ICJzaGlmdCIo MyBibG9ja3MpLCB0aGVuIHdhbGsgb3ZlciB0aGUgYWRkcmVzcyBzcGFjZSBpbiBQRCByYW5nZS4K Pj4KPj4gVGhlbiBmb3IgdGhlIDJuZCByb3VuZCwgd2UgY2Fubm90IGdldCB0aGUgZXhwZWN0ZWQg ImZyb20iIGFuZCAidG8iIAo+PiBhZGRyZXNzIHdpdGgKPj4gInNoaWZ0IigyIGJsb2NrcyksIGFz IGl0IHdhbGtzIG92ZXIgdGhlIGFkZHJlc3Mgc3BhY2UgaW4gUEQgKyBQVDEgcmFuZ2UuCj4+IFdo aWxlIHdlJ2QgbGlrZSBpdCdzIGluIHJhbmdlIFBUMSBpbmRlZWQuCj4+Cj4+IFRoZSBmYXVsdCB3 YXkgZ29lcyBvbiB3aXRoIGxhdGVyIHJvdW5kLgo+Pgo+PiBQZXJoYXBzLCB0aGF0J3MgdGhlIHJv b3QgY2F1c2UgYWJvdXQgdGhlIGlzc3VlIHlvdSBmYWNlLgo+Pgo+PiBKZXJyeS4KPj4KPj4+ICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKHIpCj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIHI7Cj4+PiAgICAgICAgICAgICAgICB9Cj4+PiBAQCAtOTU3LDkgKzk2Miwx MSBAQCBzdGF0aWMgc3RydWN0IGFtZGdwdV9ibyAKPj4+ICphbWRncHVfdm1fZ2V0X3B0KHN0cnVj dCBhbWRncHVfcHRlX3VwZGF0ZV9wYXJhbXMgKnAsCj4+PiAgICAgICAgICAgICAgICBlbnRyeSA9 ICZlbnRyeS0+ZW50cmllc1tpZHhdOwo+Pj4gICAgICAgIH0KPj4+Cj4+PiAtICAgICBpZiAobGV2 ZWwpCj4+PiArICAgICBpZiAoV0FSTl9PTihsZXZlbCkpCj4+PiAgICAgICAgICAgICAgICByZXR1 cm4gTlVMTDsKPj4+Cj4+PiArICAgICBXQVJOX09OKCFlbnRyeS0+Ym8pOwo+Pj4gKwo+Pj4gICAg ICAgIHJldHVybiBlbnRyeS0+Ym87Cj4+PiAgIH0KPj4+Cj4+Pgo+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiBh bWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vYW1kLWdmeAo=