Re: [Qemu-devel] [PATCH 00/10] hw/pci-host: Clean the GT64120 north bridge - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Aleksandar Rikalo" <arikalo@wavecomp.com>,
	qemu-devel@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 00/10] hw/pci-host: Clean the GT64120 north bridge
Date: Mon, 1 Jul 2019 19:45:58 +0200	[thread overview]
Message-ID: <8ad999d7-fec4-079f-dbed-454afe127899@amsat.org> (raw)
In-Reply-To: <CAL1e-=iLAKe+FunE2p9L3Ds8fPS2a8nf3hc=ga7CX6E2bjw0Uw@mail.gmail.com>

Hi Aleksandar,

On 7/1/19 7:16 PM, Aleksandar Markovic wrote:
> 
> On Jun 25, 2019 12:31 AM, "Philippe Mathieu-Daudé" <f4bug@amsat.org
> <mailto:f4bug@amsat.org>> wrote:
>>
>> Hi,
>>
>> This series clean the gt64120 device.
>> It is no more target-dependent, and tracing is improved.
>>
> 
> If nobody objects, I am going to select majority of the patches for mips
> queue scheduled tomorrow. Those that remain will be those that Philippe
> still didn't make his mind.

Which ones remain?

For "pci-host/gt64120: Clean the decoded address space", I'd like a
review from someone comfortable with MEMTXATTRS and address spaces.
I'll ping on the patch.

> Thanks thousand times, Philippe!
> 
> Aleksandar
> 
>> Regards,
>>
>> Phil.
>>
>> Based-on: 20190624220056.25861-1-f4bug@amsat.org
> <mailto:20190624220056.25861-1-f4bug@amsat.org>
>> https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg05304.html
>>
>> Philippe Mathieu-Daudé (10):
>>   hw/mips/gt64xxx_pci: Fix multiline comment syntax
>>   hw/mips/gt64xxx_pci: Fix 'tabs' coding style issues
>>   hw/mips/gt64xxx_pci: Fix 'braces' coding style issues
>>   hw/mips/gt64xxx_pci: Fix 'spaces' coding style issues
>>   hw/mips/gt64xxx_pci: Use qemu_log_mask() instead of debug printf()
>>   hw/mips/gt64xxx_pci: Convert debug printf()s to trace events
>>   hw/mips/gt64xxx_pci: Align the pci0-mem size
>>   hw/mips/gt64xxx_pci: Add a 'cpu_big_endian' qdev property
>>   hw/mips/gt64xxx_pci: Move it to hw/pci-host/
>>   hw/pci-host/gt64120: Clean the decoded address space
>>
>>  Makefile.objs                                 |   1 +
>>  include/hw/mips/mips.h                        |   2 +-
>>  hw/mips/mips_malta.c                          |   8 +-
>>  hw/{mips/gt64xxx_pci.c => pci-host/gt64120.c} | 542 ++++++++++--------
>>  MAINTAINERS                                   |   2 +-
>>  hw/mips/Makefile.objs                         |   2 +-
>>  hw/mips/trace-events                          |   0
>>  hw/pci-host/Makefile.objs                     |   2 +-
>>  hw/pci-host/trace-events                      |   5 +
>>  9 files changed, 307 insertions(+), 257 deletions(-)
>>  rename hw/{mips/gt64xxx_pci.c => pci-host/gt64120.c} (68%)
>>  create mode 100644 hw/mips/trace-events
>>
>> --
>> 2.19.1
>>
>>
> 