From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D46C12002 for ; Fri, 16 Jul 2021 07:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 436EC613C0 for ; Fri, 16 Jul 2021 07:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235506AbhGPHI3 (ORCPT ); Fri, 16 Jul 2021 03:08:29 -0400 Received: from foss.arm.com ([217.140.110.172]:35150 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235173AbhGPHIZ (ORCPT ); Fri, 16 Jul 2021 03:08:25 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 18AC731B; Fri, 16 Jul 2021 00:05:31 -0700 (PDT) Received: from [10.163.67.71] (unknown [10.163.67.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 350B63F7D8; Fri, 16 Jul 2021 00:05:27 -0700 (PDT) Subject: Re: [RFC 07/10] arm64/mm: Detect and enable FEAT_LPA2 To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, mark.rutland@arm.com, will@kernel.org, catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, steven.price@arm.com References: <1626229291-6569-1-git-send-email-anshuman.khandual@arm.com> <1626229291-6569-8-git-send-email-anshuman.khandual@arm.com> <18c42dd0-b6db-d118-dad0-cac0bf6ab2ce@arm.com> From: Anshuman Khandual Message-ID: <8adefac5-c677-1fca-20dd-bba8543f8d59@arm.com> Date: Fri, 16 Jul 2021 12:36:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <18c42dd0-b6db-d118-dad0-cac0bf6ab2ce@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/14/21 1:51 PM, Suzuki K Poulose wrote: > On 14/07/2021 03:21, Anshuman Khandual wrote: >> Detect FEAT_LPA2 implementation early enough during boot when requested via >> CONFIG_ARM64_PA_BITS_52_LPA2 and remember in a variable arm64_lpa2_enabled. >> This variable could then be used to turn on TCR_EL1.TCR_DS effecting the 52 >> bits PA range or fall back to default 48 bits PA range if FEAT_LPA2 feature >> was requested but found not to be implemented. >> >> Signed-off-by: Anshuman Khandual >> --- >>   arch/arm64/include/asm/memory.h |  1 + >>   arch/arm64/kernel/head.S        | 15 +++++++++++++++ >>   arch/arm64/mm/mmu.c             |  3 +++ >>   arch/arm64/mm/proc.S            |  9 +++++++++ >>   4 files changed, 28 insertions(+) >> >> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h >> index 824a365..d0ca002 100644 >> --- a/arch/arm64/include/asm/memory.h >> +++ b/arch/arm64/include/asm/memory.h >> @@ -178,6 +178,7 @@ >>   #include >>     extern u64            vabits_actual; >> +extern u64            arm64_lpa2_enabled; >>     extern s64            memstart_addr; >>   /* PHYS_OFFSET - the physical address of the start of memory. */ >> diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S >> index 6444147..9cf79ea 100644 >> --- a/arch/arm64/kernel/head.S >> +++ b/arch/arm64/kernel/head.S >> @@ -94,6 +94,21 @@ SYM_CODE_START(primary_entry) >>       adrp    x23, __PHYS_OFFSET >>       and    x23, x23, MIN_KIMG_ALIGN - 1    // KASLR offset, defaults to 0 >>       bl    set_cpu_boot_mode_flag >> + >> +#ifdef CONFIG_ARM64_PA_BITS_52_LPA2 >> +    mrs     x10, ID_AA64MMFR0_EL1 >> +    ubfx    x10, x10, #ID_AA64MMFR0_TGRAN_SHIFT, 4 >> +    cmp     x10, #ID_AA64MMFR0_TGRAN_LPA2 >> +    b.ne    1f > > For the sake of forward compatibility, this should be "b.lt" Right, I guess we could assume that the feature will be present from the current ID_AA64MMFR0_TGRAN_LPA2 values onward in the future. But should not this also be capped at ID_AA64MMFR0_TGRAN_SUPPORTED_MAX as the upper limit is different for 4K and 16K page sizes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C16ADC07E95 for ; Fri, 16 Jul 2021 07:07:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CF44613D8 for ; Fri, 16 Jul 2021 07:07:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CF44613D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=uB9DIpMUK7Lii1RzcYlh8QkoUhfPPvvRqUaJYdlAK94=; b=uE+ULWLq4nR2ayL81vDhz1HkQk NSac2pE0Ee1QGIN69xi3EvgppvTnHExIBeb8YlaSPyq2q8SRMRHR1Edba3u+VtIMC+2SwPGegvNwj BPTFnRPk7CvMNautIiridnO84yGsUYphXf1u3jGPq3w+C1D3yQFn80uvi4INwba6jtLSGKZeIOEDu LSmKfsZ0AjaRbV0vhbiUj/WJs96CxtGirKtv0mDCuFSKiAc+IrhPl16MoJjRNqxMcN/5QR4NlZ6fL K1LYkam1jQScbMkFybLMmGNkBuDpfRjNkIp4aSVfJTGEYl7VKTQiPk4a3/IlqKFWqLBvSZz9a7XAH 8j/vog4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4Hul-003SUO-Jt; Fri, 16 Jul 2021 07:05:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4Hui-003SSp-Gn for linux-arm-kernel@lists.infradead.org; Fri, 16 Jul 2021 07:05:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 18AC731B; Fri, 16 Jul 2021 00:05:31 -0700 (PDT) Received: from [10.163.67.71] (unknown [10.163.67.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 350B63F7D8; Fri, 16 Jul 2021 00:05:27 -0700 (PDT) Subject: Re: [RFC 07/10] arm64/mm: Detect and enable FEAT_LPA2 To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, mark.rutland@arm.com, will@kernel.org, catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, steven.price@arm.com References: <1626229291-6569-1-git-send-email-anshuman.khandual@arm.com> <1626229291-6569-8-git-send-email-anshuman.khandual@arm.com> <18c42dd0-b6db-d118-dad0-cac0bf6ab2ce@arm.com> From: Anshuman Khandual Message-ID: <8adefac5-c677-1fca-20dd-bba8543f8d59@arm.com> Date: Fri, 16 Jul 2021 12:36:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <18c42dd0-b6db-d118-dad0-cac0bf6ab2ce@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_000536_668378_3D82594E X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDcvMTQvMjEgMTo1MSBQTSwgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPiBPbiAxNC8wNy8y MDIxIDAzOjIxLCBBbnNodW1hbiBLaGFuZHVhbCB3cm90ZToKPj4gRGV0ZWN0IEZFQVRfTFBBMiBp bXBsZW1lbnRhdGlvbiBlYXJseSBlbm91Z2ggZHVyaW5nIGJvb3Qgd2hlbiByZXF1ZXN0ZWQgdmlh Cj4+IENPTkZJR19BUk02NF9QQV9CSVRTXzUyX0xQQTIgYW5kIHJlbWVtYmVyIGluIGEgdmFyaWFi bGUgYXJtNjRfbHBhMl9lbmFibGVkLgo+PiBUaGlzIHZhcmlhYmxlIGNvdWxkIHRoZW4gYmUgdXNl ZCB0byB0dXJuIG9uIFRDUl9FTDEuVENSX0RTIGVmZmVjdGluZyB0aGUgNTIKPj4gYml0cyBQQSBy YW5nZSBvciBmYWxsIGJhY2sgdG8gZGVmYXVsdCA0OCBiaXRzIFBBIHJhbmdlIGlmIEZFQVRfTFBB MiBmZWF0dXJlCj4+IHdhcyByZXF1ZXN0ZWQgYnV0IGZvdW5kIG5vdCB0byBiZSBpbXBsZW1lbnRl ZC4KPj4KPj4gU2lnbmVkLW9mZi1ieTogQW5zaHVtYW4gS2hhbmR1YWwgPGFuc2h1bWFuLmtoYW5k dWFsQGFybS5jb20+Cj4+IC0tLQo+PiDCoCBhcmNoL2FybTY0L2luY2x1ZGUvYXNtL21lbW9yeS5o IHzCoCAxICsKPj4gwqAgYXJjaC9hcm02NC9rZXJuZWwvaGVhZC5TwqDCoMKgwqDCoMKgwqAgfCAx NSArKysrKysrKysrKysrKysKPj4gwqAgYXJjaC9hcm02NC9tbS9tbXUuY8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCB8wqAgMyArKysKPj4gwqAgYXJjaC9hcm02NC9tbS9wcm9jLlPCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHzCoCA5ICsrKysrKysrKwo+PiDCoCA0IGZpbGVzIGNoYW5nZWQsIDI4IGlu c2VydGlvbnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vbWVt b3J5LmggYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL21lbW9yeS5oCj4+IGluZGV4IDgyNGEzNjUu LmQwY2EwMDIgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vbWVtb3J5LmgK Pj4gKysrIGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9tZW1vcnkuaAo+PiBAQCAtMTc4LDYgKzE3 OCw3IEBACj4+IMKgICNpbmNsdWRlIDxhc20vYnVnLmg+Cj4+IMKgIMKgIGV4dGVybiB1NjTCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIHZhYml0c19hY3R1YWw7Cj4+ICtleHRlcm4gdTY0wqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBhcm02NF9scGEyX2VuYWJsZWQ7Cj4+IMKgIMKgIGV4dGVybiBzNjTCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIG1lbXN0YXJ0X2FkZHI7Cj4+IMKgIC8qIFBIWVNfT0ZGU0VUIC0g dGhlIHBoeXNpY2FsIGFkZHJlc3Mgb2YgdGhlIHN0YXJ0IG9mIG1lbW9yeS4gKi8KPj4gZGlmZiAt LWdpdCBhL2FyY2gvYXJtNjQva2VybmVsL2hlYWQuUyBiL2FyY2gvYXJtNjQva2VybmVsL2hlYWQu Uwo+PiBpbmRleCA2NDQ0MTQ3Li45Y2Y3OWVhIDEwMDY0NAo+PiAtLS0gYS9hcmNoL2FybTY0L2tl cm5lbC9oZWFkLlMKPj4gKysrIGIvYXJjaC9hcm02NC9rZXJuZWwvaGVhZC5TCj4+IEBAIC05NCw2 ICs5NCwyMSBAQCBTWU1fQ09ERV9TVEFSVChwcmltYXJ5X2VudHJ5KQo+PiDCoMKgwqDCoMKgIGFk cnDCoMKgwqAgeDIzLCBfX1BIWVNfT0ZGU0VUCj4+IMKgwqDCoMKgwqAgYW5kwqDCoMKgIHgyMywg eDIzLCBNSU5fS0lNR19BTElHTiAtIDHCoMKgwqAgLy8gS0FTTFIgb2Zmc2V0LCBkZWZhdWx0cyB0 byAwCj4+IMKgwqDCoMKgwqAgYmzCoMKgwqAgc2V0X2NwdV9ib290X21vZGVfZmxhZwo+PiArCj4+ ICsjaWZkZWYgQ09ORklHX0FSTTY0X1BBX0JJVFNfNTJfTFBBMgo+PiArwqDCoMKgIG1yc8KgwqDC oMKgIHgxMCwgSURfQUE2NE1NRlIwX0VMMQo+PiArwqDCoMKgIHViZnjCoMKgwqAgeDEwLCB4MTAs ICNJRF9BQTY0TU1GUjBfVEdSQU5fU0hJRlQsIDQKPj4gK8KgwqDCoCBjbXDCoMKgwqDCoCB4MTAs ICNJRF9BQTY0TU1GUjBfVEdSQU5fTFBBMgo+PiArwqDCoMKgIGIubmXCoMKgwqAgMWYKPiAKPiBG b3IgdGhlIHNha2Ugb2YgZm9yd2FyZCBjb21wYXRpYmlsaXR5LCB0aGlzIHNob3VsZCBiZSAiYi5s dCIKUmlnaHQsIEkgZ3Vlc3Mgd2UgY291bGQgYXNzdW1lIHRoYXQgdGhlIGZlYXR1cmUgd2lsbCBi ZSBwcmVzZW50IGZyb20gdGhlCmN1cnJlbnQgSURfQUE2NE1NRlIwX1RHUkFOX0xQQTIgdmFsdWVz IG9ud2FyZCBpbiB0aGUgZnV0dXJlLiBCdXQgc2hvdWxkCm5vdCB0aGlzIGFsc28gYmUgY2FwcGVk IGF0IElEX0FBNjRNTUZSMF9UR1JBTl9TVVBQT1JURURfTUFYIGFzIHRoZSB1cHBlcgpsaW1pdCBp cyBkaWZmZXJlbnQgZm9yIDRLIGFuZCAxNksgcGFnZSBzaXplcy4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK