From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5CFDC43387 for ; Fri, 14 Dec 2018 16:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E236206C2 for ; Fri, 14 Dec 2018 16:27:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729792AbeLNQ1i (ORCPT ); Fri, 14 Dec 2018 11:27:38 -0500 Received: from smtprelay0039.hostedemail.com ([216.40.44.39]:39646 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728731AbeLNQ1i (ORCPT ); Fri, 14 Dec 2018 11:27:38 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 44C51837F27F; Fri, 14 Dec 2018 16:27:36 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: week04_7c675ea555646 X-Filterd-Recvd-Size: 2922 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Fri, 14 Dec 2018 16:27:34 +0000 (UTC) Message-ID: <8ae5c67a5c4516a783579e449313d1d59fe3a47d.camel@perches.com> Subject: Re: [PATCH] checkpatch: add Co-Developed-by to signature tags From: Joe Perches To: Himanshu Jha Cc: Jorge Ramirez-Ortiz , apw@canonical.com, Andrew Morton , Greg KH , linux-kernel@vger.kernel.org, niklas.cassel@linaro.org Date: Fri, 14 Dec 2018 08:27:33 -0800 In-Reply-To: <20181214161604.GA17456@himanshu-Vostro-3559> References: <1544792494-15485-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <839c1d04000164e27dff9742e3efc3bcff3025b6.camel@perches.com> <20181214161604.GA17456@himanshu-Vostro-3559> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-12-14 at 21:46 +0530, Himanshu Jha wrote: > On Fri, Dec 14, 2018 at 07:52:15AM -0800, Joe Perches wrote: > > On Fri, 2018-12-14 at 14:01 +0100, Jorge Ramirez-Ortiz wrote: > > > As per Documentation/process/submitting-patches, Co-developed-by is a > > > valid signature. > > > > > > This commit removes the warning. > > > > Your commit message doesn't match your subject. > > > > A couple variants have been documented and only > > one should actually be used. > > > > $ git grep -i co-developed-by Documentation/process/ > > Documentation/process/5.Posting.rst: - Co-developed-by: states that the patch was also created by another developer > > Documentation/process/submitting-patches.rst:12) When to use Acked-by:, Cc:, and Co-Developed-by: > > Documentation/process/submitting-patches.rst:A Co-Developed-by: states that the patch was also created by another developer > > > > $ git log --grep="co-developed-by:" -i | \ > > grep -ohiP "co-developed-by:" | sort | uniq -c | sort -rn > > 80 Co-developed-by: > > 40 Co-Developed-by: > > > > So which should it be? > > > > btw: I prefer neither as I think Signed-off-by: is sufficient. > > OK, but does multiple Signed-off-by: in the commits imply that > the patch was created by all those developers ? > > I don't think so, perhaps this was the reason to introduce > Co-developed-by: tag. Perhaps, but a sign-off is also a recognition that the patch was passed-through by individuals Effectively, there's no real difference. "Co-developed-by:" is just another word for "Authored-by:" where multiple "Authorship" is the thing being notated. Is it really important to specify things like 75% / 25% authorship crediting? I don't really care about attribution so the concept is not particularly valuable to me.