All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: eesposit@redhat.com, vsementsov@virtuozzo.com,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	stefanha@redhat.com, Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v2] async: the main AioContext is only "current" if under the BQL
Date: Mon, 14 Jun 2021 13:34:01 +0200	[thread overview]
Message-ID: <8af04436-505a-669a-5bdb-69e249afcf22@redhat.com> (raw)
In-Reply-To: <0cc60d50-c047-4978-7fd6-49559044d84b@redhat.com>

On 11/06/21 13:13, Paolo Bonzini wrote:
>> The commit message doesn't specify, but in the buggy case, are we
>> talking about calling aio_co_wake() for a coroutine in the main context
>> specifically, right? Could we have a unit test for this scenario?
> 
> Yes, that's the scenario.  I will try to write a unit test indeed.

Done ("tests: cover aio_co_enter from a worker thread without BQL 
taken").  aio_co_enter() is the function that "does the work" for 
aio_co_wake().  Eric, you may want to review and pick that up as well.

Paolo


  reply	other threads:[~2021-06-14 11:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 12:22 [PATCH v2] async: the main AioContext is only "current" if under the BQL Paolo Bonzini
2021-06-09 13:02 ` Kevin Wolf
2021-06-09 15:05   ` Vladimir Sementsov-Ogievskiy
2021-06-11 11:13   ` Paolo Bonzini
2021-06-14 11:34     ` Paolo Bonzini [this message]
2021-06-09 15:01 ` Vladimir Sementsov-Ogievskiy
2021-06-11 11:14   ` Paolo Bonzini
2021-06-11 15:58     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8af04436-505a-669a-5bdb-69e249afcf22@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eesposit@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.