From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53359C433B4 for ; Tue, 18 May 2021 11:52:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3973F61007 for ; Tue, 18 May 2021 11:52:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348898AbhERLxT (ORCPT ); Tue, 18 May 2021 07:53:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:44270 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241753AbhERLxO (ORCPT ); Tue, 18 May 2021 07:53:14 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CF22CB01E; Tue, 18 May 2021 11:51:55 +0000 (UTC) Subject: Re: [PATCH v10 28/33] mm/filemap: Add folio_wait_bit To: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Layton References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-29-willy@infradead.org> From: Vlastimil Babka Message-ID: <8afd6085-96d0-8219-2cbf-31a0c04d35fb@suse.cz> Date: Tue, 18 May 2021 13:51:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210511214735.1836149-29-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/21 11:47 PM, Matthew Wilcox (Oracle) wrote: > Rename wait_on_page_bit() to folio_wait_bit(). We must always wait on > the folio, otherwise we won't be woken up due to the tail page hashing > to a different bucket from the head page. > > This commit shrinks the kernel by 691 bytes, mostly due to moving > the page waitqueue lookup into folio_wait_bit_common(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton Acked-by: Vlastimil Babka Nit below. > --- > include/linux/pagemap.h | 10 +++--- > mm/filemap.c | 77 +++++++++++++++++++---------------------- > mm/page-writeback.c | 4 +-- > 3 files changed, 43 insertions(+), 48 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 06b69cd03da3..e524e1b7190a 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -714,11 +714,11 @@ static inline int lock_page_or_retry(struct page *page, struct mm_struct *mm, > } > > /* > - * This is exported only for wait_on_page_locked/wait_on_page_writeback, etc., > + * This is exported only for folio_wait_locked/folio_wait_writeback, etc., > * and should not be used directly. > */ > -extern void wait_on_page_bit(struct page *page, int bit_nr); > -extern int wait_on_page_bit_killable(struct page *page, int bit_nr); > +extern void folio_wait_bit(struct folio *folio, int bit_nr); > +extern int folio_wait_bit_killable(struct folio *folio, int bit_nr); Nit: you remove these 'externs' in other patches, not here?