From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754293AbeD3OTD (ORCPT ); Mon, 30 Apr 2018 10:19:03 -0400 Received: from foss.arm.com ([217.140.101.70]:37158 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752868AbeD3OTC (ORCPT ); Mon, 30 Apr 2018 10:19:02 -0400 Subject: Re: [kvmtool PATCH 21/17] kvmtool: arm: Add support for creating VM with PA size To: Julien Grall , linux-arm-kernel@lists.infradead.org Cc: ard.biesheuvel@linaro.org, kvm@vger.kernel.org, marc.zyngier@arm.com, catalin.marinas@arm.com, punit.agrawal@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, kristina.martsenko@arm.com, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu References: <1522156531-28348-1-git-send-email-suzuki.poulose@arm.com> <1522156531-28348-22-git-send-email-suzuki.poulose@arm.com> <21da5232-5be6-7d48-a5a6-2d89f3c0f682@arm.com> From: Suzuki K Poulose Message-ID: <8b109c65-59b5-f49e-abe4-73f305d81b87@arm.com> Date: Mon, 30 Apr 2018 15:18:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <21da5232-5be6-7d48-a5a6-2d89f3c0f682@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/04/18 15:17, Julien Grall wrote: > Hi, > > On 27/03/18 14:15, Suzuki K Poulose wrote: >> diff --git a/arm/kvm.c b/arm/kvm.c >> index 5701d41..a9a9140 100644 >> --- a/arm/kvm.c >> +++ b/arm/kvm.c >> @@ -11,6 +11,8 @@ >>   #include >>   #include >> +unsigned long kvm_arm_type; >> + >>   struct kvm_ext kvm_req_ext[] = { >>       { DEFINE_KVM_EXT(KVM_CAP_IRQCHIP) }, >>       { DEFINE_KVM_EXT(KVM_CAP_ONE_REG) }, >> @@ -18,6 +20,25 @@ struct kvm_ext kvm_req_ext[] = { >>       { 0, 0 }, >>   }; >> +#ifndef KVM_ARM_GET_MAX_VM_PHYS_SHIFT >> +#define KVM_ARM_GET_MAX_VM_PHYS_SHIFT        _IO(KVMIO, 0x0a) >> +#endif >> + >> +void kvm__arch_init_hyp(struct kvm *kvm) >> +{ >> +    unsigned max_ipa; >> + >> +    max_ipa = ioctl(kvm->sys_fd, KVM_ARM_GET_MAX_VM_PHYS_SHIFT); >> +    if (max_ipa < 0) > > Another issues spotted while doing some testing. This will always be false because max_ipa is unsigned. > > I think we want to turn max_ipa to signed. Good catch. I will fix it. Cheers Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suzuki.Poulose@arm.com (Suzuki K Poulose) Date: Mon, 30 Apr 2018 15:18:57 +0100 Subject: [kvmtool PATCH 21/17] kvmtool: arm: Add support for creating VM with PA size In-Reply-To: <21da5232-5be6-7d48-a5a6-2d89f3c0f682@arm.com> References: <1522156531-28348-1-git-send-email-suzuki.poulose@arm.com> <1522156531-28348-22-git-send-email-suzuki.poulose@arm.com> <21da5232-5be6-7d48-a5a6-2d89f3c0f682@arm.com> Message-ID: <8b109c65-59b5-f49e-abe4-73f305d81b87@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30/04/18 15:17, Julien Grall wrote: > Hi, > > On 27/03/18 14:15, Suzuki K Poulose wrote: >> diff --git a/arm/kvm.c b/arm/kvm.c >> index 5701d41..a9a9140 100644 >> --- a/arm/kvm.c >> +++ b/arm/kvm.c >> @@ -11,6 +11,8 @@ >> ? #include >> ? #include >> +unsigned long kvm_arm_type; >> + >> ? struct kvm_ext kvm_req_ext[] = { >> ????? { DEFINE_KVM_EXT(KVM_CAP_IRQCHIP) }, >> ????? { DEFINE_KVM_EXT(KVM_CAP_ONE_REG) }, >> @@ -18,6 +20,25 @@ struct kvm_ext kvm_req_ext[] = { >> ????? { 0, 0 }, >> ? }; >> +#ifndef KVM_ARM_GET_MAX_VM_PHYS_SHIFT >> +#define KVM_ARM_GET_MAX_VM_PHYS_SHIFT??????? _IO(KVMIO, 0x0a) >> +#endif >> + >> +void kvm__arch_init_hyp(struct kvm *kvm) >> +{ >> +??? unsigned max_ipa; >> + >> +??? max_ipa = ioctl(kvm->sys_fd, KVM_ARM_GET_MAX_VM_PHYS_SHIFT); >> +??? if (max_ipa < 0) > > Another issues spotted while doing some testing. This will always be false because max_ipa is unsigned. > > I think we want to turn max_ipa to signed. Good catch. I will fix it. Cheers Suzuki