From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=gmills@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47z8200JzjzDqcF for ; Fri, 17 Jan 2020 02:56:23 +1100 (AEDT) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00GFrepL070643 for ; Thu, 16 Jan 2020 10:56:20 -0500 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xhbpu5c5d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 16 Jan 2020 10:56:19 -0500 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 00GFsCGU021225 for ; Thu, 16 Jan 2020 15:56:18 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma05wdc.us.ibm.com with ESMTP id 2xhjdv9k1w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 16 Jan 2020 15:56:18 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 00GFuIUf48628160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Jan 2020 15:56:18 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4ACDBB2064; Thu, 16 Jan 2020 15:56:18 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E9D36B2067; Thu, 16 Jan 2020 15:56:17 +0000 (GMT) Received: from [9.53.178.224] (unknown [9.53.178.224]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 16 Jan 2020 15:56:17 +0000 (GMT) Subject: Re: Redfish Dump Service Proposal To: Ratan Gupta , openbmc@lists.ozlabs.org References: <62dc3198-40d4-b0f6-4c31-cf829d9311d6@linux.intel.com> <62d0d9ee-ab0c-7ec9-403d-dc9487872142@linux.vnet.ibm.com> <1fb0c51e-32a2-1168-1d1d-ac044a5f892c@linux.vnet.ibm.com> From: Gunnar Mills Message-ID: <8b26e6a2-e4cf-b4b9-845b-4172a076e50f@linux.vnet.ibm.com> Date: Thu, 16 Jan 2020 09:56:18 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1fb0c51e-32a2-1168-1d1d-ac044a5f892c@linux.vnet.ibm.com> Content-Type: multipart/alternative; boundary="------------ED3974E86C3256C6471E4A3A" Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-16_05:2020-01-16, 2020-01-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001160131 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2020 15:56:24 -0000 This is a multi-part message in MIME format. --------------ED3974E86C3256C6471E4A3A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 1/16/2020 5:01 AM, Ratan Gupta wrote: > > Hi All, > > > Further to the previous dump proposal, I have incorporated the > following changes. > > * Having seprate LogService redfish resource for each type of dump. > > * Enhance the > LogService(_https://redfish.dmtf.org/schemas/LogService.v1_1_3.json_) > property > >        "LogEntryType": { > >             "enum": [ >                       "Event", >                       "SEL", >                       "Oem" > “*Dump*” >                 ] } > > * Enhance the LogService under OEM for further subsystem type > >       eg: hostboot dump, hypervisor dump > >         “OEM”: { > >               “*SystemType*”: { “enum” : [“HostBoot, Hypervisor, etc”] } > >                 } > > * Enhance the Log Service for the following > *Properties*: > > 1. *DumpOverridePolicy : **This can be different for all > different type of dumps.* > LogService has a OverWritePolicy property, can we use that? > 1. **MaxDumps: This can be different for all different type of > dumps.** > LogService has a MaxNumberOfRecords can we use that and drop this? > 1. > > *Actions:* > > 1. *CreateLog:**If logservice (**LogEntryType **is Dump) and the > subsystem type is “Hypervisor” then create log will create a > Host hypervisor dump.* > 2. ***DeleteAll: Delete all the logs from this log service, This > is a addition on the deletion of the single resource(LogEntry).* > LogService has a "ClearLog". Can we use that? > 1. > > > > * Enhance the logentry*(*_*https://redfi* > __*sh.dmtf.org/schemas/LogEntry.v1_5_0.json* > _*)* > >        "LogEntryType": { >             "enum": [ >                       "Event", >                       "SEL", >                       "Oem" > “*Dump*” >                 ] } > > * Map the proposed dump properties with existing log entry property > o Proposed Property           Existing LogEntry Property > + ID                          ID > + Timestamp                   Created > + Reason                      LogEntryCode(Introduce more > enums in the LogEntry Code for the > dump                         reason) > > * New Properties to be introduced in the logEntry > o *Size* > Redfish size properties typically have the unit in the name. > o *NOTE: *Dump type is not needed as the logservice logentry > type will tell that this service is for dump and the system > type will tell that this service is for which subsytem. > > *NOTE: * > > *1/ OdataID of log entry redfish resourc**e**will point to the raw > dump file which can be used to offload the dump.* > > *2/ CreateLog: **spawns a task and returns the taskID.Client can query > the status for the task.* > > > Please let me know if I have missed something else.I would be making > the change in the PPT also. > > Regards > > Ratan Gupta > > On 10/01/20 1:37 AM, Gunnar Mills wrote: >> >> A couple comments. >> >> On 1/7/2020 2:08 PM, Bills, Jason M wrote: >>> >>> On 1/7/2020 2:11 AM, Ratan Gupta wrote: >>> >>>>> >>>>>> >>>>>> On Sat, Dec 14, 2019 at 10:57 AM dhruvaraj S >>>>>> wrote: >>>>>>> >>>>>>> On Sat, Dec 14, 2019 at 1:32 AM Bills, Jason M >>>>>>> wrote: >>>>>>>> >>>>>>>> I like this as well.  I'm trying to support a CPU crashdump >>>>>>>> that would >>>>>>>> fit perfectly with this proposal. >>>>>>>> >>>>>>>> A question and some comments below: >>>>>>>> >>>>>>>> Will Dump only have the two types: BMC and Host? Could this be >>>>>>>> more >>>>>>>> flexible to allow for multiple different types of dumps from >>>>>>>> various >>>>>>>> components? >>>>>>> + I think dump types should be flexible to cover different types of >>>>>>> host or bmc dumps from different components with varying formats. >>>> Sure we can enhance the type of dump, it is enum in the proposal >>>> which can be enhanced. >>>> What could be other dump type which I can add in the types? >> >> Slide 15:  Since DumpType is an enum, should reason be as well? >> "Type" is a pretty typical enum in Redfish. E.g. BaseModuleType from >> https://redfish.dmtf.org/schemas/Memory.v1_8_0.json >> >> Reason seems similar to the LogEntryCode from >> https://redfish.dmtf.org/schemas/LogEntry.v1_5_0.json >> >> Slide 15: >> "Size": 108944B >> Redfish size properties typically have the unit in the name. E.g. >> From https://redfish.dmtf.org/schemas/Memory.v1_8_0.json CacheSizeMiB >> or CapacityMiB. >> >> odata.context is getting dropped. See >> https://github.com/DMTF/Redfish/issues/2722 or >> https://github.com/DMTF/Redfish/commit/ae49f4fb1278fd435f89317c3fa53cac597e3893#diff-e82b4876efbeaa600d3b104a426f7ac5 >> >> --------------ED3974E86C3256C6471E4A3A Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 1/16/2020 5:01 AM, Ratan Gupta wrote:

Hi All,


Further to the previous dump proposal, I have incorporated the following changes. 
  • Having seprate LogService redfish resource for each type of dump.
       "LogEntryType": {
            "enum": [
                      "Event", 
                      "SEL",
                      "Oem"
                      “Dump”
                ] }
  • Enhance the LogService under OEM for further subsystem type
      eg: hostboot dump, hypervisor dump
        “OEM”: {
              “SystemType”: { “enum” : [“HostBoot, Hypervisor, etc”] }
                }
  • Enhance the Log Service for the following
     Properties:
  1. DumpOverridePolicy : This can be different for all different type of dumps.


LogService has a OverWritePolicy property, can we use that?


  1. MaxDumps: This can be different for all different type of dumps.   

LogService has a MaxNumberOfRecords can we use that and drop this?


     Actions:

  1. CreateLog: If logservice (LogEntryType is Dump) and the subsystem type is “Hypervisor” then create log will create a Host hypervisor dump.
  2.  DeleteAll: Delete all the logs from this log service, This is a addition on the deletion of the single resource(LogEntry).

LogService has a "ClearLog". Can we use that?



       "LogEntryType": {
            "enum": [
                      "Event", 
                      "SEL",
                      "Oem"
                      “Dump”
                ] }
  • Map the proposed dump properties with existing log entry property
    • Proposed Property           Existing LogEntry Property
      • ID                          ID
      • Timestamp                   Created
      • Reason                      LogEntryCode (Introduce more enums in the LogEntry Code for the dump                         reason)
  • New Properties to be introduced in the logEntry
    • Size


Redfish size properties typically have the unit in the name.


    • NOTE: Dump type is not needed as the logservice logentry type will tell that this service is for dump and the system type will tell that this service is for which subsytem.
NOTE:

1/ OdataID of log entry redfish resource will point to the raw dump file which can be used to offload the dump.
2/ CreateLog: spawns a task and returns the taskID.Client can query the status for the task.

Please let me know if I have missed something else.I would be making the change in the PPT also.

Regards

Ratan Gupta

On 10/01/20 1:37 AM, Gunnar Mills wrote:

A couple comments.

On 1/7/2020 2:08 PM, Bills, Jason M wrote:

On 1/7/2020 2:11 AM, Ratan Gupta wrote:



On Sat, Dec 14, 2019 at 10:57 AM dhruvaraj S <dhruvaraj@gmail.com> wrote:

On Sat, Dec 14, 2019 at 1:32 AM Bills, Jason M
<jason.m.bills@linux.intel.com> wrote:

I like this as well.  I'm trying to support a CPU crashdump that would
fit perfectly with this proposal.

A question and some comments below:

Will Dump only have the two types: BMC and Host?  Could this be more
flexible to allow for multiple different types of dumps from various
components?
+ I think dump types should be flexible to cover different types of
host or bmc dumps from different components with varying formats.
Sure we can enhance the type of dump, it is enum in the proposal which can be enhanced.
What could be other dump type which I can add in the types?

Slide 15:  Since DumpType is an enum, should reason be as well? "Type" is a pretty typical enum in Redfish. E.g. BaseModuleType from https://redfish.dmtf.org/schemas/Memory.v1_8_0.json

Reason seems similar to the LogEntryCode from https://redfish.dmtf.org/schemas/LogEntry.v1_5_0.json

Slide 15:
"Size": 108944B
Redfish size properties typically have the unit in the name. E.g. From https://redfish.dmtf.org/schemas/Memory.v1_8_0.json CacheSizeMiB or CapacityMiB.

odata.context is getting dropped. See https://github.com/DMTF/Redfish/issues/2722 or https://github.com/DMTF/Redfish/commit/ae49f4fb1278fd435f89317c3fa53cac597e3893#diff-e82b4876efbeaa600d3b104a426f7ac5

--------------ED3974E86C3256C6471E4A3A--