From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033231AbeBOOaf (ORCPT ); Thu, 15 Feb 2018 09:30:35 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:49302 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032974AbeBOOae (ORCPT ); Thu, 15 Feb 2018 09:30:34 -0500 Subject: Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU To: Laurent Pinchart , Simon Horman , Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kieran Bingham , geert@glider.be, Kieran Bingham , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , open list References: <1518683903-10681-1-git-send-email-kbingham@kernel.org> <1518683903-10681-7-git-send-email-kbingham@kernel.org> <6281511.bskcdgqsgb@avalon> From: Kieran Bingham Organization: Ideas on Board Message-ID: <8b2c853c-2963-a116-a246-5fdb30b0688e@ideasonboard.com> Date: Thu, 15 Feb 2018 14:30:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <6281511.bskcdgqsgb@avalon> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, Simon, On 15/02/18 14:12, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> Enable the DU, providing only the VGA output for now. >> >> Signed-off-by: Kieran Bingham > > Reviewed-by: Laurent Pinchart > > I assume Simon will take care of this patch. That will be great, - One small caveat on this patch though: >> --- >> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 +++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index >> af07da240be0..668e246dfc5d 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> @@ -27,6 +27,38 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> + vga { >> + compatible = "vga-connector"; >> + >> + port { >> + vga_in: endpoint { >> + remote-endpoint = <&adv7123_out>; >> + }; >> + }; >> + }; >> + >> + vga-encoder { >> + compatible = "adi,adv7123"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + adv7123_in: endpoint { >> + remote-endpoint = <&du_out_rgb>; >> + }; >> + }; >> + port@1 { >> + reg = <1>; >> + adv7123_out: endpoint { >> + remote-endpoint = <&vga_in>; >> + }; >> + }; >> + }; >> + }; >> + >> memory@48000000 { >> device_type = "memory"; >> /* first 128MB is reserved for secure area. */ >> @@ -46,6 +78,11 @@ >> }; >> }; >> >> + du_pins: du { >> + groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0"; The du_dotclkout0 is named differently in Uli's patch. (Of course I believe my version is correct, but there is some precedent set it would seem). Anyway, If Uli's version of the PFC is accepted (Which I'm sure it will be), then I will have to re-spin this patch with the 'different' "du_clk_out_0" value in the groups. -- Kieran >> + function = "du"; >> + }; >> + >> i2c0_pins: i2c0 { >> groups = "i2c0"; >> function = "i2c0"; >> @@ -95,6 +132,20 @@ >> status = "okay"; >> }; >> >> +&du { >> + pinctrl-0 = <&du_pins>; >> + pinctrl-names = "default"; >> + status = "okay"; >> + >> + ports { >> + port@0 { >> + endpoint { >> + remote-endpoint = <&adv7123_in>; >> + }; >> + }; >> + }; >> +}; >> + >> &ehci0 { >> status = "okay"; >> }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kieran Bingham Subject: Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU Date: Thu, 15 Feb 2018 14:30:28 +0000 Message-ID: <8b2c853c-2963-a116-a246-5fdb30b0688e@ideasonboard.com> References: <1518683903-10681-1-git-send-email-kbingham@kernel.org> <1518683903-10681-7-git-send-email-kbingham@kernel.org> <6281511.bskcdgqsgb@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6281511.bskcdgqsgb@avalon> Content-Language: en-GB Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laurent Pinchart , Simon Horman , Ulrich Hecht Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kieran Bingham , geert-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org, Kieran Bingham , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , open list List-Id: devicetree@vger.kernel.org Hi Laurent, Simon, On 15/02/18 14:12, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> Enable the DU, providing only the VGA output for now. >> >> Signed-off-by: Kieran Bingham > > Reviewed-by: Laurent Pinchart > > I assume Simon will take care of this patch. That will be great, - One small caveat on this patch though: >> --- >> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 +++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index >> af07da240be0..668e246dfc5d 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> @@ -27,6 +27,38 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> + vga { >> + compatible = "vga-connector"; >> + >> + port { >> + vga_in: endpoint { >> + remote-endpoint = <&adv7123_out>; >> + }; >> + }; >> + }; >> + >> + vga-encoder { >> + compatible = "adi,adv7123"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + adv7123_in: endpoint { >> + remote-endpoint = <&du_out_rgb>; >> + }; >> + }; >> + port@1 { >> + reg = <1>; >> + adv7123_out: endpoint { >> + remote-endpoint = <&vga_in>; >> + }; >> + }; >> + }; >> + }; >> + >> memory@48000000 { >> device_type = "memory"; >> /* first 128MB is reserved for secure area. */ >> @@ -46,6 +78,11 @@ >> }; >> }; >> >> + du_pins: du { >> + groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0"; The du_dotclkout0 is named differently in Uli's patch. (Of course I believe my version is correct, but there is some precedent set it would seem). Anyway, If Uli's version of the PFC is accepted (Which I'm sure it will be), then I will have to re-spin this patch with the 'different' "du_clk_out_0" value in the groups. -- Kieran >> + function = "du"; >> + }; >> + >> i2c0_pins: i2c0 { >> groups = "i2c0"; >> function = "i2c0"; >> @@ -95,6 +132,20 @@ >> status = "okay"; >> }; >> >> +&du { >> + pinctrl-0 = <&du_pins>; >> + pinctrl-names = "default"; >> + status = "okay"; >> + >> + ports { >> + port@0 { >> + endpoint { >> + remote-endpoint = <&adv7123_in>; >> + }; >> + }; >> + }; >> +}; >> + >> &ehci0 { >> status = "okay"; >> }; > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: kieran.bingham@ideasonboard.com (Kieran Bingham) Date: Thu, 15 Feb 2018 14:30:28 +0000 Subject: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU In-Reply-To: <6281511.bskcdgqsgb@avalon> References: <1518683903-10681-1-git-send-email-kbingham@kernel.org> <1518683903-10681-7-git-send-email-kbingham@kernel.org> <6281511.bskcdgqsgb@avalon> Message-ID: <8b2c853c-2963-a116-a246-5fdb30b0688e@ideasonboard.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Laurent, Simon, On 15/02/18 14:12, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> Enable the DU, providing only the VGA output for now. >> >> Signed-off-by: Kieran Bingham > > Reviewed-by: Laurent Pinchart > > I assume Simon will take care of this patch. That will be great, - One small caveat on this patch though: >> --- >> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 51 +++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index >> af07da240be0..668e246dfc5d 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> @@ -27,6 +27,38 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> + vga { >> + compatible = "vga-connector"; >> + >> + port { >> + vga_in: endpoint { >> + remote-endpoint = <&adv7123_out>; >> + }; >> + }; >> + }; >> + >> + vga-encoder { >> + compatible = "adi,adv7123"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port at 0 { >> + reg = <0>; >> + adv7123_in: endpoint { >> + remote-endpoint = <&du_out_rgb>; >> + }; >> + }; >> + port at 1 { >> + reg = <1>; >> + adv7123_out: endpoint { >> + remote-endpoint = <&vga_in>; >> + }; >> + }; >> + }; >> + }; >> + >> memory at 48000000 { >> device_type = "memory"; >> /* first 128MB is reserved for secure area. */ >> @@ -46,6 +78,11 @@ >> }; >> }; >> >> + du_pins: du { >> + groups = "du_rgb888", "du_sync", "du_disp", "du_dotclkout0"; The du_dotclkout0 is named differently in Uli's patch. (Of course I believe my version is correct, but there is some precedent set it would seem). Anyway, If Uli's version of the PFC is accepted (Which I'm sure it will be), then I will have to re-spin this patch with the 'different' "du_clk_out_0" value in the groups. -- Kieran >> + function = "du"; >> + }; >> + >> i2c0_pins: i2c0 { >> groups = "i2c0"; >> function = "i2c0"; >> @@ -95,6 +132,20 @@ >> status = "okay"; >> }; >> >> +&du { >> + pinctrl-0 = <&du_pins>; >> + pinctrl-names = "default"; >> + status = "okay"; >> + >> + ports { >> + port at 0 { >> + endpoint { >> + remote-endpoint = <&adv7123_in>; >> + }; >> + }; >> + }; >> +}; >> + >> &ehci0 { >> status = "okay"; >> }; > >