All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: David Ahern <dsahern@gmail.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, oliver@hartkopp.net,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net v2] net: enable interface alias removal via rtnl
Date: Wed, 11 Oct 2017 14:29:16 +0200	[thread overview]
Message-ID: <8b334f53-235b-42d2-ba68-4e63c54c498c@6wind.com> (raw)
In-Reply-To: <c81359e7-feb8-475e-69d7-3eacc3406caf@gmail.com>

Le 10/10/2017 à 16:50, David Ahern a écrit :
> On 10/10/17 6:41 AM, Nicolas Dichtel wrote:
>> IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of
>> the attribute is 1 ("\0"). However, to remove an alias, the attribute
>> length must be 0 (see dev_set_alias()).
>>
>> Let's define the type to NLA_BINARY, so that the alias can be removed.
> 
> not to be pedantic, but we need to be clear that the type is changed
> only for policy validation.
With the comment in the code, it is clear, isn't it?


Regards,
Nicolas

  reply	other threads:[~2017-10-11 12:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 10:19 [PATCH net] net: enable interface alias removal via rtnl Nicolas Dichtel
2017-10-06 18:18 ` David Ahern
2017-10-06 20:10   ` Oliver Hartkopp
2017-10-09  8:23     ` Nicolas Dichtel
2017-10-09 14:02       ` David Ahern
2017-10-09 15:25         ` Nicolas Dichtel
2017-10-09 21:17           ` David Ahern
2017-10-10 12:41             ` [PATCH net v2] " Nicolas Dichtel
2017-10-10 14:50               ` David Ahern
2017-10-11 12:29                 ` Nicolas Dichtel [this message]
2017-10-11 14:13                   ` David Ahern
2017-10-11 14:24                     ` [PATCH net v3] " Nicolas Dichtel
2017-10-16 19:52                       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b334f53-235b-42d2-ba68-4e63c54c498c@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@hartkopp.net \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.