All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: 范开喜 <fankaixi.li@bytedance.com>
Cc: kafai@fb.com, songliubraving@fb.com, john.fastabend@gmail.com,
	kpsingh@kernel.org, bpf@vger.kernel.org, shuah@kernel.org,
	ast@kernel.org, andrii@kernel.org
Subject: Re: [External] [PATCH bpf-next v2 2/3] selftests/bpf: add ipv4 vxlan tunnel source testcase
Date: Mon, 28 Mar 2022 16:10:12 -0700	[thread overview]
Message-ID: <8b498619-a08e-0c4c-c1d3-93dc9cdbc1f2@fb.com> (raw)
In-Reply-To: <CAEEdnKEF=EfiXsQX7HgPbj2Fz2Un2km1nb=SgK8uNNYxsP05cw@mail.gmail.com>



On 3/26/22 10:04 AM, 范开喜 wrote:
> Yonghong Song <yhs@fb.com> 于2022年3月26日周六 00:41写道：
>>
>>
>>
>> On 3/22/22 8:42 AM, fankaixi.li@bytedance.com wrote:
>>> From: "kaixi.fan" <fankaixi.li@bytedance.com>
>>>
>>> Vxlan tunnel is chosen to test bpf code could configure tunnel
>>> source ipv4 address.
>>
>> The added test configures tunnel source ipv4 address.
>>
>>   >It's sufficient to prove that other types
>>> tunnels could also do it.
>>
>> Could you be more specific what other types will also use source ipv4
>> address. It is too vague to claim "it's sufficient to prove ...".
>>
> 
> Is it better to add more test cases for other types of ip tunnels ? It would
> introduce more duplicate codes.
> 
> In the kernel, this is referred to as collect metadata mode as follows:
> https://man7.org/linux/man-pages/man8/ip-link.8.html
> Kernel use "struct ip_tunnel_info" to save tunnel parameters, and use
> it for tunnel encapsulation. The process is similar for vxlan, gre,/gretap,
> geneve, ipip and erspan tunnels.
> The previous test cases in "test_tunnel.sh" test this mechanism for bpf
> program code already.  Based on this mechanism, I just use vxlan tunnel
> to test tunnel source ip configuration.

You can just mention something like:
   Other type of tunnels, e.g., gre, gretap, geneve, ipip, erspan, etc, 
can also configure tunnel source ip addresses.

> 
>>
>>> In the vxlan tunnel testcase, two underlay ipv4 addresses
>>> are configured on veth device in root namespace. Test bpf kernel
>>> code would configure the secondary ipv4 address as the tunnel
>>> source ip.
>>>
>>> Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com>
>>
>> Again, please use proper name in Signed-off-by tag.
> 
> Thanks. I will fix it.
> 
[...]

  reply	other threads:[~2022-03-28 23:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 15:42 [External] [PATCH bpf-next v2 0/3] bpf: Add support to set and get fankaixi.li
2022-03-22 15:42 ` [External] [PATCH bpf-next v2 1/3] bpf: Add source ip in "struct bpf_tunnel_key" fankaixi.li
2022-03-25 16:26   ` Yonghong Song
2022-03-22 15:42 ` [External] [PATCH bpf-next v2 2/3] selftests/bpf: add ipv4 vxlan tunnel source testcase fankaixi.li
2022-03-25 16:41   ` Yonghong Song
2022-03-26 17:04     ` 范开喜
2022-03-28 23:10       ` Yonghong Song [this message]
2022-03-29  2:02         ` 范开喜
2022-03-22 15:42 ` [External] [PATCH bpf-next v2 3/3] selftests/bpf: add ipv6 " fankaixi.li
2022-03-24 19:37   ` Martin KaFai Lau
2022-03-26 17:24     ` 范开喜
2022-04-06  8:03       ` 范开喜
2022-04-07 17:53         ` Martin KaFai Lau
2022-04-08 13:56           ` 范开喜
2022-04-15 23:11           ` Peilin Ye
2022-04-20 17:09             ` Andrii Nakryiko
2022-04-20 17:54               ` Peilin Ye
2022-04-21 11:27                 ` 范开喜
2022-03-25 16:45   ` Yonghong Song
2022-03-25 16:46 ` [External] [PATCH bpf-next v2 0/3] bpf: Add support to set and get Yonghong Song
2022-03-26 17:06   ` 范开喜

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b498619-a08e-0c4c-c1d3-93dc9cdbc1f2@fb.com \
    --to=yhs@fb.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=fankaixi.li@bytedance.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=shuah@kernel.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.