From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net v4] net/ipv6: Add anycast addresses to a global
 hashtable
Date: Sat, 27 Oct 2018 17:39:39 -0600
Message-ID: <8b4e657f-f64a-060b-e535-d9a487db64ed@gmail.com>
References: <95cb5670-eaf0-c7af-7e35-bc4f6e68c5ba@gmail.com>
 <20181027180232.23154-1-0xeffeff@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org
To: Jeff Barnhill <0xeffeff@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it1-f196.google.com ([209.85.166.196]:52307 "EHLO
        mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728630AbeJ1IWV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 28 Oct 2018 04:22:21 -0400
Received: by mail-it1-f196.google.com with SMTP id r5-v6so3627690ith.2
        for <netdev@vger.kernel.org>; Sat, 27 Oct 2018 16:39:42 -0700 (PDT)
In-Reply-To: <20181027180232.23154-1-0xeffeff@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10/27/18 12:02 PM, Jeff Barnhill wrote:
> @@ -275,6 +356,11 @@ int __ipv6_dev_ac_inc(struct inet6_dev *idev, const struct in6_addr *addr)
>  		err = -ENOMEM;
>  		goto out;
>  	}
> +	err = ipv6_add_acaddr_hash(dev_net(idev->dev), addr);
> +	if (err) {
> +		aca_put(aca);
> +		goto out;
> +	}
>  
>  	aca->aca_next = idev->ac_list;
>  	idev->ac_list = aca;

you misunderstood my comment. aca_put is instead of a double call to
fib6_info_release(f6i). You still need one call to
fib6_info_release(f6i) for the addrconf_f6i_alloc.