From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1c4sZm-0004rh-K7
	for qemu-devel@nongnu.org; Thu, 10 Nov 2016 11:51:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1c4sZh-000648-VU
	for qemu-devel@nongnu.org; Thu, 10 Nov 2016 11:51:46 -0500
Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35509)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <rth7680@gmail.com>) id 1c4sZh-00063f-Np
	for qemu-devel@nongnu.org; Thu, 10 Nov 2016 11:51:41 -0500
Received: by mail-wm0-x244.google.com with SMTP id a20so4296309wme.2
	for <qemu-devel@nongnu.org>; Thu, 10 Nov 2016 08:51:41 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <20161109145748.27282-1-alex.bennee@linaro.org>
	<20161109145748.27282-13-alex.bennee@linaro.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <8b4e7dcf-7b55-8652-e867-d84e8a68ef32@twiddle.net>
Date: Thu, 10 Nov 2016 17:51:36 +0100
MIME-Version: 1.0
In-Reply-To: <20161109145748.27282-13-alex.bennee@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v6 12/19] cputlb: tweak
 qemu_ram_addr_from_host_nofail reporting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, pbonzini@redhat.com
Cc: qemu-devel@nongnu.org, mttcg@greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com, mark.burton@greensocs.com, jan.kiszka@siemens.com, serge.fdrv@gmail.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 11/09/2016 03:57 PM, Alex Bennée wrote:
> This moves the helper function closer to where it is called and updates
> the error message to report via error_report instead of the deprecated
> fprintf.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  cputlb.c | 24 ++++++++++++------------
>  1 file changed, 12 in

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~