From: Sandipan Das <sandipan@linux.vnet.ibm.com>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: acme@kernel.org, jolsa@redhat.com, linux-kernel@vger.kernel.org,
naveen.n.rao@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com,
maynard@us.ibm.com
Subject: Re: [PATCH 1/2] perf tools powerpc: Fix callchain ip filtering
Date: Tue, 17 Apr 2018 20:30:32 +0530 [thread overview]
Message-ID: <8b57ea28-f620-2f9c-e494-3877606696a6@linux.vnet.ibm.com> (raw)
In-Reply-To: <3471e3e0-80ad-7a7f-96b8-60d24a4931a2@linux.ibm.com>
On 04/17/2018 12:29 PM, Ravi Bangoria wrote:
>
> This change looks good to me but seems it fixed the issue
> partially.Ex,
>
> # readelf --debug-dump=frames-interp /lib64/libc-2.26.so | less
> ...
> 00005778 0000000000000024 0000577c FDE cie=00000000 pc=0000000000048b30..0000000000048c64
> LOC CFA r31 ra
> 0000000000048b30 r1+0 u u
> 0000000000048b40 r1+0 c-8 r0
> 0000000000048b58 r1+64 c-8 c+16
> 0000000000048bd8 r1+0 c-8 c+16
> 0000000000048be4 r1+0 u
> 0000000000048bf0 r1+64 c-8 c+16
>
> 0000000000048b30..0000000000048c64 is arandom() function from libc:
>
> 0000000000048b30 <random>:
> 48b30: 1c 00 4c 3c addis r2,r12,28
> 48b34: d0 e5 42 38 addi r2,r2,-6704
> 48b38: a6 02 08 7c mflr r0
> 48b3c: f8 ff e1 fb std r31,-8(r1)
> 48b40: 00 00 00 60 nop
> 48b44: 00 00 20 39 li r9,0
> 48b48: 80 b5 e2 3b addi r31,r2,-19072
> 48b4c: 01 00 00 39 li r8,1
> 48b50: 10 00 01 f8 std r0,16(r1)
> 48b54: c1 ff 21 f8 stdu r1,-64(r1)
> 48b58: f0 8f 4d e9 ld r10,-28688(r13)
> ...
>
> Your change fixed the issue for 48b30..48b40. But not for
> 48b40..48b58.
>
> I probed at 0x48b40.
>
> # ./perf record -g -e probe_libc:abs_48b40 ~/rand
>
> perf report without Suka's and your change:
>
> # Children Self Trace output
> # ........ ........ ..............
> #
> 100.00% 100.00% (7fffb7d28b40)
> |
> ---0
> __libc_start_main
> generic_start_main.isra.0
> main
> rand
> __random
>
> perf report with only Suka's change:
>
> # Children Self Trace output
> # ........ ........ ..............
> #
> 100.00% 100.00% (7fffb7d28b40)
> |
> ---0
> __libc_start_main
> generic_start_main.isra.0
> main
> __random
>
> perf report with Suka's and your change:
>
> # Children Self Trace output
> # ........ ........ ..............
> #
> 100.00% 100.00% (7fffb7d28b40)
> |
> ---0
> __libc_start_main
> generic_start_main.isra.0
> main
> __random
>
> I think rand() is a valid entry which is missing in last two cases.
>
>
Ah, good catch and thanks for the review. Will address these problems in v2.
- Sandipan
next prev parent reply other threads:[~2018-04-17 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 17:11 [PATCH 0/2] perf: Fixes for callchain ip handling on powerpc Sandipan Das
2018-04-12 17:11 ` [PATCH 1/2] perf tools powerpc: Fix callchain ip filtering Sandipan Das
2018-04-12 18:43 ` Arnaldo Carvalho de Melo
2018-04-12 19:55 ` Sandipan Das
2018-04-17 6:59 ` Ravi Bangoria
2018-04-17 15:00 ` Sandipan Das [this message]
2018-04-12 17:11 ` [PATCH 2/2] perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64 Sandipan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b57ea28-f620-2f9c-e494-3877606696a6@linux.vnet.ibm.com \
--to=sandipan@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maynard@us.ibm.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.