From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1Gpn-0004Au-5q for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:57:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1Gpk-0000MO-2k for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:57:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51808) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1Gpj-0000MK-TZ for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:57:20 -0400 References: <1477924663-30950-1-git-send-email-pbonzini@redhat.com> <878tt4xwqu.fsf@linaro.org> From: Paolo Bonzini Message-ID: <8b5860d9-7af5-1829-f882-f905a326adc6@redhat.com> Date: Mon, 31 Oct 2016 18:57:14 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/27] Misc patches for 2016-10-31 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: QEMU Developers On 31/10/2016 18:20, Peter Maydell wrote: > On 31 October 2016 at 17:18, Alex Benn=C3=A9e = wrote: >> Peter Maydell writes: >>> Fails to build on OSX (format string issues) :-( >>> >>> /home/petmay01/qemu/exec.c: In function 'file_ram_alloc': >>> /home/petmay01/qemu/exec.c:1338:9: error: format '%llu' expects >>> argument of type 'long long unsigned int', but argument 8 has type >>> 'ram_addr_t' [-Werror=3Dformat=3D] >>> error_setg(errp, "backing store %s size %"PRId64 >>> ^ >> >> It should be using RAM_ADDR_FMT right? >=20 > Yes. (Watch out that RAM_ADDR_FMT includes the % for you, whereas > PRId64 does not). Ok, will do it tomorrow. Paolo