From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9AD6C2B9F7 for ; Mon, 24 May 2021 12:39:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD359613B6 for ; Mon, 24 May 2021 12:39:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232706AbhEXMkw (ORCPT ); Mon, 24 May 2021 08:40:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232700AbhEXMkv (ORCPT ); Mon, 24 May 2021 08:40:51 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4253FC061574; Mon, 24 May 2021 05:39:23 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id i9so40451808lfe.13; Mon, 24 May 2021 05:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=13zcyWdsm4gpffNG5ZgDMwvczQG34AV4139pdXe/s/0=; b=Ukzs1lpffefInt+Tc3rj13rbWCFBfbLYbuOBDb1j5YTp/JNEMJrM+0BS9pYYP38s9n 7HnDgswflfy/VLz9qqAzPEQ99K+h8Qw9BP4SNjW8CFWmWgh5JMUSDfFAJeK+RZdsaGGL E/Dufo5c9cUI5wYk5ZS925uvNbuEl/D0DVzT9JJnHjAK1LG65AMdNhVEY5bjp2L2ZkJx xTyf1oVqYbmYguDJ4dsI4rGt5dv+nSIZOdciE20NRNrrOmtUf9V4AfSlhip/ALqlXDCi a3xqCn7eZwwF4XtCyKGnbWeeDVyinyJ8tey0f34ksGlX16trBozo1SFW0R8FUHxTuMe2 gCpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=13zcyWdsm4gpffNG5ZgDMwvczQG34AV4139pdXe/s/0=; b=JPtwYE8hRhKABXJqAdQPEmS/j++lk9UmOM98vt2+exheyVdkYJyhD3XKbkieLeMkqL /UHrG5P34T7pgyKMjm7tYUro2k/bNz5UjhoS0FeZtZeMRMrF+PUZDhp2E6Nexp93rb1f DVVmp2GE0TIukOoJtXuZoF9czCz2kJ3gmg+tGP5aQRuWZb6Hg8CDqHeWhOmUvWH6SkVx VUVniWHnHdYwP0nz2h3s4ZhLVBgyW5KMY2K4TIG2Uf6Qck41AbhHhcSAyEpiIIVdieG9 2wkXGhDq7EseZM03ePl8uRyWjf6rPdDGtFegsHRW6OgBREFluVHCx3ZKSM7UvuOhJlug 9OfQ== X-Gm-Message-State: AOAM533KhURQfuH5gHNIe/ch3AcEg24inlOXm8PTgtQ+2smqFB8dpza0 JZsPVjBoZ88+S3e9qraZZZD7vr48hSM= X-Google-Smtp-Source: ABdhPJyhCOFQn/Z1pKRmtZeJWu1d4dSY2QLiSj+ONw56eIR3cGKanVoF3Tn/DOinhtQ09s5N7gDupw== X-Received: by 2002:a05:6512:128c:: with SMTP id u12mr10567429lfs.160.1621859961442; Mon, 24 May 2021 05:39:21 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-110.dynamic.spd-mgts.ru. [109.252.193.110]) by smtp.googlemail.com with ESMTPSA id p21sm1409745lfg.97.2021.05.24.05.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 05:39:21 -0700 (PDT) Subject: Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled To: Geert Uytterhoeven Cc: Thierry Reding , Jonathan Hunter , Krzysztof Kozlowski , Stephen Boyd , Tony Lindgren , Arnd Bergmann , Paul Burton , John Crispin , "open list:BROADCOM NVRAM DRIVER" , Linux ARM , linux-m68k , Linux Kernel Mailing List , linux-tegra , linux-clk , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" References: <20210523232556.15017-1-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <8b6af8c0-6f01-193f-1eb4-4e230871f0cd@gmail.com> Date: Mon, 24 May 2021 15:39:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 24.05.2021 11:54, Geert Uytterhoeven пишет: > Hi Dmitry, > > On Mon, May 24, 2021 at 1:26 AM Dmitry Osipenko wrote: >> There are couple older platforms that can't be compile-tested because they >> partially implement CLK API. It causes build failure of kernel drivers due >> to the missing symbols of the unimplemented part of CLK API. >> >> These platforms are: ARM EP93XX, ARM OMAP1, m68k ColdFire, MIPS AR7, >> MIPS Ralink. >> >> Disable compile-testing for HAVE_LEGACY_CLK=y. >> >> Reported-by: kernel test robot >> Signed-off-by: Dmitry Osipenko > > Thanks for your patch! > >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -131,7 +131,7 @@ config INIT_ENV_ARG_LIMIT >> >> config COMPILE_TEST >> bool "Compile also drivers which will not load" >> - depends on HAS_IOMEM >> + depends on HAS_IOMEM && !HAVE_LEGACY_CLK > > That sounds a bit drastic to me. Usually we just try to implement the > missing functionality, or provide stubs. > Which functions are missing? Everything that belongs to CONFIG_COMMON_CLK needs stubs. That is everything under CONFIG_HAVE_CLK [1], excluding functions belonging to clk-devres.o and clk-bulk.o [2]. The HAVE_LEGACY_CLK selects HAVE_CLK, but the COMMON_CLK is under HAVE_CLK too. [1] https://elixir.bootlin.com/linux/v5.13-rc3/source/include/linux/clk.h#L786 [2] https://elixir.bootlin.com/linux/v5.13-rc3/source/drivers/clk/Makefile#L3 This problem is repeated over and over again for the past years. Some maintainers are adding "depends on COMMON_CLK" for COMPILE_TEST of each driver, but this doesn't solve the root of the problem, and thus, it's constantly reoccurring. Recently Krzysztof Kozlowski added couple more clk stubs for MIPS, but still lots of stubs are missing. Some platforms don't have any stubs at all and apparently nobody cares to fix them. There 3 possible solutions: 1. Factor out COMMON_CLK from HAVE_LEGACY_CLK, if this is possible 2. Build stubs universally, maybe using weak functions. 3. Disable compile-testing for HAVE_LEGACY_CLK The third option is the simplest. If anyone will care to fix those legacy platforms properly, then compile-testing could be re-enabled for them. This is my proposal. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A9DC04FF3 for ; Mon, 24 May 2021 18:35:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72BD26140F for ; Mon, 24 May 2021 18:35:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72BD26140F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=qAEXbkjjs05cdHdCW898ldOChXGcQoIeUpS0bPQ0GUI=; b=bQTp/3yMo+Nsg9nMFJAkgWSOoo UYLxSB/vsCyYatHcXJFXTmuhg30yDbKAbnfF+k9tGxzPapiDTVWbnr8/qywBwTiBi4Q5LUoYIDD92 4FsszcoQxqV1dgivD17kiFlIEzyJGe2i7rx0vUi205QuAWjGT7rr1en+sNTojgQCJqh6dezlm/nZQ HP1SKdWK5BV6Dbuqi6oCLEYqde+MWf2WXDJTl3gDg1OyI3mxhgb/OlyrY1H5uz0YUvJqo8YpJk40J twRlA93AqdCldEg4rlh4rGrLa0NGb4pkTzAuGizIReqH/NZUoUAs2jQzrQJA/VObu7DWZzxnJ3RNL +DsJTkPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llFOa-001Tw6-GE; Mon, 24 May 2021 18:33:45 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ll9rf-000uy0-EQ for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 12:39:25 +0000 Received: by mail-lf1-x135.google.com with SMTP id m11so40503494lfg.3 for ; Mon, 24 May 2021 05:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=13zcyWdsm4gpffNG5ZgDMwvczQG34AV4139pdXe/s/0=; b=Ukzs1lpffefInt+Tc3rj13rbWCFBfbLYbuOBDb1j5YTp/JNEMJrM+0BS9pYYP38s9n 7HnDgswflfy/VLz9qqAzPEQ99K+h8Qw9BP4SNjW8CFWmWgh5JMUSDfFAJeK+RZdsaGGL E/Dufo5c9cUI5wYk5ZS925uvNbuEl/D0DVzT9JJnHjAK1LG65AMdNhVEY5bjp2L2ZkJx xTyf1oVqYbmYguDJ4dsI4rGt5dv+nSIZOdciE20NRNrrOmtUf9V4AfSlhip/ALqlXDCi a3xqCn7eZwwF4XtCyKGnbWeeDVyinyJ8tey0f34ksGlX16trBozo1SFW0R8FUHxTuMe2 gCpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=13zcyWdsm4gpffNG5ZgDMwvczQG34AV4139pdXe/s/0=; b=sqdpgiYL3Ts2FuGJZdPg4YmWkPLm8DX7AsEvWRikMyg1JuLpYY2dZi3UfJLLaubAc8 mN/wx/f9kgQgJOVsi/dv7+cO39Mfd1SYI3K2TxQNOcbENWG5qQyEGlEm0V/MfXaW5XYW YCj6AxZrijYnw/XoPrG27vMsIDDNhiFxl2jP2f4v6L0UUaAqOO4il2hjo6tuKA57zjlB iYXYBqzV9BYJe+YHaMUZcyBMiGcSX/Ky8yRC+vU2UjrTeRqLkacoTd7avknqB1lYp/3l CifIpfA9zf07l3OefhBz70MAWsuKB3By4Flo1BhU7r+AOxpluDegMR/zrw7J9jnSWMg9 oYag== X-Gm-Message-State: AOAM532YaJk/uOtJFIMCcUQMM9u0VZ/+tlk1StWNKw7hhM2URRGpHaZ9 u+w36c724XjB7dqwplPYXl4= X-Google-Smtp-Source: ABdhPJyhCOFQn/Z1pKRmtZeJWu1d4dSY2QLiSj+ONw56eIR3cGKanVoF3Tn/DOinhtQ09s5N7gDupw== X-Received: by 2002:a05:6512:128c:: with SMTP id u12mr10567429lfs.160.1621859961442; Mon, 24 May 2021 05:39:21 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-110.dynamic.spd-mgts.ru. [109.252.193.110]) by smtp.googlemail.com with ESMTPSA id p21sm1409745lfg.97.2021.05.24.05.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 05:39:21 -0700 (PDT) Subject: Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled To: Geert Uytterhoeven Cc: Thierry Reding , Jonathan Hunter , Krzysztof Kozlowski , Stephen Boyd , Tony Lindgren , Arnd Bergmann , Paul Burton , John Crispin , "open list:BROADCOM NVRAM DRIVER" , Linux ARM , linux-m68k , Linux Kernel Mailing List , linux-tegra , linux-clk , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" References: <20210523232556.15017-1-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <8b6af8c0-6f01-193f-1eb4-4e230871f0cd@gmail.com> Date: Mon, 24 May 2021 15:39:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_053923_521504_E5D02A8D X-CRM114-Status: GOOD ( 21.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjQuMDUuMjAyMSAxMTo1NCwgR2VlcnQgVXl0dGVyaG9ldmVuINC/0LjRiNC10YI6Cj4gSGkgRG1p dHJ5LAo+IAo+IE9uIE1vbiwgTWF5IDI0LCAyMDIxIGF0IDE6MjYgQU0gRG1pdHJ5IE9zaXBlbmtv IDxkaWdldHhAZ21haWwuY29tPiB3cm90ZToKPj4gVGhlcmUgYXJlIGNvdXBsZSBvbGRlciBwbGF0 Zm9ybXMgdGhhdCBjYW4ndCBiZSBjb21waWxlLXRlc3RlZCBiZWNhdXNlIHRoZXkKPj4gcGFydGlh bGx5IGltcGxlbWVudCBDTEsgQVBJLiBJdCBjYXVzZXMgYnVpbGQgZmFpbHVyZSBvZiBrZXJuZWwg ZHJpdmVycyBkdWUKPj4gdG8gdGhlIG1pc3Npbmcgc3ltYm9scyBvZiB0aGUgdW5pbXBsZW1lbnRl ZCBwYXJ0IG9mIENMSyBBUEkuCj4+Cj4+IFRoZXNlIHBsYXRmb3JtcyBhcmU6IEFSTSBFUDkzWFgs IEFSTSBPTUFQMSwgbTY4ayBDb2xkRmlyZSwgTUlQUyBBUjcsCj4+ICAgICAgICAgICAgICAgICAg ICAgIE1JUFMgUmFsaW5rLgo+Pgo+PiBEaXNhYmxlIGNvbXBpbGUtdGVzdGluZyBmb3IgSEFWRV9M RUdBQ1lfQ0xLPXkuCj4+Cj4+IFJlcG9ydGVkLWJ5OiBrZXJuZWwgdGVzdCByb2JvdCA8bGtwQGlu dGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogRG1pdHJ5IE9zaXBlbmtvIDxkaWdldHhAZ21haWwu Y29tPgo+IAo+IFRoYW5rcyBmb3IgeW91ciBwYXRjaCEKPiAKPj4gLS0tIGEvaW5pdC9LY29uZmln Cj4+ICsrKyBiL2luaXQvS2NvbmZpZwo+PiBAQCAtMTMxLDcgKzEzMSw3IEBAIGNvbmZpZyBJTklU X0VOVl9BUkdfTElNSVQKPj4KPj4gIGNvbmZpZyBDT01QSUxFX1RFU1QKPj4gICAgICAgICBib29s ICJDb21waWxlIGFsc28gZHJpdmVycyB3aGljaCB3aWxsIG5vdCBsb2FkIgo+PiAtICAgICAgIGRl cGVuZHMgb24gSEFTX0lPTUVNCj4+ICsgICAgICAgZGVwZW5kcyBvbiBIQVNfSU9NRU0gJiYgIUhB VkVfTEVHQUNZX0NMSwo+IAo+IFRoYXQgc291bmRzIGEgYml0IGRyYXN0aWMgdG8gbWUuICBVc3Vh bGx5IHdlIGp1c3QgdHJ5IHRvIGltcGxlbWVudCB0aGUKPiBtaXNzaW5nIGZ1bmN0aW9uYWxpdHks IG9yIHByb3ZpZGUgc3R1YnMuCj4gV2hpY2ggZnVuY3Rpb25zIGFyZSBtaXNzaW5nPwoKRXZlcnl0 aGluZyB0aGF0IGJlbG9uZ3MgdG8gQ09ORklHX0NPTU1PTl9DTEsgbmVlZHMgc3R1YnMuCgpUaGF0 IGlzIGV2ZXJ5dGhpbmcgdW5kZXIgQ09ORklHX0hBVkVfQ0xLIFsxXSwgZXhjbHVkaW5nIGZ1bmN0 aW9ucwpiZWxvbmdpbmcgdG8gY2xrLWRldnJlcy5vIGFuZCBjbGstYnVsay5vIFsyXS4gVGhlIEhB VkVfTEVHQUNZX0NMSwpzZWxlY3RzIEhBVkVfQ0xLLCBidXQgdGhlIENPTU1PTl9DTEsgaXMgdW5k ZXIgSEFWRV9DTEsgdG9vLgoKWzFdCmh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L3Y1 LjEzLXJjMy9zb3VyY2UvaW5jbHVkZS9saW51eC9jbGsuaCNMNzg2ClsyXQpodHRwczovL2VsaXhp ci5ib290bGluLmNvbS9saW51eC92NS4xMy1yYzMvc291cmNlL2RyaXZlcnMvY2xrL01ha2VmaWxl I0wzCgpUaGlzIHByb2JsZW0gaXMgcmVwZWF0ZWQgb3ZlciBhbmQgb3ZlciBhZ2FpbiBmb3IgdGhl IHBhc3QgeWVhcnMuIFNvbWUKbWFpbnRhaW5lcnMgYXJlIGFkZGluZyAiZGVwZW5kcyBvbiBDT01N T05fQ0xLIiBmb3IgQ09NUElMRV9URVNUIG9mIGVhY2gKZHJpdmVyLCBidXQgdGhpcyBkb2Vzbid0 IHNvbHZlIHRoZSByb290IG9mIHRoZSBwcm9ibGVtLCBhbmQgdGh1cywgaXQncwpjb25zdGFudGx5 IHJlb2NjdXJyaW5nLgoKUmVjZW50bHkgS3J6eXN6dG9mIEtvemxvd3NraSBhZGRlZCBjb3VwbGUg bW9yZSBjbGsgc3R1YnMgZm9yIE1JUFMsIGJ1dApzdGlsbCBsb3RzIG9mIHN0dWJzIGFyZSBtaXNz aW5nLiBTb21lIHBsYXRmb3JtcyBkb24ndCBoYXZlIGFueSBzdHVicyBhdAphbGwgYW5kIGFwcGFy ZW50bHkgbm9ib2R5IGNhcmVzIHRvIGZpeCB0aGVtLgoKVGhlcmUgMyBwb3NzaWJsZSBzb2x1dGlv bnM6CgoxLiBGYWN0b3Igb3V0IENPTU1PTl9DTEsgZnJvbSBIQVZFX0xFR0FDWV9DTEssIGlmIHRo aXMgaXMgcG9zc2libGUKMi4gQnVpbGQgc3R1YnMgdW5pdmVyc2FsbHksIG1heWJlIHVzaW5nIHdl YWsgZnVuY3Rpb25zLgozLiBEaXNhYmxlIGNvbXBpbGUtdGVzdGluZyBmb3IgSEFWRV9MRUdBQ1lf Q0xLCgpUaGUgdGhpcmQgb3B0aW9uIGlzIHRoZSBzaW1wbGVzdC4gSWYgYW55b25lIHdpbGwgY2Fy ZSB0byBmaXggdGhvc2UKbGVnYWN5IHBsYXRmb3JtcyBwcm9wZXJseSwgdGhlbiBjb21waWxlLXRl c3RpbmcgY291bGQgYmUgcmUtZW5hYmxlZCBmb3IKdGhlbS4gVGhpcyBpcyBteSBwcm9wb3NhbC4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK