From: Derrick Stolee <derrickstolee@github.com>
To: Abhradeep Chakraborty via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Subject: Re: [PATCH v2] partial-clone: add a partial-clone test case
Date: Mon, 21 Mar 2022 11:26:14 -0400 [thread overview]
Message-ID: <8b6b7c0f-0c49-5348-8b46-41f0dba334eb@github.com> (raw)
In-Reply-To: <pull.1175.v2.git.1647423969576.gitgitgadget@gmail.com>
On 3/16/2022 5:46 AM, Abhradeep Chakraborty via GitGitGadget wrote:
> From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
>
> In a blobless-cloned repo, `git log --follow -- <path>` (`<path>` have
> an exact OID rename) shouldn't download blob of the file from where the
> new file is renamed.
>
> Add a test case to verify it.
>
> Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
> ---
> partial-clone: add a partial-clone test case
>
> changes since v1:
>
> 1. remove the event track method to detect the downloading as it is not
> future proof ( and buggy).
> 2. Instead see if the file is missing initially and after running the
> git log --follow ... command.
> +test_expect_success 'exact rename does not need to fetch the blob lazily' '
> + rm -rf repo partial.git &&
> + test_create_repo repo &&
> + content="some dummy content" &&
> + test_commit -C repo create-a-file file.txt "$content" &&
> + git -C repo mv file.txt new-file.txt &&
> + git -C repo commit -m rename-the-file &&
> + FILE_HASH=$(git -C repo rev-parse HEAD:new-file.txt) &&
> + test_config -C repo uploadpack.allowfilter 1 &&
> + test_config -C repo uploadpack.allowanysha1inwant 1 &&
> +
> + git clone --filter=blob:none --bare "file://$(pwd)/repo" partial.git &&
> + git -C partial.git rev-list --objects --missing=print HEAD >out &&
> + grep "[?]$FILE_HASH" out &&
> + git -C partial.git log --follow -- new-file.txt &&
> + git -C partial.git rev-list --objects --missing=print HEAD >out &&
> + grep "[?]$FILE_HASH" out
> +'
> +
Thanks for taking the feedback and turning it into a good test!
I'm adding it as a TODO to go fix the buggy helper as discussed.
Thanks,
-Stolee
prev parent reply other threads:[~2022-03-21 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 17:39 [PATCH] partial-clone: add a partial-clone test case Abhradeep Chakraborty via GitGitGadget
2022-03-13 19:41 ` Junio C Hamano
2022-03-14 15:46 ` Abhradeep Chakraborty
2022-03-14 16:25 ` Derrick Stolee
2022-03-14 21:42 ` Junio C Hamano
2022-03-15 8:20 ` Abhradeep Chakraborty
2022-03-14 21:35 ` Junio C Hamano
2022-03-14 16:24 ` Derrick Stolee
2022-03-14 22:21 ` Junio C Hamano
2022-03-15 11:30 ` Abhradeep Chakraborty
2022-03-15 12:57 ` Derrick Stolee
2022-03-15 15:15 ` Abhradeep Chakraborty
2022-03-15 16:13 ` Junio C Hamano
2022-03-16 8:06 ` Abhradeep Chakraborty
2022-03-16 9:46 ` [PATCH v2] " Abhradeep Chakraborty via GitGitGadget
2022-03-21 15:26 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b6b7c0f-0c49-5348-8b46-41f0dba334eb@github.com \
--to=derrickstolee@github.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chakrabortyabhradeep79@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.