All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Darren Hart <dvhart@infradead.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v6] platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver
Date: Thu, 6 Apr 2017 14:17:11 +0200	[thread overview]
Message-ID: <8b6df86e-06eb-5be8-ee8c-9af980691fa5@redhat.com> (raw)
In-Reply-To: <1491476636.24567.25.camel@linux.intel.com>

Hi,

On 06-04-17 13:03, Andy Shevchenko wrote:
> On Thu, 2017-04-06 at 09:24 +0200, Hans de Goede wrote:
>> The INT33FE ACPI device has a CRS table with I2cSerialBusV2 resources
>> for
>> 3 devices: Maxim MAX17047 Fuel Gauge Controller, FUSB302 USB Type-C
>> Controller and PI3USB30532 USB switch.
>>
>> This commit adds a driver for this ACPI device which instantiates
>> i2c-clients for these, so that the standard i2c drivers for these
>> chips
>> can bind to the them.
>
> Given one more thought, if the devices should be present all to make it
> work, than you perhaps may use component framework.

Actually the fuel-guage is completely independent, the PI3USB30532 USB
switch will get set based on extcon cable events from the FUSB302 USB
Type-C controller, but otherwise both drivers are independent and the
FUSB302 USB Type-C controller pretty much operates stand-alone.

> In this case this so called "pseudo" device is not so pseudo, but
> "master".

I think this is really some Windows weirdness, if I configure the BIOS
to boot "Android" the ACPI INT33FE device goes away and instead I
get 3 separate ACPI devices for the 3 chips.

Regards,

Hans

  reply	other threads:[~2017-04-06 12:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06  7:24 [PATCH v6] platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver Hans de Goede
2017-04-06 11:03 ` Andy Shevchenko
2017-04-06 12:17   ` Hans de Goede [this message]
2017-04-06 22:48     ` Darren Hart
2017-04-07  6:49       ` Hans de Goede
2017-04-13 19:12         ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b6df86e-06eb-5be8-ee8c-9af980691fa5@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dvhart@infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.