From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v4 2/3] ethdev: convert static logtype usage
 to dynamic
Date: Tue, 19 Jun 2018 16:11:49 +0300
Message-ID: <8b6ead9a-a329-dadc-d523-ab89ff8269ca@solarflare.com>
References: <20180514155648.81149-1-ferruh.yigit@intel.com>
 <20180619010457.61490-1-ferruh.yigit@intel.com>
 <20180619010457.61490-2-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 4C60D4C8A
 for <dev@dpdk.org>; Tue, 19 Jun 2018 15:12:00 +0200 (CEST)
In-Reply-To: <20180619010457.61490-2-ferruh.yigit@intel.com>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 06/19/2018 04:04 AM, Ferruh Yigit wrote:
> Replace RTE_PMD_DEBUG_TRACE with RTE_ETHDEV_LOG.
>
> RTE_PMD_DEBUG_TRACE is using hardcoded PMD logtype and ERR log level,
> controlled by compile time flags.
> RTE_ETHDEV_LOG is using dynamic ethdev_logtype.
>
> Also a few minor cleanups, like
> - use %u for unsigned values like port_id which is uint16_t
> - use PRIx64 for owner_id
> - Join some log lines
> - Unify to not have a "." at the end of the log
> - Unify log start with uppercase
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

The patch is too long due to many minor cleanups in one
changeset, but I think it is still OK to go.

Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>