From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [RFC PATCH 0/3] M_CAN Framework rework Date: Wed, 24 Oct 2018 06:39:33 -0500 Message-ID: <8b793f8a-6ffb-9e23-1965-9e7c631031a1@ti.com> References: <20181010142055.25271-1-dmurphy@ti.com> <8247a28f-ae33-1ab1-b6d1-c89b839d357c@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8247a28f-ae33-1ab1-b6d1-c89b839d357c@ti.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Faiz Abbas , wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-can.vger.kernel.org On 10/24/2018 02:33 AM, Faiz Abbas wrote: > Hi Dan, > > On Thursday 18 October 2018 01:51 AM, Dan Murphy wrote: >> Bump >> >> On 10/10/2018 09:20 AM, Dan Murphy wrote: >>> All >>> >>> This patch series creates a m_can core framework that devices can register >>> to. The m_can core manages the Bosch IP and CAN frames. Each device that >>> is registered is responsible for managing device specific functions. >>> >>> This rewrite was suggested in a device driver submission for the TCAN4x5x >>> device >>> Reference upstream post: >>> https://lore.kernel.org/patchwork/patch/984163/ >>> >>> For instance the TCAN device is a SPI device that uses a specific data payload to >>> determine writes and reads. In addition the device has a reset input as well >>> as a wakeup pin. The register offset of the m_can registers differs and must >>> be set by the device attached to the core. >>> >>> The m_can core will use iomapped writes and reads as the default mechanism for >>> writing and reading. The device driver can provide over rides for this. >>> >>> This patch series is not complete as it does not handle the CAN interrupts >>> nor can perform a CAN write. If this patch series is deemed acceptable I will >>> finish debugging the driver and post a non RFC series. >>> >>> Finally I did attempt to reduce the first patch with various git format patch >>> directives but none seemed to reduce the patch. >>> >>> Dan >>> >>> Dan Murphy (3): >>> can: m_can: Create m_can core to leverage common code >>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >>> can: tcan4x5x: Add tcan4x5x driver to the kernel >>> >>> .../devicetree/bindings/net/can/tcan4x5x.txt | 34 + >>> drivers/net/can/m_can/Kconfig | 18 + >>> drivers/net/can/m_can/Makefile | 4 +- >>> drivers/net/can/m_can/m_can.c | 1683 +---------------- >>> .../net/can/m_can/{m_can.c => m_can_core.c} | 479 +++-- >>> drivers/net/can/m_can/m_can_core.h | 100 + >>> drivers/net/can/m_can/tcan4x5x.c | 321 ++++ >>> 7 files changed, 722 insertions(+), 1917 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>> copy drivers/net/can/m_can/{m_can.c => m_can_core.c} (83%) >>> create mode 100644 drivers/net/can/m_can/m_can_core.h >>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >>> > > Patch 1/3 never arrived for me. Its not there on lkml either. > https://lkml.org/lkml/2018/10/10/611 > LKML seems to have issue with 1/3. Here they were posted. Maybe the patch is to large but I received all 3 + the cover letter. https://lore.kernel.org/patchwork/patch/998019/ https://lore.kernel.org/patchwork/patch/998017/ https://lore.kernel.org/patchwork/patch/998020/ > Can you resend the complete series? > > Thanks, > Faiz > -- ------------------ Dan Murphy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B51BEC004D3 for ; Wed, 24 Oct 2018 11:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 619152082E for ; Wed, 24 Oct 2018 11:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="uDyI5xJM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 619152082E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727456AbeJXUHf (ORCPT ); Wed, 24 Oct 2018 16:07:35 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:46530 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726428AbeJXUHf (ORCPT ); Wed, 24 Oct 2018 16:07:35 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id w9OBdfm7046183; Wed, 24 Oct 2018 06:39:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1540381181; bh=D8C+71HgbOmzWSmmFjgZIm6OrZVmpL6uqIr4i0Xaf0E=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=uDyI5xJMLFKogOFsGRpgkTzZa+PlJ+yUYBMyP5kYXyLAA5PyUt3HIj+vo9BDrjp6i SVjl8EbcbjQgjcE0RsE297ybMT6Pq9cC24PmxRZ0buRuIUv0t+/dp6FMF3xSeC50c8 aupKjHXgrkHaSexKcqZkeHQEos7w0RRJvEn/0yqE= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9OBdfWk023012; Wed, 24 Oct 2018 06:39:41 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 24 Oct 2018 06:39:41 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Wed, 24 Oct 2018 06:39:41 -0500 Received: from [172.22.136.76] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9OBdeih007833; Wed, 24 Oct 2018 06:39:40 -0500 Subject: Re: [RFC PATCH 0/3] M_CAN Framework rework To: Faiz Abbas , , , CC: , , References: <20181010142055.25271-1-dmurphy@ti.com> <8247a28f-ae33-1ab1-b6d1-c89b839d357c@ti.com> From: Dan Murphy Message-ID: <8b793f8a-6ffb-9e23-1965-9e7c631031a1@ti.com> Date: Wed, 24 Oct 2018 06:39:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <8247a28f-ae33-1ab1-b6d1-c89b839d357c@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2018 02:33 AM, Faiz Abbas wrote: > Hi Dan, > > On Thursday 18 October 2018 01:51 AM, Dan Murphy wrote: >> Bump >> >> On 10/10/2018 09:20 AM, Dan Murphy wrote: >>> All >>> >>> This patch series creates a m_can core framework that devices can register >>> to. The m_can core manages the Bosch IP and CAN frames. Each device that >>> is registered is responsible for managing device specific functions. >>> >>> This rewrite was suggested in a device driver submission for the TCAN4x5x >>> device >>> Reference upstream post: >>> https://lore.kernel.org/patchwork/patch/984163/ >>> >>> For instance the TCAN device is a SPI device that uses a specific data payload to >>> determine writes and reads. In addition the device has a reset input as well >>> as a wakeup pin. The register offset of the m_can registers differs and must >>> be set by the device attached to the core. >>> >>> The m_can core will use iomapped writes and reads as the default mechanism for >>> writing and reading. The device driver can provide over rides for this. >>> >>> This patch series is not complete as it does not handle the CAN interrupts >>> nor can perform a CAN write. If this patch series is deemed acceptable I will >>> finish debugging the driver and post a non RFC series. >>> >>> Finally I did attempt to reduce the first patch with various git format patch >>> directives but none seemed to reduce the patch. >>> >>> Dan >>> >>> Dan Murphy (3): >>> can: m_can: Create m_can core to leverage common code >>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >>> can: tcan4x5x: Add tcan4x5x driver to the kernel >>> >>> .../devicetree/bindings/net/can/tcan4x5x.txt | 34 + >>> drivers/net/can/m_can/Kconfig | 18 + >>> drivers/net/can/m_can/Makefile | 4 +- >>> drivers/net/can/m_can/m_can.c | 1683 +---------------- >>> .../net/can/m_can/{m_can.c => m_can_core.c} | 479 +++-- >>> drivers/net/can/m_can/m_can_core.h | 100 + >>> drivers/net/can/m_can/tcan4x5x.c | 321 ++++ >>> 7 files changed, 722 insertions(+), 1917 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>> copy drivers/net/can/m_can/{m_can.c => m_can_core.c} (83%) >>> create mode 100644 drivers/net/can/m_can/m_can_core.h >>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >>> > > Patch 1/3 never arrived for me. Its not there on lkml either. > https://lkml.org/lkml/2018/10/10/611 > LKML seems to have issue with 1/3. Here they were posted. Maybe the patch is to large but I received all 3 + the cover letter. https://lore.kernel.org/patchwork/patch/998019/ https://lore.kernel.org/patchwork/patch/998017/ https://lore.kernel.org/patchwork/patch/998020/ > Can you resend the complete series? > > Thanks, > Faiz > -- ------------------ Dan Murphy