From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40570)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1bcfg2-0000pD-NR
	for qemu-devel@nongnu.org; Wed, 24 Aug 2016 17:25:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1bcfg0-0006CG-Cg
	for qemu-devel@nongnu.org; Wed, 24 Aug 2016 17:25:37 -0400
References: <4a78a3a5-91ba-b3bd-a59c-d1ebf9f1470b@reactos.org>
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-ID: <8b904429-7e93-4eff-d61b-ce1fd5e47e8a@ilande.co.uk>
Date: Wed, 24 Aug 2016 22:25:07 +0100
MIME-Version: 1.0
In-Reply-To: <4a78a3a5-91ba-b3bd-a59c-d1ebf9f1470b@reactos.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] ppc: regression in 2.7.0-rc3 on rfi/rfid/hrfi
 instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Herv=c3=a9_Poussineau?= <hpoussin@reactos.org>, qemu-devel <qemu-devel@nongnu.org>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, benh@kernel.crashing.org

On 24/08/16 19:39, Hervé Poussineau wrote:

> Hi,
> 
> Following patch regresses Linux boot on PReP machine:
> 
> commit a2e71b28e832346409efc795ecd1f0a2bcb705a3
> Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date:   Tue Jun 21 23:48:46 2016 +0200
> 
>     ppc: Fix rfi/rfid/hrfi/... emulation
> 
>     This reworks emulation of the various "rfi" variants. I removed
>     some masking bits that I couldn't make sense of, the only bit that
>     I am aware we should mask here is POW, the CPU's MSR mask should
>     take care of the rest.
> 
>     This also fixes some problems when running 32-bit userspace under
>     a 64-bit kernel.
> 
>     This patch broke 32bit OpenBIOS when run under a 970 cpu. A fix was
>     proposed here :
> 
>         https://www.coreboot.org/pipermail/openbios/2016-June/009452.html
> 
>     Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>     Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>     [clg: updated the commit log with the reference of the openbios fix ]
>     Signed-off-by: Cédric Le Goater <clg@kaod.org>
>     [dwg: Remove hunk which disabled rfi on 64-bit CPUS.  The change was
>      correct, but we need to fix OpenBIOS before applying it]
>     Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> 
> Test case:
> - Download: http://www.juneau-lug.org/zImage.initrd.sandalfoot
> - Run: qemu-system-ppc -M prep -kernel zImage.initrd.sandalfoot
> 
> Firmware starts, loads kernel, but seems to error out just after PS/2
> detection.
> 
> Reverting the commit and fixing the conflict makes it work again, up to
> shell.

I can at least confirm that the v4 patch was applied to OpenBIOS for the
last update:
http://git.qemu.org/?p=openbios.git;a=commit;h=b747b6acc272f6ab839728193042455c9b36e26a.


ATB,

Mark.