From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A1A5C43334 for ; Sun, 26 Jun 2022 10:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234180AbiFZKtN (ORCPT ); Sun, 26 Jun 2022 06:49:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234294AbiFZKtM (ORCPT ); Sun, 26 Jun 2022 06:49:12 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB918FD1D for ; Sun, 26 Jun 2022 03:49:09 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id r18so1419407edb.9 for ; Sun, 26 Jun 2022 03:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=mmEZuF3sSMd4FiYZEbnqFV/YPFODuaItHC3npgDdbmY=; b=sAMMH6H1Igx/l0oc1TMDg0yhWD2+7xxpQaRJDVU6VU99ReByrwf8ByJmoIccKcHJSm 142dAFEQavZd/Lmt6SXt8gOGFKGqQgRV2VE7d0t2EIm0REzEjNN3T1s6/KoJu3XjI82Q WMx9uHdTA3us9tlf1cJtjA2qmFZh29yPpUTMg1rKPB2a59W+6SmYCIvI6cNupMNVhk+j FwrhlWmqH+MvVAEdOyw5O86MjNyqIr149R6dLVMzWMq8Eee9z1WWZtNEzFQ1x22A0J9e NiT8yRtxZbHC2i6+utob8AGe5tnCIFEMB3gF4Fw+VADCwTtmXWXPhvNa4omYr/YSeldv S11A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mmEZuF3sSMd4FiYZEbnqFV/YPFODuaItHC3npgDdbmY=; b=L7T9+L72G4YHAJ+wbqnvMOCVIcijf3DeCDTCr/wCEuLYszdOuZUfXxxcGHQsexUo3R rAm/yPykQIkGxGuqvGuGOjJUHmqfBJ7tCMqO796b4tUzG9FmgD3hRepR9SGKiQzT7lFN sNb371o/GeQePAXihLTw67uSTqlgtW2qkr4Geef3IKVGuW2wHfeLM9mn5uZ3oftV6ckS GOdCa+Pw+Z8aK4b+I+HcF58bKyIQ8FWs3Wgeo1GaD3SbFDN5mCF3tUS5r51PHyhOsfqT iLGwl5bF6ClrcQr8ovFzJyMVm36PrSh5Gv5LYVQJDhXs2jtCipA+yCppglnCYjC662EZ 89VQ== X-Gm-Message-State: AJIora/UThGFK4ikuf4TzLjea78d67a/AY3IacbK4noEzIOPkISQGU/z HYL9w3SiN3+JVrAlPoqUhL5DrzWOQT42gA== X-Google-Smtp-Source: AGRyM1umek5iPRNqIejfVVCxmNssO5BgP+bQ+pexW3w1fg6cBla9xeht8NvKw++YLsTe34mcv9gYLw== X-Received: by 2002:a05:6402:3886:b0:435:643a:b7ae with SMTP id fd6-20020a056402388600b00435643ab7aemr10010189edb.4.1656240548399; Sun, 26 Jun 2022 03:49:08 -0700 (PDT) Received: from [192.168.0.239] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q22-20020a170906941600b0072660d8d83fsm1643197ejx.188.2022.06.26.03.49.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jun 2022 03:49:08 -0700 (PDT) Message-ID: <8b9c2b8e-fb65-2b65-1294-47d3b5623f66@linaro.org> Date: Sun, 26 Jun 2022 12:49:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name Content-Language: en-US To: Serge Semin Cc: Serge Semin , Andy Gross , Bjorn Andersson , Felipe Balbi , Michael Ellerman , Vladimir Zapolskiy , Alexey Brodkin , Vineet Gupta , Rob Herring , Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Khuong Dinh , Krzysztof Kozlowski , Patrice Chotard , Benjamin Herrenschmidt , Paul Mackerras , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220624141622.7149-1-Sergey.Semin@baikalelectronics.ru> <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> <20220624205902.y2un4lr7d3zkc6jx@mobilestation> From: Krzysztof Kozlowski In-Reply-To: <20220624205902.y2un4lr7d3zkc6jx@mobilestation> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 24/06/2022 22:59, Serge Semin wrote: > On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote: >> On 24/06/2022 16:16, Serge Semin wrote: >>> In accordance with the DWC USB3 bindings the corresponding node >>> name is suppose to comply with the Generic USB HCD DT schema, which >>> requires the USB nodes to have the name acceptable by the regexp: >>> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly >>> named despite of the warning comment about possible backward >>> compatibility issues. >> > >> Sometimes node name is exposed to user-space which depends on it. How >> did you check there is no issue here? > > I well remember the Qcom problem caused by one of my patch: > https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/ > > The next patch caused the same problem, but hasn't been reverted. > https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ > > As before I am more inclined to thinking that the problem was mainly caused > by the improper node-name utilization. Anyway John later noted that the > problem was fixed in the user-space. Yes, I remember. The node names are not considered ABI, therefore any reliance on them is not correct. I wonder however what was the reasoning for this comment in APM DTS. > That why afterwards you were able > to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3 > node names and unit addresses"). > > Anyway I am not able to track the way the node-name is used on the > affected platform and can't make sure that the dts would be still > working well on that devices. But seeing nobody responded/commented on > this patch for more than a year we can at least try to merge this in > and see whether it causes any problem should the denoted platform is > still in use. If it does we can revert the update back and forget > about it. The APM is kind of abandoned, so indeed we might never get a reply. I'll take it. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3354CCA47C for ; Sun, 26 Jun 2022 10:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X92EdffF8tYKqNQKgoBtcVeK5izd6AfKiX061/0aW08=; b=P88UIkclewRMky Cma9jaUkmWg2Q2u9PQ3pZD/URtnJUJLLUTMzr6wcsOdSooa9/cTrVLh4aKX7cR+BeU055+zWBU+O2 IR9/yV0XHdXN28QQvHp/a12Y/+Nkf7OCWbbeIu9jz+6ymOjSY8F8+L0PLmQvHR7IJtRHSsrzatP9R hABpE1qU+2aeaDkFL3qj5hNYB+KHV6qr+9dL3qmx9bp68an+kQHkpo7v1Ypae5cd/RtLW+XW7Rden A9ovtNcWR860RGE/JJrm6hQDd4vWJT4wT66Ra8eDOoJjoUJdFSSbjFyW8wY7BQ98sPkF4ZwAt0Fsq iaB63JgFtHDA7p5ILiYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5PpJ-00BHxS-74; Sun, 26 Jun 2022 10:49:13 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5PpG-00BHvm-Dq for linux-snps-arc@lists.infradead.org; Sun, 26 Jun 2022 10:49:12 +0000 Received: by mail-ed1-x52c.google.com with SMTP id e2so9317024edv.3 for ; Sun, 26 Jun 2022 03:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=mmEZuF3sSMd4FiYZEbnqFV/YPFODuaItHC3npgDdbmY=; b=sAMMH6H1Igx/l0oc1TMDg0yhWD2+7xxpQaRJDVU6VU99ReByrwf8ByJmoIccKcHJSm 142dAFEQavZd/Lmt6SXt8gOGFKGqQgRV2VE7d0t2EIm0REzEjNN3T1s6/KoJu3XjI82Q WMx9uHdTA3us9tlf1cJtjA2qmFZh29yPpUTMg1rKPB2a59W+6SmYCIvI6cNupMNVhk+j FwrhlWmqH+MvVAEdOyw5O86MjNyqIr149R6dLVMzWMq8Eee9z1WWZtNEzFQ1x22A0J9e NiT8yRtxZbHC2i6+utob8AGe5tnCIFEMB3gF4Fw+VADCwTtmXWXPhvNa4omYr/YSeldv S11A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mmEZuF3sSMd4FiYZEbnqFV/YPFODuaItHC3npgDdbmY=; b=4QGvlCoOqS4ijS/gYPHKU9rZbDDkYg0cOiiOaU09t5/6ND2FGP31jOAzDU5IQR9fI7 E673mAgXzLS6slTXPQBqyC/LMSzadvWzYjJT3sG/O9wsmsFjEQF0SDghkr01rCy+G0+H j+kAx88/qDAxM4rLimOokAV1GZJAR/liAkvmBa46raCTaQJcajyXxvW70ySPenRRTov1 +Qf2K54nosKHtoS7RH5QGzHR844ULgR0/mfggqlMEPMS6b/9YV5IKilCHVX9DQ5Nv7/r Hv68zvCSQ4dy+Pdka5MNdKVMKBglPHSYGbedaKcoKZFx3eMlJ8HCFHvMnkPNcazDN6w/ BR2g== X-Gm-Message-State: AJIora+FqzOKGSYif6LRpWuhGfuE0pJanjRfFyNYlGLbii0Ag2iUE01D gjTRE8HYsN59Vtn0N7glYTfYSw== X-Google-Smtp-Source: AGRyM1umek5iPRNqIejfVVCxmNssO5BgP+bQ+pexW3w1fg6cBla9xeht8NvKw++YLsTe34mcv9gYLw== X-Received: by 2002:a05:6402:3886:b0:435:643a:b7ae with SMTP id fd6-20020a056402388600b00435643ab7aemr10010189edb.4.1656240548399; Sun, 26 Jun 2022 03:49:08 -0700 (PDT) Received: from [192.168.0.239] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q22-20020a170906941600b0072660d8d83fsm1643197ejx.188.2022.06.26.03.49.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jun 2022 03:49:08 -0700 (PDT) Message-ID: <8b9c2b8e-fb65-2b65-1294-47d3b5623f66@linaro.org> Date: Sun, 26 Jun 2022 12:49:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name Content-Language: en-US To: Serge Semin Cc: Serge Semin , Andy Gross , Bjorn Andersson , Felipe Balbi , Michael Ellerman , Vladimir Zapolskiy , Alexey Brodkin , Vineet Gupta , Rob Herring , Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Khuong Dinh , Krzysztof Kozlowski , Patrice Chotard , Benjamin Herrenschmidt , Paul Mackerras , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220624141622.7149-1-Sergey.Semin@baikalelectronics.ru> <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> <20220624205902.y2un4lr7d3zkc6jx@mobilestation> From: Krzysztof Kozlowski In-Reply-To: <20220624205902.y2un4lr7d3zkc6jx@mobilestation> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220626_034910_610508_1A9EBA0B X-CRM114-Status: GOOD ( 22.56 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On 24/06/2022 22:59, Serge Semin wrote: > On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote: >> On 24/06/2022 16:16, Serge Semin wrote: >>> In accordance with the DWC USB3 bindings the corresponding node >>> name is suppose to comply with the Generic USB HCD DT schema, which >>> requires the USB nodes to have the name acceptable by the regexp: >>> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly >>> named despite of the warning comment about possible backward >>> compatibility issues. >> > >> Sometimes node name is exposed to user-space which depends on it. How >> did you check there is no issue here? > > I well remember the Qcom problem caused by one of my patch: > https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/ > > The next patch caused the same problem, but hasn't been reverted. > https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ > > As before I am more inclined to thinking that the problem was mainly caused > by the improper node-name utilization. Anyway John later noted that the > problem was fixed in the user-space. Yes, I remember. The node names are not considered ABI, therefore any reliance on them is not correct. I wonder however what was the reasoning for this comment in APM DTS. > That why afterwards you were able > to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3 > node names and unit addresses"). > > Anyway I am not able to track the way the node-name is used on the > affected platform and can't make sure that the dts would be still > working well on that devices. But seeing nobody responded/commented on > this patch for more than a year we can at least try to merge this in > and see whether it causes any problem should the denoted platform is > still in use. If it does we can revert the update back and forget > about it. The APM is kind of abandoned, so indeed we might never get a reply. I'll take it. Best regards, Krzysztof _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 025BAC433EF for ; Sun, 26 Jun 2022 10:49:53 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LW70c3q0Qz3cFD for ; Sun, 26 Jun 2022 20:49:52 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=sAMMH6H1; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::52b; helo=mail-ed1-x52b.google.com; envelope-from=krzysztof.kozlowski@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=sAMMH6H1; dkim-atps=neutral Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LW6zt3zl5z3bf9 for ; Sun, 26 Jun 2022 20:49:12 +1000 (AEST) Received: by mail-ed1-x52b.google.com with SMTP id o10so9323219edi.1 for ; Sun, 26 Jun 2022 03:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=mmEZuF3sSMd4FiYZEbnqFV/YPFODuaItHC3npgDdbmY=; b=sAMMH6H1Igx/l0oc1TMDg0yhWD2+7xxpQaRJDVU6VU99ReByrwf8ByJmoIccKcHJSm 142dAFEQavZd/Lmt6SXt8gOGFKGqQgRV2VE7d0t2EIm0REzEjNN3T1s6/KoJu3XjI82Q WMx9uHdTA3us9tlf1cJtjA2qmFZh29yPpUTMg1rKPB2a59W+6SmYCIvI6cNupMNVhk+j FwrhlWmqH+MvVAEdOyw5O86MjNyqIr149R6dLVMzWMq8Eee9z1WWZtNEzFQ1x22A0J9e NiT8yRtxZbHC2i6+utob8AGe5tnCIFEMB3gF4Fw+VADCwTtmXWXPhvNa4omYr/YSeldv S11A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mmEZuF3sSMd4FiYZEbnqFV/YPFODuaItHC3npgDdbmY=; b=y45fxrhuvbbO9qBfLsuH3ayV4Na0Aj8/wxeOkj6jJK/HnE142iBLEDyXCliYcj1PJk goXmSVApu9bkI/+Z8z3ZXGT6W6zRuTOgg14IjH+ydAXVnirRAiYyf8tAG+3W2ziv0l+t SNMEwX/OfA/v+Kg/rQ62jf+ycwV2C0EjEoDC6fLvwqzJROClQ42Z88/5uCcdvLHr47tZ Wn3I85W1Gt5LmPqeGNYu76XjHmjtfa6lVLkJumqckDnvFlihMxgUm4d14GVEPQUsKvPr bgocdQN7bFwytwhn0kwJi+r3XQq7dWN0FDdHG4JMFal1ZIbV5XFVNA6LKs2a2aF4W4ao g5cQ== X-Gm-Message-State: AJIora/E506foMPUkGEg8jqE4lZ0TM1nGlKg88tPpPbQ99pfgTTmml1c SkVvNl1ax96jWfq25jCwO5n8+Q== X-Google-Smtp-Source: AGRyM1umek5iPRNqIejfVVCxmNssO5BgP+bQ+pexW3w1fg6cBla9xeht8NvKw++YLsTe34mcv9gYLw== X-Received: by 2002:a05:6402:3886:b0:435:643a:b7ae with SMTP id fd6-20020a056402388600b00435643ab7aemr10010189edb.4.1656240548399; Sun, 26 Jun 2022 03:49:08 -0700 (PDT) Received: from [192.168.0.239] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q22-20020a170906941600b0072660d8d83fsm1643197ejx.188.2022.06.26.03.49.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jun 2022 03:49:08 -0700 (PDT) Message-ID: <8b9c2b8e-fb65-2b65-1294-47d3b5623f66@linaro.org> Date: Sun, 26 Jun 2022 12:49:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name Content-Language: en-US To: Serge Semin References: <20220624141622.7149-1-Sergey.Semin@baikalelectronics.ru> <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> <20220624205902.y2un4lr7d3zkc6jx@mobilestation> From: Krzysztof Kozlowski In-Reply-To: <20220624205902.y2un4lr7d3zkc6jx@mobilestation> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bjorn Andersson , Paul Mackerras , Krzysztof Kozlowski , Rob Herring , Khuong Dinh , Alexey Brodkin , Krzysztof Kozlowski , Andy Gross , linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vladimir Zapolskiy , Rob Herring , linux-arm-kernel@lists.infradead.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Patrice Chotard , linux-kernel@vger.kernel.org, Serge Semin , Vineet Gupta , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 24/06/2022 22:59, Serge Semin wrote: > On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote: >> On 24/06/2022 16:16, Serge Semin wrote: >>> In accordance with the DWC USB3 bindings the corresponding node >>> name is suppose to comply with the Generic USB HCD DT schema, which >>> requires the USB nodes to have the name acceptable by the regexp: >>> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly >>> named despite of the warning comment about possible backward >>> compatibility issues. >> > >> Sometimes node name is exposed to user-space which depends on it. How >> did you check there is no issue here? > > I well remember the Qcom problem caused by one of my patch: > https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/ > > The next patch caused the same problem, but hasn't been reverted. > https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ > > As before I am more inclined to thinking that the problem was mainly caused > by the improper node-name utilization. Anyway John later noted that the > problem was fixed in the user-space. Yes, I remember. The node names are not considered ABI, therefore any reliance on them is not correct. I wonder however what was the reasoning for this comment in APM DTS. > That why afterwards you were able > to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3 > node names and unit addresses"). > > Anyway I am not able to track the way the node-name is used on the > affected platform and can't make sure that the dts would be still > working well on that devices. But seeing nobody responded/commented on > this patch for more than a year we can at least try to merge this in > and see whether it causes any problem should the denoted platform is > still in use. If it does we can revert the update back and forget > about it. The APM is kind of abandoned, so indeed we might never get a reply. I'll take it. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B45AC43334 for ; Sun, 26 Jun 2022 10:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6BRksMCgKjfVO2E+tamKVg1hioXdizuI0GqaLx7Can4=; b=ECnkaj/QAkh4tm IVx1MV4P2bKw5MdYgZ/ObtOLudk0/SNM4xDY3cbIYhApOgKGVPuZCOFGbKDqNd0PpW3181cgvqf/z We8MHa+1/l1+Q7NFfe2OiEXyC/Nz3B4H/ifTj+9P2BsvM1DWp7pDA2PoZepPvKvALI94CCx00Urzl mdq2jLN2NESvwpFyWLy0LZIv6CMY32Kl8fcfci9eb0+AoskdKKU8GvH6Zw9DghbfQ62w4YY43mXp4 jILo19XcASOLyUBYPW73Nydh/CCWBthMB9oiAJmuvHk4VNEg77TCN7z7NqTWLhWf4n4e47lRGZcp8 H/Bbzsicf3mvIyuA3HVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5PpK-00BHxd-0i; Sun, 26 Jun 2022 10:49:14 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5PpG-00BHvn-O0 for linux-arm-kernel@lists.infradead.org; Sun, 26 Jun 2022 10:49:12 +0000 Received: by mail-ed1-x52f.google.com with SMTP id z7so9247919edm.13 for ; Sun, 26 Jun 2022 03:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=mmEZuF3sSMd4FiYZEbnqFV/YPFODuaItHC3npgDdbmY=; b=sAMMH6H1Igx/l0oc1TMDg0yhWD2+7xxpQaRJDVU6VU99ReByrwf8ByJmoIccKcHJSm 142dAFEQavZd/Lmt6SXt8gOGFKGqQgRV2VE7d0t2EIm0REzEjNN3T1s6/KoJu3XjI82Q WMx9uHdTA3us9tlf1cJtjA2qmFZh29yPpUTMg1rKPB2a59W+6SmYCIvI6cNupMNVhk+j FwrhlWmqH+MvVAEdOyw5O86MjNyqIr149R6dLVMzWMq8Eee9z1WWZtNEzFQ1x22A0J9e NiT8yRtxZbHC2i6+utob8AGe5tnCIFEMB3gF4Fw+VADCwTtmXWXPhvNa4omYr/YSeldv S11A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mmEZuF3sSMd4FiYZEbnqFV/YPFODuaItHC3npgDdbmY=; b=ja6FsfI/evXff4BMnfx4J+IAzzNaALp747/2w3882F2PHBA1fyF7mX9p3O7MLflrxw FXnHEzGdpU9FO1O8Bo9cNOlmw+M3uTPZVYer3mzG0fOO3M3oodyDECKuxKybNzCgWOJD xRtqhpfhd5NJl7JR0mAD8CAuYKXljpuRwH68EDCETfYn5xdfTG66xyDu0Ils6WZHjGam Yo5VYYZ+h7XUEmJiVcsRHMGNeGtsckh4ex8rwmlqnyDUSVIjFPBkCabHOY3DpJYjSkC7 zbtm0NzYrjuGv0t+Twx/k2ZlDp/q/Z+sxrJGdXcBpCuhSVBNX/zJyIbCzLjwKpjSJgIk QY7A== X-Gm-Message-State: AJIora/dD2yNwCvszVa/yOYNWLqafLMEmeu0z5Ebfvu5J2yq97Gv1ZBX seYfiX7aFy+CajE4SjS0L1jKKw== X-Google-Smtp-Source: AGRyM1umek5iPRNqIejfVVCxmNssO5BgP+bQ+pexW3w1fg6cBla9xeht8NvKw++YLsTe34mcv9gYLw== X-Received: by 2002:a05:6402:3886:b0:435:643a:b7ae with SMTP id fd6-20020a056402388600b00435643ab7aemr10010189edb.4.1656240548399; Sun, 26 Jun 2022 03:49:08 -0700 (PDT) Received: from [192.168.0.239] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q22-20020a170906941600b0072660d8d83fsm1643197ejx.188.2022.06.26.03.49.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jun 2022 03:49:08 -0700 (PDT) Message-ID: <8b9c2b8e-fb65-2b65-1294-47d3b5623f66@linaro.org> Date: Sun, 26 Jun 2022 12:49:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH RESEND v9 5/5] arm64: dts: apm: Harmonize DWC USB3 DT nodes name Content-Language: en-US To: Serge Semin Cc: Serge Semin , Andy Gross , Bjorn Andersson , Felipe Balbi , Michael Ellerman , Vladimir Zapolskiy , Alexey Brodkin , Vineet Gupta , Rob Herring , Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Khuong Dinh , Krzysztof Kozlowski , Patrice Chotard , Benjamin Herrenschmidt , Paul Mackerras , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220624141622.7149-1-Sergey.Semin@baikalelectronics.ru> <20220624141622.7149-6-Sergey.Semin@baikalelectronics.ru> <20220624205902.y2un4lr7d3zkc6jx@mobilestation> From: Krzysztof Kozlowski In-Reply-To: <20220624205902.y2un4lr7d3zkc6jx@mobilestation> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220626_034910_811951_C1B34D62 X-CRM114-Status: GOOD ( 23.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/06/2022 22:59, Serge Semin wrote: > On Fri, Jun 24, 2022 at 07:17:53PM +0200, Krzysztof Kozlowski wrote: >> On 24/06/2022 16:16, Serge Semin wrote: >>> In accordance with the DWC USB3 bindings the corresponding node >>> name is suppose to comply with the Generic USB HCD DT schema, which >>> requires the USB nodes to have the name acceptable by the regexp: >>> "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly >>> named despite of the warning comment about possible backward >>> compatibility issues. >> > >> Sometimes node name is exposed to user-space which depends on it. How >> did you check there is no issue here? > > I well remember the Qcom problem caused by one of my patch: > https://lore.kernel.org/lkml/CALAqxLX_FNvFndEDWtGbFPjSzuAbfqxQE07diBJFZtftwEJX5A@mail.gmail.com/ > > The next patch caused the same problem, but hasn't been reverted. > https://lore.kernel.org/lkml/CALAqxLWGujgR7p8Vb5S_RimRVYxwm5XF-c4NkKgMH-43wEBaWg@mail.gmail.com/ > > As before I am more inclined to thinking that the problem was mainly caused > by the improper node-name utilization. Anyway John later noted that the > problem was fixed in the user-space. Yes, I remember. The node names are not considered ABI, therefore any reliance on them is not correct. I wonder however what was the reasoning for this comment in APM DTS. > That why afterwards you were able > to provide the commit b77a1c4d6b05 ("arm64: dts: qcom: correct DWC3 > node names and unit addresses"). > > Anyway I am not able to track the way the node-name is used on the > affected platform and can't make sure that the dts would be still > working well on that devices. But seeing nobody responded/commented on > this patch for more than a year we can at least try to merge this in > and see whether it causes any problem should the denoted platform is > still in use. If it does we can revert the update back and forget > about it. The APM is kind of abandoned, so indeed we might never get a reply. I'll take it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel