From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>, Jan Kotas <jank@cadence.com>
Cc: sanyog.r.kale@intel.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] soundwire: cdns: Fix compilation error on arm64
Date: Mon, 15 Apr 2019 07:41:33 -0500 [thread overview]
Message-ID: <8ba31402-b507-5060-76be-89a7ddaf7dca@linux.intel.com> (raw)
In-Reply-To: <20190414094408.GF28103@vkoul-mobl>
>> diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
>> index cb6a331f4..0b5bcc209 100644
>> --- a/drivers/soundwire/cadence_master.c
>> +++ b/drivers/soundwire/cadence_master.c
>> @@ -9,6 +9,7 @@
>> #include <linux/delay.h>
>> #include <linux/device.h>
>> #include <linux/interrupt.h>
>> +#include <linux/io.h>
>
> Why not add asm/io.h which is the header that actually defines
> readl/writel?
The vast majority of kernel code uses linux/io.h.
We use linux/io.h for SOF as well.
>
>> #include <linux/module.h>
>> #include <linux/mod_devicetable.h>
>> #include <linux/soundwire/sdw_registers.h>
>> --
>> 2.15.0
>
next prev parent reply other threads:[~2019-04-15 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 8:12 [PATCH] soundwire: cdns: Fix compilation error on arm64 Jan Kotas
2019-04-04 8:12 ` Jan Kotas
2019-04-04 8:52 ` Mukesh Ojha
2019-04-14 9:44 ` Vinod Koul
2019-04-15 12:41 ` Pierre-Louis Bossart [this message]
2019-04-16 8:43 ` [alsa-devel] " Jan Kotas
2019-05-09 7:00 ` Jan Kotas
2019-05-09 7:00 ` Jan Kotas
2019-05-27 5:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba31402-b507-5060-76be-89a7ddaf7dca@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.