From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH net 2/3] net: sched: ife: handle malformed tlv length
Date: Thu, 19 Apr 2018 08:09:39 -0400
Message-ID: <8bad9986-22fc-1301-c11d-512eb375404d@mojatatu.com>
References: <20180418213534.6215-1-aring@mojatatu.com>
 <20180418213534.6215-3-aring@mojatatu.com>
 <CANnrxJidq70VAmDza63cEkpd80c=VCxn6hg=m4Ko5oXYML82Ag@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, Cong Wang <xiyou.wangcong@gmail.com>,
        =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= <jiri@resnulli.us>,
        Yuval Mintz <yuvalm@mellanox.com>, netdev@vger.kernel.org,
        kernel@mojatatu.com
To: yotam gigi <yotam.gi@gmail.com>,
        Alexander Aring <aring@mojatatu.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it0-f67.google.com ([209.85.214.67]:36603 "EHLO
        mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751381AbeDSMJl (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 19 Apr 2018 08:09:41 -0400
Received: by mail-it0-f67.google.com with SMTP id e20-v6so1386315itc.1
        for <netdev@vger.kernel.org>; Thu, 19 Apr 2018 05:09:40 -0700 (PDT)
In-Reply-To: <CANnrxJidq70VAmDza63cEkpd80c=VCxn6hg=m4Ko5oXYML82Ag@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 19/04/18 01:37 AM, yotam gigi wrote:
> On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring <aring@mojatatu.com> wrote:
>> There is currently no handling to check on a invalid tlv length. This
>> patch adds such handling to avoid killing the kernel with a malformed
>> ife packet.
> 
> That's very important. Thanks for that!
> 
>>
>> Signed-off-by: Alexander Aring <aring@mojatatu.com>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal