From: Arnout Vandecappelle <arnout@mind.be>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/netsurf: use HOSTCC_NOCCACHE
Date: Thu, 21 Apr 2022 22:17:59 +0200 [thread overview]
Message-ID: <8bb8f809-cd50-32ae-f8e8-29ea40116288@mind.be> (raw)
In-Reply-To: <20220419132805.2571073-2-fontaine.fabrice@gmail.com>
On 19/04/2022 15:28, Fabrice Fontaine wrote:
> Use HOSTCC_NOCCACHE instead of HOSTCC to fix the following build
Rather than this workaround, let's fix the real issue.
The offending code is (I think, untested):
$(MAKE) install --directory=$1 HOST=$(BUILD) CC=$(BUILD_CC) ...
in top-level Makefile. Since BUILD_CC may contain spaces, this is going to be
parsed incorrectly by the shell. Just adding quotes should be enough.
Regards,
Arnout
> failure:
>
> /home/autobuild/autobuild/instance-11/output-1/build/netsurf-3.10/tmpusr/share/netsurf-buildsystem/makefiles/Makefile.tools:413: *** Unable to detect toolchain. Stop.
>
> Fixes:
> - http://autobuild.buildroot.org/results/b4ba19d7dcff1b0ee2b1546598b5ae6e9257a16d
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/netsurf/netsurf.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
> index 574c1423df..b61372bb78 100644
> --- a/package/netsurf/netsurf.mk
> +++ b/package/netsurf/netsurf.mk
> @@ -106,7 +106,7 @@ NETSURF_MAKE_OPTS = \
> BISON="$(HOST_DIR)/bin/bison" \
> FLEX="$(HOST_DIR)/bin/flex" \
> PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
> - BUILD_CC="$(HOSTCC)" \
> + BUILD_CC="$(HOSTCC_NOCCACHE)" \
> CC="$(TARGET_CC)" \
> AR="$(TARGET_AR)" \
> TMP_PREFIX=$(@D)/tmpusr \
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-04-21 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 13:28 [Buildroot] [PATCH 1/2] package/netsurf: fix build with BR2_OPTIMIZE_FAST Fabrice Fontaine
2022-04-19 13:28 ` [Buildroot] [PATCH 2/2] package/netsurf: use HOSTCC_NOCCACHE Fabrice Fontaine
2022-04-21 20:17 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bb8f809-cd50-32ae-f8e8-29ea40116288@mind.be \
--to=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.