From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752276AbeFEUz2 (ORCPT ); Tue, 5 Jun 2018 16:55:28 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:43303 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751919AbeFEUz0 (ORCPT ); Tue, 5 Jun 2018 16:55:26 -0400 X-Google-Smtp-Source: ADUXVKKFNmlwAxQb9IxaKPPJ2tBaQksOCVHZHe1rlK/6sW1lUcUsk1ke8fFwjaqoEqBj+w87Wmqh2A== Subject: Re: [PATCH 1/1] net: dsa: b53: Fix for brcm tag issue in Cygnus SoC To: Arun Parameswaran , Florian Fainelli , Vivien Didelot , Andrew Lunn , "David S. Miller" , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com References: <1528231092-31472-1-git-send-email-arun.parameswaran@broadcom.com> From: Scott Branden Message-ID: <8bb9ab39-a38b-9492-975e-d76c864ff8ff@broadcom.com> Date: Tue, 5 Jun 2018 13:55:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1528231092-31472-1-git-send-email-arun.parameswaran@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clement, Please test this works for your issue. On 18-06-05 01:38 PM, Arun Parameswaran wrote: > In the Broadcom Cygnus SoC, the brcm tag needs to be inserted > in between the mac address and the ether type (should use > 'DSA_PROTO_TAG_BRCM') for the packets sent to the internal > b53 switch. > > Since the Cygnus was added with the BCM58XX device id and the > BCM58XX uses 'DSA_PROTO_TAG_BRCM_PREPEND', the data path is > broken, due to the incorrect brcm tag location. > > Add a new b53 device id (BCM583XX) for Cygnus family to fix the > issue. Add the new device id to the BCM58XX family as Cygnus > is similar to the BCM58XX in most other functionalities. > > Fixes: 11606039604c ("net: dsa: b53: Support prepended Broadcom tags") > > Signed-off-by: Arun Parameswaran Acked-by: Scott Branden > --- > drivers/net/dsa/b53/b53_common.c | 15 ++++++++++++++- > drivers/net/dsa/b53/b53_priv.h | 2 ++ > drivers/net/dsa/b53/b53_srab.c | 4 ++-- > 3 files changed, 18 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c > index 3da5fca..bbc6cc6 100644 > --- a/drivers/net/dsa/b53/b53_common.c > +++ b/drivers/net/dsa/b53/b53_common.c > @@ -684,7 +684,8 @@ static int b53_switch_reset(struct b53_device *dev) > * still use this driver as a library and need to perform the reset > * earlier. > */ > - if (dev->chip_id == BCM58XX_DEVICE_ID) { > + if (dev->chip_id == BCM58XX_DEVICE_ID || > + dev->chip_id == BCM583XX_DEVICE_ID) { > b53_read8(dev, B53_CTRL_PAGE, B53_SOFTRESET, ®); > reg |= SW_RST | EN_SW_RST | EN_CH_RST; > b53_write8(dev, B53_CTRL_PAGE, B53_SOFTRESET, reg); > @@ -1880,6 +1881,18 @@ struct b53_chip_data { > .jumbo_size_reg = B53_JUMBO_MAX_SIZE, > }, > { > + .chip_id = BCM583XX_DEVICE_ID, > + .dev_name = "BCM583xx/11360", > + .vlans = 4096, > + .enabled_ports = 0x103, > + .arl_entries = 4, > + .cpu_port = B53_CPU_PORT, > + .vta_regs = B53_VTA_REGS, > + .duplex_reg = B53_DUPLEX_STAT_GE, > + .jumbo_pm_reg = B53_JUMBO_PORT_MASK, > + .jumbo_size_reg = B53_JUMBO_MAX_SIZE, > + }, > + { > .chip_id = BCM7445_DEVICE_ID, > .dev_name = "BCM7445", > .vlans = 4096, > diff --git a/drivers/net/dsa/b53/b53_priv.h b/drivers/net/dsa/b53/b53_priv.h > index 3b57f47..b232aaa 100644 > --- a/drivers/net/dsa/b53/b53_priv.h > +++ b/drivers/net/dsa/b53/b53_priv.h > @@ -62,6 +62,7 @@ enum { > BCM53018_DEVICE_ID = 0x53018, > BCM53019_DEVICE_ID = 0x53019, > BCM58XX_DEVICE_ID = 0x5800, > + BCM583XX_DEVICE_ID = 0x58300, > BCM7445_DEVICE_ID = 0x7445, > BCM7278_DEVICE_ID = 0x7278, > }; > @@ -181,6 +182,7 @@ static inline int is5301x(struct b53_device *dev) > static inline int is58xx(struct b53_device *dev) > { > return dev->chip_id == BCM58XX_DEVICE_ID || > + dev->chip_id == BCM583XX_DEVICE_ID || > dev->chip_id == BCM7445_DEVICE_ID || > dev->chip_id == BCM7278_DEVICE_ID; > } > diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c > index c37ffd1..8247481 100644 > --- a/drivers/net/dsa/b53/b53_srab.c > +++ b/drivers/net/dsa/b53/b53_srab.c > @@ -364,7 +364,7 @@ static int b53_srab_write64(struct b53_device *dev, u8 page, u8 reg, > { .compatible = "brcm,bcm53018-srab" }, > { .compatible = "brcm,bcm53019-srab" }, > { .compatible = "brcm,bcm5301x-srab" }, > - { .compatible = "brcm,bcm11360-srab", .data = (void *)BCM58XX_DEVICE_ID }, > + { .compatible = "brcm,bcm11360-srab", .data = (void *)BCM583XX_DEVICE_ID }, > { .compatible = "brcm,bcm58522-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { .compatible = "brcm,bcm58525-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { .compatible = "brcm,bcm58535-srab", .data = (void *)BCM58XX_DEVICE_ID }, > @@ -372,7 +372,7 @@ static int b53_srab_write64(struct b53_device *dev, u8 page, u8 reg, > { .compatible = "brcm,bcm58623-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { .compatible = "brcm,bcm58625-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { .compatible = "brcm,bcm88312-srab", .data = (void *)BCM58XX_DEVICE_ID }, > - { .compatible = "brcm,cygnus-srab", .data = (void *)BCM58XX_DEVICE_ID }, > + { .compatible = "brcm,cygnus-srab", .data = (void *)BCM583XX_DEVICE_ID }, > { .compatible = "brcm,nsp-srab", .data = (void *)BCM58XX_DEVICE_ID }, > { /* sentinel */ }, > };