From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C9CC43381 for ; Sun, 24 Mar 2019 08:42:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3638921019 for ; Sun, 24 Mar 2019 08:42:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fu4+wjsy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727852AbfCXImu (ORCPT ); Sun, 24 Mar 2019 04:42:50 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36465 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbfCXImu (ORCPT ); Sun, 24 Mar 2019 04:42:50 -0400 Received: by mail-wm1-f68.google.com with SMTP id h18so5977036wml.1 for ; Sun, 24 Mar 2019 01:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RdNkSf64nqjQ4TriHN1seg+GHffzmXgNgjkKBfdOoUk=; b=Fu4+wjsyOejH1zY9D/gK3fZoqz0+fB32DKvsb++FtORfgGUPay370Cw5CZinWKNLpX VwvmQ+gL3uZqCFNERzjrmEThd94ELII0+epbtCZXzmq3iG88s1qFeGmpCHAqX9/ZgfSZ pq48vwNl/Nr52UqrzuX+HkIwy5/e1KGIk0flPOf5fRwEOxNMOl0PnYC20yvOiScsgaRl hE4+m/MhvBvhWgx7OQd70dfyZumscrBH2vgBiyvtrgGyU6p8ibC0RcQuUSReuEltv30i xiTHYjEFzTqC9HZdq7SWuCBaBwKGfjNssmLqmInFDHUjonSyVKLUaYCa3vt8cCRnyCcO VH9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RdNkSf64nqjQ4TriHN1seg+GHffzmXgNgjkKBfdOoUk=; b=Vd79I4tQvM+xI2pG/jTq1QLbBv1dfDXv+lFiq7EHU/HgHQ6icVaKG+7d7Yh26d59Aq 0QX/sSdCxMK56Y33Bm4UG09zp7MUbpsy1TTg7uHIOauR9eYaNMrPSldJSuOxhGG69tjW 8mUtiAMHaB84pjQ7zBdfjQ15/luheB7r1oMBk+7O3sTNyx4SlRt9liu3YqOwgFslk5NP +wDOfmi+aafJ2Z1uetFvB9gNzDribWvsZMUmDKx6gOmlo8fJjdXDQ9cpGVRByXIgHjYc iu+tS9CZFsRlg0ZG66nWBUWDBzJP4HCX9TM96voMWRqt4PufJM11gYeW8jF4/Rwpccy7 8Ekw== X-Gm-Message-State: APjAAAWlazTUK/je0JXMy/9bTxypwG4Dt8ENDkWMbHfV4J/BYmIervPd 0DkeyZF7NwYPMO9q2Xtwg/OraFCv X-Google-Smtp-Source: APXvYqyocFHsFxxVBV+o7MNq14/jxmruirhZphpWc2GBxFFD2rg2kOmV4IKc6Uyqsuqf6bF3LMP/Bg== X-Received: by 2002:a1c:5546:: with SMTP id j67mr1885074wmb.95.1553416968526; Sun, 24 Mar 2019 01:42:48 -0700 (PDT) Received: from ?IPv6:2003:ea:8bc4:dc00:5ca8:2950:7dd3:94a3? (p200300EA8BC4DC005CA829507DD394A3.dip0.t-ipconnect.de. [2003:ea:8bc4:dc00:5ca8:2950:7dd3:94a3]) by smtp.googlemail.com with ESMTPSA id 7sm45263633wrc.81.2019.03.24.01.42.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 01:42:47 -0700 (PDT) Subject: Re: [PATCH net-next 1/3] net: phy: aquantia: report remote capabilities if link partner is Aquantia PHY To: Florian Fainelli , Andrew Lunn , David Miller Cc: "netdev@vger.kernel.org" References: <0e35a866-e3a5-6d49-2353-008f14ed6ff4@gmail.com> <265860ca-a5d0-e0f6-3caa-a300b35d2ded@gmail.com> From: Heiner Kallweit Message-ID: <8bbb67e3-de6b-2f8a-c4af-a98cfb7095e0@gmail.com> Date: Sun, 24 Mar 2019 09:42:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 24.03.2019 02:01, Florian Fainelli wrote: > > > On 3/23/2019 6:14 AM, Heiner Kallweit wrote: >> If both link partners are Aquantia PHY's then additional information is >> exchanged as part of the auto-negotiation. Report remote capabilities >> if link partner is Aquantia PHY. >> >> Signed-off-by: Heiner Kallweit > > Reviewed-by: Florian Fainelli > > Petr is trying to introduce a link down reason, but it sounds like we > should also have have a way to enhance the link up with information like > the one you are providing here. It would also be nice if in the future, > ethtool could display additional vendor specific information when the > link is up. ethtool over netlink should facilitate that. > Interesting idea. Most likely the available information will be quite different, dependent on the vendor. So the PHY driver may have to expose a list of items, each with a name and type. > Thanks! > Heiner