From: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
To: "Oliver O'Halloran" <oohall@gmail.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/rtasd: Improve unknown error logging
Date: Wed, 10 Oct 2018 11:19:18 +0530 [thread overview]
Message-ID: <8bbe34c0-a227-6213-55e9-7dbcccfe39c5@linux.vnet.ibm.com> (raw)
In-Reply-To: <20181010052302.18094-1-oohall@gmail.com>
On 10/10/2018 10:53 AM, Oliver O'Halloran wrote:
> Currently when we get an unknown RTAS event it prints the type as
> "Unknown" and no other useful information. Add the raw type code to the
> log message so that we have something to work off.
Yeah. Useful one.
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
-Vasant
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
> arch/powerpc/kernel/rtasd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/rtasd.c b/arch/powerpc/kernel/rtasd.c
> index 44d66c33d59d..6fafc82c04b0 100644
> --- a/arch/powerpc/kernel/rtasd.c
> +++ b/arch/powerpc/kernel/rtasd.c
> @@ -150,8 +150,10 @@ static void printk_log_rtas(char *buf, int len)
> } else {
> struct rtas_error_log *errlog = (struct rtas_error_log *)buf;
>
> - printk(RTAS_DEBUG "event: %d, Type: %s, Severity: %d\n",
> - error_log_cnt, rtas_event_type(rtas_error_type(errlog)),
> + printk(RTAS_DEBUG "event: %d, Type: %s (%d), Severity: %d\n",
> + error_log_cnt,
> + rtas_event_type(rtas_error_type(errlog)),
> + rtas_error_type(errlog),
> rtas_error_severity(errlog));
> }
> }
>
next prev parent reply other threads:[~2018-10-10 5:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 5:23 [PATCH] powerpc/rtasd: Improve unknown error logging Oliver O'Halloran
2018-10-10 5:49 ` Vasant Hegde [this message]
2018-10-15 4:01 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bbe34c0-a227-6213-55e9-7dbcccfe39c5@linux.vnet.ibm.com \
--to=hegdevasant@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.