From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAB1W-0002gf-0z for qemu-devel@nongnu.org; Mon, 15 May 2017 04:06:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAB1R-00027R-P8 for qemu-devel@nongnu.org; Mon, 15 May 2017 04:06:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36632) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dAB1R-00026w-Gr for qemu-devel@nongnu.org; Mon, 15 May 2017 04:06:29 -0400 References: <1494553288-30764-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> <1494553288-30764-2-git-send-email-zhangchen.fnst@cn.fujitsu.com> <80a52ceb-6e69-f4ee-04c7-1219bb7947c1@amsat.org> <11a77586-ec42-d1cd-f4d1-f7444cf5febb@cn.fujitsu.com> From: Jason Wang Message-ID: <8bc88f06-105e-db58-9a73-a0b76769ca64@redhat.com> Date: Mon, 15 May 2017 16:06:16 +0800 MIME-Version: 1.0 In-Reply-To: <11a77586-ec42-d1cd-f4d1-f7444cf5febb@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V4 01/12] net: Add vnet_hdr_len related arguments in NetClientState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu devel Cc: bian naimeng , "eddie . dong" , zhanghailiang , Li Zhijian , weifuqiang On 2017=E5=B9=B405=E6=9C=8815=E6=97=A5 14:56, Zhang Chen wrote: > > > On 05/15/2017 11:24 AM, Jason Wang wrote: >> >> >> On 2017=E5=B9=B405=E6=9C=8814=E6=97=A5 05:24, Philippe Mathieu-Daud=C3= =A9 wrote: >>> Hi Zhang >>> >>> On 05/11/2017 10:41 PM, Zhang Chen wrote: >>>> Add vnet_hdr_len and using_vnet_hdr arguments in NetClientState >>>> that make othermodule get real vnet_hdr_len easily. >>>> >>>> Signed-off-by: Zhang Chen >>>> --- >>>> include/net/net.h | 2 ++ >>>> net/net.c | 2 ++ >>>> 2 files changed, 4 insertions(+) >>>> >>>> diff --git a/include/net/net.h b/include/net/net.h >>>> index 99b28d5..70edfc0 100644 >>>> --- a/include/net/net.h >>>> +++ b/include/net/net.h >>>> @@ -100,6 +100,8 @@ struct NetClientState { >>>> unsigned int queue_index; >>>> unsigned rxfilter_notify_enabled:1; >>>> int vring_enable; >>>> + bool using_vnet_hdr; >>>> + int vnet_hdr_len; >>>> QTAILQ_HEAD(NetFilterHead, NetFilterState) filters; >>>> }; >>>> >>>> diff --git a/net/net.c b/net/net.c >>>> index 0ac3b9e..a00a0c9 100644 >>>> --- a/net/net.c >>>> +++ b/net/net.c >>>> @@ -472,6 +472,7 @@ void qemu_using_vnet_hdr(NetClientState *nc,=20 >>>> bool enable) >>>> return; >>>> } >>>> >>>> + nc->using_vnet_hdr =3D enable; >>>> nc->info->using_vnet_hdr(nc, enable); >>>> } >>>> >>>> @@ -491,6 +492,7 @@ void qemu_set_vnet_hdr_len(NetClientState *nc,=20 >>>> int len) >>>> return; >>>> } >>>> >>>> + nc->vnet_hdr_len =3D len; >>>> nc->info->set_vnet_hdr_len(nc, len); >>>> } >>>> >>> >>> For what it's worth, now having those fields in NetClientState it is=20 >>> possible to remove a deref to NetClientInfo in qemu_has_vnet_hdr()=20 >>> and qemu_has_vnet_hdr_len(). >>> >>> Anyway, >>> Reviewed-by: Philippe Mathieu-Daud=C3=A9 >>> >>> >> >> Yes and this could be done on top with removing private e.g=20 >> vnet_hdr_len. > > Do you means we will remove the qemu_has_vnet_hdr() and=20 > qemu_has_vnet_hdr_len() in the future? > > Thanks > Zhang Chen Yes and e.g both tap and netmap have its private vnet header field. We=20 can remove them too. Thanks > >> >> Thanks >> >> >> . >> >