All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaco Kroon <jaco@uls.co.za>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "chaitra.basappa@broadcom.com" <chaitra.basappa@broadcom.com>,
	"lkp@intel.com" <lkp@intel.com>,
	"kbuild-all@01.org" <kbuild-all@01.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Sathya.Prakash@broadcom.com" <Sathya.Prakash@broadcom.com>,
	"suganath-prabu.subramani@broadcom.com"
	<suganath-prabu.subramani@broadcom.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: *** SPAM *** Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static
Date: Tue, 10 Apr 2018 09:15:11 +0200	[thread overview]
Message-ID: <8be1199e-01bd-6fb3-7da5-4a488442331e@uls.co.za> (raw)
In-Reply-To: <yq1370jj278.fsf@oracle.com>

Hi Martin, Bart,

I've not seen additional feedback on this (I may simply not be CCed).

I've applied the patch to one of our hosts where we've had endless IO
lockups (with MQ enabled the host died within a day or two, sometimes
sub one hour, without it typically ran for about two weeks).  With this
patch (on top of 4.16) we're now at four days and 17 hours, with IO
still going strong (including a mdadm reshape to add a disk, as well as
a rebuild on a drive that failed - concurrently on two different arrays,
same controller).  Very subjective, but the host also feels more
responsive under heavy IO load.

What can I do from my side (I've got some development experience) to
help push this patch forward?

Kind Regards,
Jaco


On 28/03/2018 23:54, Martin K. Petersen wrote:
> Bart,
>
>> Are you aware that if the 0-day test infrastructure suggests an improvement
>> for a patch that the patch that that improvement applies to gets ignored
>> unless either the patch is reposted with the improvement applied or that it
>> is explained why the suggested improvement is inappropriate?
> Correct. I don't apply anything that causes a 0-day warning. The patch
> will be closed with "Changes Required" status in patchwork.
>
> Always build patch submissions to linux-scsi with:
>
> 	make C=1 CF="-D__CHECK_ENDIAN__"
>

  parent reply	other threads:[~2018-04-10  7:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 10:15 [PATCH] mpt3sas: Cache enclosure pages during enclosure add Chaitra P B
2018-03-20 21:06 ` kbuild test robot
2018-03-20 21:06   ` kbuild test robot
2018-03-20 21:06 ` [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static kbuild test robot
2018-03-20 21:06   ` kbuild test robot
2018-03-27 18:55   ` Bart Van Assche
2018-03-28 21:54     ` Martin K. Petersen
2018-03-28 21:54       ` Martin K. Petersen
2018-04-05 11:43       ` *** SPAM *** " Jaco Kroon
2018-04-10  7:15       ` Jaco Kroon [this message]
2018-04-10 12:46         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8be1199e-01bd-6fb3-7da5-4a488442331e@uls.co.za \
    --to=jaco@uls.co.za \
    --cc=Bart.VanAssche@wdc.com \
    --cc=Sathya.Prakash@broadcom.com \
    --cc=chaitra.basappa@broadcom.com \
    --cc=kbuild-all@01.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=martin.petersen@oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=suganath-prabu.subramani@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.