All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: <mst@redhat.com>, <kvm@vger.kernel.org>,
	<virtualization@lists.linux-foundation.org>,
	<jasowang@redhat.com>, <oren@nvidia.com>, <nitzanc@nvidia.com>
Subject: Re: [PATCH 1/3] virtio: update reset callback to return status
Date: Wed, 7 Apr 2021 17:35:29 +0300	[thread overview]
Message-ID: <8be467dc-8920-05d0-4d6d-9c61fe721120@nvidia.com> (raw)
In-Reply-To: <20210407154444.04d6304b.cohuck@redhat.com>


On 4/7/2021 4:44 PM, Cornelia Huck wrote:
> On Wed, 7 Apr 2021 12:09:22 +0000
> Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
>
>> The reset device operation, usually is an operation that might fail from
>> various reasons. For example, the controller might be in a bad state and
>> can't answer to any request. Usually, the paravirt SW based virtio
>> devices always succeed in reset operation but this is not the case for
>> HW based virtio devices.
>>
>> This commit is also a preparation for adding a timeout mechanism for
>> resetting virtio devices.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>>   drivers/remoteproc/remoteproc_virtio.c |  3 ++-
>>   drivers/virtio/virtio.c                | 22 +++++++++++++++-------
>>   drivers/virtio/virtio_mmio.c           |  3 ++-
>>   drivers/virtio/virtio_pci_legacy.c     |  3 ++-
>>   drivers/virtio/virtio_pci_modern.c     |  3 ++-
>>   drivers/virtio/virtio_vdpa.c           |  3 ++-
>>   include/linux/virtio_config.h          |  5 +++--
>>   7 files changed, 28 insertions(+), 14 deletions(-)
> You missed drivers/s390/virtio/virtio_ccw.c.
>
> virtio_ccw_reset() should probably return -ENOMEM on allocation failure
> and forward the return code of ccw_io_helper().

thanks, I found another 1-2 places that I missed. I'll update in v2.


  reply	other threads:[~2021-04-07 14:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 12:09 [PATCH 1/3] virtio: update reset callback to return status Max Gurtovoy
2021-04-07 12:09 ` [PATCH 2/3] virito_pci: add timeout to reset device operation Max Gurtovoy
2021-04-07 13:45   ` Michael S. Tsirkin
2021-04-07 13:45     ` Michael S. Tsirkin
2021-04-07 14:06     ` Max Gurtovoy
2021-04-07 12:09 ` [PATCH 3/3] virtio_pci: add module param for reset_timeout Max Gurtovoy
2021-04-07 13:44 ` [PATCH 1/3] virtio: update reset callback to return status Cornelia Huck
2021-04-07 13:44   ` Cornelia Huck
2021-04-07 14:35   ` Max Gurtovoy [this message]
2021-04-07 17:51 ` kernel test robot
2021-04-07 17:51   ` kernel test robot
2021-04-07 17:51   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8be467dc-8920-05d0-4d6d-9c61fe721120@nvidia.com \
    --to=mgurtovoy@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=nitzanc@nvidia.com \
    --cc=oren@nvidia.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.