From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9FF9C433FE for ; Thu, 12 May 2022 14:12:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355077AbiELOMF (ORCPT ); Thu, 12 May 2022 10:12:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355074AbiELOL5 (ORCPT ); Thu, 12 May 2022 10:11:57 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B7F6212A for ; Thu, 12 May 2022 07:11:51 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id r188-20020a1c44c5000000b003946c466c17so2584564wma.4 for ; Thu, 12 May 2022 07:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=SRwpNt4DH8DqblGWpeI/m6J/HBl7UK2S+eeIMKh0Tkc=; b=vRz7pNegaN7s9ys9HBCJZgVKbR7C5L5hdBVEje78wDlPADH7OwcoBwoJe5pSSFdPSW wQJPQ8btIA1ek+0e3nSIOG4/saxP04npfrnUgaRlbMROopUfJYN1YK9a7tTqYLEoT9C4 MMdralMo+iefdxRWSMpSIuXOSjzIQv/refS4Pm1xmr3ukOSXv/8QglMGSh/wLO+QSWd4 Qw+fNNaJXTH9zoZH7LidmmPy+YNNQX1qDNULasFY9OMpl7hIvDKeIt4Ti/irDm1nO2h3 GTodUdX+gSH+/cGGqpsZ2T6aHaQjGfX2p4nxbRG7zX3+jMk92Mbjvqz9vcx51QnIMtl/ LX5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SRwpNt4DH8DqblGWpeI/m6J/HBl7UK2S+eeIMKh0Tkc=; b=63jcZC2uPmU2/LUdHockHMHu0rH86eld3x7MXKVjSnsYNW7ymwi9SfOKE8IQZa1XLS niJqfZOlLQNQA1XXFGrv3eTaqlwpi7BhpT2wPdwqrl207cxTSCAgPddYvQL2ccsr92q6 6b6ACJbfV7oD+DkwTIP8SufeOpmaEXCpDIWERc3Npb/TTtiL6TDKO6kgKnfcEDVIAclH 8JLwuiI0Axpb3BhLJsQs1/AHFP/n4Qt1Irtrj0LlrEt3g6F7o03JzEdJEVJh1uWe/4F1 Otim8pTf5nV9Lpr1HVg47pdjESjGpNdmMPhpoTi7GHm8O959065iOFHinMcOgSZ5lzwj pmDQ== X-Gm-Message-State: AOAM530N2/CeFao6u1NCz4UYS+wD1++tGmdigUErIG1hjzW2NQWCbDAw 81PYaG8BYttWpniC6VvFS6amnw== X-Google-Smtp-Source: ABdhPJxbXnBKFPQ09ZKP2iaCL8DUkX2cQXFCc0U3GkQ6NUUF3YBxMC4DeHvJ+itvzyH5DnaZCjP1Bw== X-Received: by 2002:a05:600c:4f95:b0:394:8919:7557 with SMTP id n21-20020a05600c4f9500b0039489197557mr3001wmq.166.1652364709980; Thu, 12 May 2022 07:11:49 -0700 (PDT) Received: from [192.168.0.160] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id w9-20020a5d4049000000b0020c5253d8cfsm5165586wrp.27.2022.05.12.07.11.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 07:11:49 -0700 (PDT) Message-ID: <8be62b40-077a-7634-7d34-7776909a2abe@linaro.org> Date: Thu, 12 May 2022 16:11:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH V4 0/5] Add initial support for MA35D1 SoC Content-Language: en-US To: Arnd Bergmann , Jacky Huang Cc: Linux Kernel Mailing List , DTML , linux-clk , Linux ARM , ychuang570808@gmail.com, Rob Herring , Stephen Boyd , Krzysztof Kozlowski , Olof Johansson , Catalin Marinas , Will Deacon , SoC Team , cfli0@nuvoton.com References: <20220510032558.10304-1-ychuang3@nuvoton.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2022 09:07, Arnd Bergmann wrote: > On Tue, May 10, 2022 at 5:25 AM Jacky Huang wrote: >> >> This patch series adds initial support for Nuvoton MA35D1 SoC, >> include initial dts and clock controller binding. >> > > This looks fine in principle, but we are getting close to the merge window and > should finalize this quickly to make it into v5.19. I see that you don't have a > console device, as commented in the .dts patch. Normally I prefer merging > platforms only when there is at least rudimentary support for booting into > an initramfs with a serial console, but this is a flexible rule. I disagree. It does not look fine - does not pass `make dtbs_check` even with Nuvoton bindings... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C07D8C433F5 for ; Thu, 12 May 2022 14:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=knZ0E4GWw6YjZuZ8PKYBZnwpiLoEebmOgRRRJaai0Zk=; b=zmjFrc8mrZ2fi2 4RNOc1Z+MrsviclxXErNm3x4DrsBasebqYUVz+Psygsl7l2eRFbSOlgzpyVmxeHWfZj6o7KWg9rBG 6qNwS1lOenLnITJnoGGX9B+I7QCzt4pysyIb5ob7n+WhQ+Fse5m7smEkXAbX3cVv/0ld/Kki/gIz0 VP1VZVkwJwEGuCOdeDnhgD4nngobG1v2W9x60Dsxkbv+7LbeFjJIhjoBtwmqNENYpDQvFIfG2m3+9 aTA9NuCSnShbMODII6guZoQMxeYh581XW2i0LRRFADYm7xLmHGDknDwI8149GqblqPo93lFa2UlZr 8PukI9VSaeANgaFCwHjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1np9Xo-00CH3U-TN; Thu, 12 May 2022 14:11:57 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1np9Xk-00CH00-Ux for linux-arm-kernel@lists.infradead.org; Thu, 12 May 2022 14:11:54 +0000 Received: by mail-wm1-x334.google.com with SMTP id bg25so3099738wmb.4 for ; Thu, 12 May 2022 07:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=SRwpNt4DH8DqblGWpeI/m6J/HBl7UK2S+eeIMKh0Tkc=; b=vRz7pNegaN7s9ys9HBCJZgVKbR7C5L5hdBVEje78wDlPADH7OwcoBwoJe5pSSFdPSW wQJPQ8btIA1ek+0e3nSIOG4/saxP04npfrnUgaRlbMROopUfJYN1YK9a7tTqYLEoT9C4 MMdralMo+iefdxRWSMpSIuXOSjzIQv/refS4Pm1xmr3ukOSXv/8QglMGSh/wLO+QSWd4 Qw+fNNaJXTH9zoZH7LidmmPy+YNNQX1qDNULasFY9OMpl7hIvDKeIt4Ti/irDm1nO2h3 GTodUdX+gSH+/cGGqpsZ2T6aHaQjGfX2p4nxbRG7zX3+jMk92Mbjvqz9vcx51QnIMtl/ LX5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SRwpNt4DH8DqblGWpeI/m6J/HBl7UK2S+eeIMKh0Tkc=; b=efYoX8CCtzyhnPKLbYiMkNULKS840/ieKWjEuLYd851u8umg0C8RHCjxx8TZnTBjPy jE3m6jAFGDqaUHqMVYW8rRxn3FH293OF+QsnGLiCwaiMrP8kkKlUaJK710USbQgm4IfX m0bnPZrwm2c9uvBFQ760DjD54yCORW9iQqLJ92ZoCEGf5Ct+ALMtuFYYgunN6pU0fBCE PYy5Ep5PwuiwEiO2PrfaJS20VpmZFDFpFjy1qjdt/9vsVq2Y48JYlCUqszj7U+YiF0m2 w6pEaszN8Rc73LAfZ/8LHHKMpCRHdMGAHTmxLDn+5/QKoaBwUywsohJAobf10wVkLfnM 5Fbw== X-Gm-Message-State: AOAM53351neQu2ig4BoTj8aNz4EyRHcQIUHCNf5owychZ+SK/WI3EUf1 TXsVCLSAR80U2mrtpK0U+EW1EA== X-Google-Smtp-Source: ABdhPJxbXnBKFPQ09ZKP2iaCL8DUkX2cQXFCc0U3GkQ6NUUF3YBxMC4DeHvJ+itvzyH5DnaZCjP1Bw== X-Received: by 2002:a05:600c:4f95:b0:394:8919:7557 with SMTP id n21-20020a05600c4f9500b0039489197557mr3001wmq.166.1652364709980; Thu, 12 May 2022 07:11:49 -0700 (PDT) Received: from [192.168.0.160] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id w9-20020a5d4049000000b0020c5253d8cfsm5165586wrp.27.2022.05.12.07.11.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 07:11:49 -0700 (PDT) Message-ID: <8be62b40-077a-7634-7d34-7776909a2abe@linaro.org> Date: Thu, 12 May 2022 16:11:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH V4 0/5] Add initial support for MA35D1 SoC Content-Language: en-US To: Arnd Bergmann , Jacky Huang Cc: Linux Kernel Mailing List , DTML , linux-clk , Linux ARM , ychuang570808@gmail.com, Rob Herring , Stephen Boyd , Krzysztof Kozlowski , Olof Johansson , Catalin Marinas , Will Deacon , SoC Team , cfli0@nuvoton.com References: <20220510032558.10304-1-ychuang3@nuvoton.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220512_071153_031516_7EEB576B X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/05/2022 09:07, Arnd Bergmann wrote: > On Tue, May 10, 2022 at 5:25 AM Jacky Huang wrote: >> >> This patch series adds initial support for Nuvoton MA35D1 SoC, >> include initial dts and clock controller binding. >> > > This looks fine in principle, but we are getting close to the merge window and > should finalize this quickly to make it into v5.19. I see that you don't have a > console device, as commented in the .dts patch. Normally I prefer merging > platforms only when there is at least rudimentary support for booting into > an initramfs with a serial console, but this is a flexible rule. I disagree. It does not look fine - does not pass `make dtbs_check` even with Nuvoton bindings... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel