From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D7BC433F5 for ; Wed, 9 Mar 2022 17:10:51 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1A3540395; Wed, 9 Mar 2022 18:10:50 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id 587574013F for ; Wed, 9 Mar 2022 18:10:48 +0100 (CET) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 229FZIIU025703; Wed, 9 Mar 2022 17:10:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=DyNOC4nnqfUKUUQbDgxcQny6ZLDJGmQcCtFhk1T8ZE8=; b=Py0eZpUgFB6FjZQUMKTESy6haI+sXJPUFRORVgjsoeQKUKdy2bqXih+8046SOhX3bXg+ qoyZBjIuZ//DMZSSW404QaHdXtbtsg3Z4r3W0IHg4o8mrrUenfWxM+hyb8osBZS3ETIk bW3c1cogJ8xPYI3JZ8L6kztfWckRWac6IeCPcXqS98qd6li6dMG8oducP49JFcnLxcBT BuFSTn3CsqQcrBjn+5Mpc72l0oih9USd6ywbZDSvlE1Ka5QfhyxpgQqQNAFwbXJ4Wea8 Y9znhWokJutAqBxHTuudcg7iISFso9IjVMOCFS0fw+pUszdI5HknxmeFtLM0UF8GELn9 NQ== Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 3enx3n2kqy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Mar 2022 17:10:45 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 229H8J2V005149; Wed, 9 Mar 2022 17:10:44 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma03wdc.us.ibm.com with ESMTP id 3epwg614jp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Mar 2022 17:10:44 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 229HAggt21561794 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Mar 2022 17:10:42 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1078078067; Wed, 9 Mar 2022 17:10:42 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E69A378068; Wed, 9 Mar 2022 17:10:40 +0000 (GMT) Received: from [9.65.64.203] (unknown [9.65.64.203]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 9 Mar 2022 17:10:40 +0000 (GMT) Message-ID: <8bef73fa-9fa3-183a-74b9-2b1c9ac238f0@linux.vnet.ibm.com> Date: Wed, 9 Mar 2022 11:10:39 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl Content-Language: en-US To: Slava Ovsiienko , Raslan Darawsheh , Dmitry Kozlyuk Cc: "dev@dpdk.org" , "drc@linux.vnet.ibm.com" References: <20220308122315.890063-1-dkozlyuk@nvidia.com> From: Thinh Tran In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: z_ey5WBsLwCHBwDWtXzr4AfFQFa9_SgH X-Proofpoint-GUID: z_ey5WBsLwCHBwDWtXzr4AfFQFa9_SgH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-09_07,2022-03-09_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1011 impostorscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 mlxlogscore=810 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203090096 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On 3/9/2022 2:50 AM, Slava Ovsiienko wrote: > Hi, Thinh > > Thank you for the patch, the code looks OK to me, but commit message is not compliant: > - it should contain "fix" keyword in the title, like this: > "net/mlx5: fix CPU socket ID for Rx queue creation" > - could you, please, make problem description less personal and less wordy? > "The default CPU socket ID was used while creating the Rx queue and this caused > creation failure in case if hardware was not resided on the default socket. > > The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before > calling the mlx5_rxq_create_devx_rq_resources() which eventually calls > mlx5_devx_rq_create() with correct CPU socket ID." > - please add tags: > Cc: stable@dpdk.org > Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX") > > With best regards, > Slava > I'll resubmit the patch with suggestions above. Regards, Thinh >> -----Original Message----- >> From: Raslan Darawsheh >> Sent: Tuesday, March 8, 2022 14:25 >> To: Dmitry Kozlyuk >> Cc: Thinh Tran ; dev@dpdk.org; >> drc@linux.vnet.ibm.com >> Subject: RE: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl >> >> >>> -----Original Message----- >>> From: Dmitry Kozlyuk >>> Sent: Tuesday, March 8, 2022 2:23 PM >>> To: Raslan Darawsheh >>> Cc: Thinh Tran ; dev@dpdk.org; >>> drc@linux.vnet.ibm.com >>> Subject: Re: [PATCH] net/mlx5: set correct CPU socket ID for >>> mlx5_rxq_ctrl >>> >>> Hi Raslan, >>> >>>> Missing: >>>> Fixes tag: >>>> >>>> Fixes: 5ceb3a02b000 ("net/mlx5: move Rx queue DevX resource") >>>> Cc: xuemingl@nvidia.com >>> >>> I believe the bug originates from my earlier commit, not Xueming's one: >>> >>> Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX") >> Yes I think you are correct, my mistake 😊 >> >> Kindest regards, >> Raslan Darawsheh