From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buYR5-0000Eh-GF for qemu-devel@nongnu.org; Thu, 13 Oct 2016 01:20:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buYR1-0001OR-0Y for qemu-devel@nongnu.org; Thu, 13 Oct 2016 01:20:06 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57687 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buYR0-0001O8-RZ for qemu-devel@nongnu.org; Thu, 13 Oct 2016 01:20:02 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9D5Ipua003795 for ; Thu, 13 Oct 2016 01:20:02 -0400 Received: from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158]) by mx0b-001b2d01.pphosted.com with ESMTP id 261x05v30d-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 13 Oct 2016 01:20:02 -0400 Received: from localhost by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Oct 2016 23:20:01 -0600 References: <20160928204644.11523-1-mreitz@redhat.com> <1b3f7281-eaa6-586b-0f3c-f30cebf88322@linux.vnet.ibm.com> <59343543-96c7-ebc1-5889-7259df3a2c90@redhat.com> From: Hao QingFeng Date: Thu, 13 Oct 2016 13:20:12 +0800 MIME-Version: 1.0 In-Reply-To: <59343543-96c7-ebc1-5889-7259df3a2c90@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <8bf56524-e566-85a2-3cde-b503e178b8e9@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Sascha Silbe , qemu-devel@nongnu.org, Stefan Hajnoczi , Liu Jing , Christian Borntraeger , Cornelia Huck =E5=9C=A8 2016-10-13 3:46, Max Reitz =E5=86=99=E9=81=93: > On 12.10.2016 10:55, Hao QingFeng wrote: >> Max, >> >> Just a common question for this case, if sshx block driver wasn't buil= t >> into qemu-img, this case would fail as below: > Good point, and thanks for bringing it up, but it's not directly linked > to this series other than by its subject, of course, so I'd rather add = a > fix on top. Thanks and sorry for sending to the improper mail series. >> exec /home/haoqf/KVMonz/qemu/tests/qemu-iotests/../../qemu-img info >> --image-opts driver=3Dssh,host=3Dlocalhost,port=3D0.42,path=3D/foo >> qemu-img: Could not open >> 'driver=3Dssh,host=3Dlocalhost,port=3D0.42,path=3D/foo': Unknown drive= r 'ssh' >> >> Adding 162.notrun can bypass this case but it would skip it even if >> qemu-img has sshx block driver, in which case I think it should be run. >> >> So How about adding a script to dynamically check at runtime if the >> current env qemu-img can meet the requirement to run the test or not? > Unfortunately, the list of block drivers listed by will not contain ssh > if ssh is built as a module, which is possible. Actually I am not sure if I understood it. Do you mean=20 "CONFIG_LIBSSH2=3Dm" set rather than "CONFIG_LIBSSH2=3Dy" in config-host.mak? But in the configure= it's set to be "CONFIG_LIBSSH2=3Dy": if test "$libssh2" =3D "yes" ; then echo "CONFIG_LIBSSH2=3Dy" >> $config_host_mak echo "LIBSSH2_CFLAGS=3D$libssh2_cflags" >> $config_host_mak echo "LIBSSH2_LIBS=3D$libssh2_libs" >> $config_host_mak fi Meanwhile I changed it to be "CONFIG_LIBSSH2=3Dm" and reconfig, make the = qemu, qemu-img --help can still prompt ssh. > This is a bug that should be fixed, but I'd rather do so in a separate > series from this one. > > In any case, once it is fixed I'd rather just take the approach quorum > tests take already (e.g. test 081), which is something like: > > test_ssh=3D$($QEMU_IMG --help | grep '^Supported formats:.* ssh\( \|$\)= ') > [ "$test_ssh" =3D "" ] && _notrun "ssh support required" Cool. Agree with this like what was done in 081. thanks > Max > --=20 QingFeng Hao