From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12B7C433EF for ; Thu, 2 Jun 2022 22:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239853AbiFBW7h (ORCPT ); Thu, 2 Jun 2022 18:59:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiFBW7f (ORCPT ); Thu, 2 Jun 2022 18:59:35 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 74CA21E3E1 for ; Thu, 2 Jun 2022 15:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654210773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vtC3/HRoHB3wvoKqlgfwWmQAUyakQjajXqU9GRPpbI8=; b=gUVDFFvDkE3fEyAMkY89XuQsUmnSCa7bEB/PYbykM71/2H4Nb8OSzXZ1Nph4x7JwF0sKkq ZO1yTjaqu+jzGVcQYuY/SQlCbhs+ecGxr8knBnGJ8GfbUEPrVSQn+fwI7B5mlhBisSjAf9 tyUv5N4QJi0raudQ1kUGJIFaFPqdm8g= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-314-JW7WW13kMKeGg5269UCvqw-1; Thu, 02 Jun 2022 18:59:25 -0400 X-MC-Unique: JW7WW13kMKeGg5269UCvqw-1 Received: by mail-wm1-f70.google.com with SMTP id az7-20020a05600c600700b0039c3ed7fa89so42385wmb.8 for ; Thu, 02 Jun 2022 15:59:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vtC3/HRoHB3wvoKqlgfwWmQAUyakQjajXqU9GRPpbI8=; b=EvOzk0u8qzidjdZmX+6ck/XjIg159f2c80frbkDMsmXMY47X+Din/C5OCZ+nSUve+G LGpPE4/BTC82UNjs4SNJe1sRZQMF01jTJHHu0Cg1TWYX9uOZaa99uGVXU70rk65OPAuL /zEtN2Um+4rgUqHCntNOw4d/QVrEayHlfLNetzGLwWLs/g1+Cc8TAAuVlFz9dXBBDuQT ik4IlZbgq1Yn4YH7EeEMDO/iF1caS6WTNOsuauOlNrH4PbIdis+juyPL3qXW1RwSA5Bl iPAenu0gM6PIYE5iUzaa693oo+4WEbj/DPdO0iRecDpWv4P4FhVASz8Iic29t4P7ldkK jHXA== X-Gm-Message-State: AOAM533t+IriiU8b3AbfpyGmvZY7IDdu8/zuibHe9BZYJbqyrXPzHQ7d oj6ky6YvWAMAfobie7iq6DfhDyOmdK+8DaqJ5pziqikjopQLzhwZTAlfOHwbjAB8XSq0zyQGcYi OYXVcbrjkydZoIVFEQjrVKw== X-Received: by 2002:adf:f6d2:0:b0:211:f0bf:3d14 with SMTP id y18-20020adff6d2000000b00211f0bf3d14mr5614280wrp.264.1654210763874; Thu, 02 Jun 2022 15:59:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKYdxQ6DSZ5lIk0yCb5r+1V1zpn+ZtWuF/mSEGqRZpplstmUUWsmoOJ05Vk6poEXASLfJruQ== X-Received: by 2002:adf:f6d2:0:b0:211:f0bf:3d14 with SMTP id y18-20020adff6d2000000b00211f0bf3d14mr5614261wrp.264.1654210763679; Thu, 02 Jun 2022 15:59:23 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id l9-20020a7bc349000000b0039746638d6esm6535821wmj.33.2022.06.02.15.59.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 15:59:23 -0700 (PDT) Message-ID: <8c000696-256b-e99d-0cf7-7cd28602c6a9@redhat.com> Date: Fri, 3 Jun 2022 00:59:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code Content-Language: en-US To: Peter Robinson , Arnd Bergmann , bcm-kernel-feedback-list@broadcom.com, Daniel Vetter , David Airlie , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Emma Anholt , Florian Fainelli , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, maxime@cerno.tech, Nicolas Saenz Julienne , Rob Herring , Stefan Wahren , Catalin Marinas , Will Deacon Cc: Nicolas Saenz Julienne References: <20220601110249.569540-1-pbrobinson@gmail.com> <20220601110249.569540-3-pbrobinson@gmail.com> From: Javier Martinez Canillas In-Reply-To: <20220601110249.569540-3-pbrobinson@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 6/1/22 13:02, Peter Robinson wrote: > Runtime PM doesn't seem to work correctly on this driver. On top of > that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static > variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the > driver's PM ops were not hooked-up. > > So, in order to support regular operation with V3D on BCM2711 (Raspberry > Pi 4), get rid of the PM code. PM will be reinstated once we figure out > the underlying issues. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > --- This makes sense to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05A13C43334 for ; Thu, 2 Jun 2022 23:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gKqw50X261jzgF+ZPd5w0stpncsgAQILPZAq6FqUQRw=; b=NbFFN4t0VmGeUm VlY6PbIM3mwg7LbcsAV07jNHThZE27C5851mdOk7eeKz8n59eSC2HeWmvYwuFtOH3jPNmGPMe31gM GAlziR0hHJqlTS/QVA9WzfMUyJweiLnjhRMzIJjOSxjKgIF5i7EEVMhNqvhcBz+R9NjQWCwkj+CwG /mjnuyL9ZS964DbBSzfzlTsPwMNqSI30nbVAvXzjEoszDOo26upw1viQxWshthWjvfrI8a8bD/2oX w591CzocJejcyR2I4/1xvl1x7USRvkNXsAG1Xv0ahSz0LbOsuw5Q+uudmHr6TqxPZe5B6G+es7jiK PvXJbiLzL0001SEpA1lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwtms-0054ZP-Pd; Thu, 02 Jun 2022 22:59:30 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwtmp-0054Y4-Eu for linux-arm-kernel@lists.infradead.org; Thu, 02 Jun 2022 22:59:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654210766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vtC3/HRoHB3wvoKqlgfwWmQAUyakQjajXqU9GRPpbI8=; b=XZ3UTGEN1X6vb3NKuUKfdWSGz4vCCfo6jImNa/BOs/usi9Bun9eJG6Mws9cOCeQHOJBvsW jEhgH8EJwnnRmwUGwYT1JOtSdqNKHowJhqbRw6Qvl2qzGwPA0uWw9LSTVaLIesZAolTwRa nb2qdhkIXTk8m+LwnZWGpADU/KaR83A= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-301-ALYQReB9P-WbqQi1HFSoGw-1; Thu, 02 Jun 2022 18:59:25 -0400 X-MC-Unique: ALYQReB9P-WbqQi1HFSoGw-1 Received: by mail-wm1-f72.google.com with SMTP id az7-20020a05600c600700b0039c3ed7fa89so42386wmb.8 for ; Thu, 02 Jun 2022 15:59:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vtC3/HRoHB3wvoKqlgfwWmQAUyakQjajXqU9GRPpbI8=; b=tUUq479uQiBmlmVMDTIfJdsvWw2T0MNgcmm7Th60vzV8YCRYcoP2xpLoWzOqj8vJk3 /a3zjljtLDyXq7wiblvznt0cbcS9MO06+QqnHmbTQK1EpZiCnN0wWxmAHXwm403oQXLy UHQSyvgjLlyPKzzxXX/kC+Q5OpD6Ts/GOVi5e3fAcw+ZLWT6tOQMbaj6DD2szSQgJT0f k4F3m0GmYn/tzxXVBQMsTE/p5UOf/gHI6IHlHPDIZbuSgaU+KYC2rCd6QW1ZDQeH7q/l rdPyESnNZmjMS5whdlsOezOWC6NEduD0FrRxhJx0GDN2Sr3N0XrLHLcLOzMY+croqm5o E88Q== X-Gm-Message-State: AOAM531B0mCFewe/J8htAtdnbyCSomhsfkfGXg2tu2ORkM6HvZeq211A xrXH5VszIF8QAGmqcIc2LV6bPWuluoZxJeP7++QWgDdjTYn5GDwcFfL3Snp7dmCeNeVEJUeUCpV gst+AmQtyuvwOtg0bbI+L5KY/syQOma0niF0= X-Received: by 2002:adf:f6d2:0:b0:211:f0bf:3d14 with SMTP id y18-20020adff6d2000000b00211f0bf3d14mr5614276wrp.264.1654210763873; Thu, 02 Jun 2022 15:59:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKYdxQ6DSZ5lIk0yCb5r+1V1zpn+ZtWuF/mSEGqRZpplstmUUWsmoOJ05Vk6poEXASLfJruQ== X-Received: by 2002:adf:f6d2:0:b0:211:f0bf:3d14 with SMTP id y18-20020adff6d2000000b00211f0bf3d14mr5614261wrp.264.1654210763679; Thu, 02 Jun 2022 15:59:23 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id l9-20020a7bc349000000b0039746638d6esm6535821wmj.33.2022.06.02.15.59.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 15:59:23 -0700 (PDT) Message-ID: <8c000696-256b-e99d-0cf7-7cd28602c6a9@redhat.com> Date: Fri, 3 Jun 2022 00:59:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code To: Peter Robinson , Arnd Bergmann , bcm-kernel-feedback-list@broadcom.com, Daniel Vetter , David Airlie , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Emma Anholt , Florian Fainelli , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, maxime@cerno.tech, Nicolas Saenz Julienne , Rob Herring , Stefan Wahren , Catalin Marinas , Will Deacon Cc: Nicolas Saenz Julienne References: <20220601110249.569540-1-pbrobinson@gmail.com> <20220601110249.569540-3-pbrobinson@gmail.com> From: Javier Martinez Canillas In-Reply-To: <20220601110249.569540-3-pbrobinson@gmail.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_155927_623295_1ADC2F24 X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/1/22 13:02, Peter Robinson wrote: > Runtime PM doesn't seem to work correctly on this driver. On top of > that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static > variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the > driver's PM ops were not hooked-up. > > So, in order to support regular operation with V3D on BCM2711 (Raspberry > Pi 4), get rid of the PM code. PM will be reinstated once we figure out > the underlying issues. > > Signed-off-by: Nicolas Saenz Julienne > Signed-off-by: Peter Robinson > --- This makes sense to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel