From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Hankland <ehankland@google.com>
Cc: Wei Wang <wei.w.wang@intel.com>,
rkrcmar@redhat.com, linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: PMU Event Filter
Date: Thu, 11 Jul 2019 19:12:17 +0200 [thread overview]
Message-ID: <8c0502f4-64eb-3d34-1d76-a313b8f2f37a@redhat.com> (raw)
In-Reply-To: <CAOyeoRVrXjdywi-00ZafkVtEb_x6f5ZEmdMqq6v67XMedv_LKQ@mail.gmail.com>
On 11/07/19 19:04, Eric Hankland wrote:
> Thanks for your help. The "type"->"action" change and constant
> renaming sound good to me.
Good! Another thing, synchronize_rcu is a bit slow for something that
runs whenever a VM starts. KVM generally uses srcu instead (kvm->srcu
for things that change really rarely, kvm->irq_srcu for things that
change a bit more often).
Paolo
> On Thu, Jul 11, 2019 at 4:58 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 11/07/19 03:25, Eric Hankland wrote:
>>> - Add a VM ioctl that can control which events the guest can monitor.
>>
>> ... and finally:
>>
>> - the patch whitespace is damaged
>>
>> - the filter is leaked when the VM is destroyed
>>
>> - kmalloc(GFP_KERNEL_ACCOUNT) is preferrable to vmalloc because it
>> accounts memory to the VM correctly.
>>
>> Since this is your first submission, I have fixed up everything.
>>
>> Paolo
next prev parent reply other threads:[~2019-07-11 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 1:25 [PATCH v2] KVM: x86: PMU Event Filter Eric Hankland
2019-07-11 11:22 ` Paolo Bonzini
2019-07-11 11:58 ` Paolo Bonzini
2019-07-11 17:04 ` Eric Hankland
2019-07-11 17:12 ` Paolo Bonzini [this message]
2019-07-12 3:27 ` Wei Wang
2019-07-16 0:10 ` Eric Hankland
2019-07-16 8:49 ` Wei Wang
2019-07-17 10:22 ` Paolo Bonzini
2019-07-17 17:05 ` Eric Hankland
2019-07-17 17:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c0502f4-64eb-3d34-1d76-a313b8f2f37a@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehankland@google.com \
--cc=eranian@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.