From: Michal Orzel <michal.orzel@arm.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 5/9] include/public: Use explicitly specified types
Date: Wed, 22 Jun 2022 12:56:59 +0200 [thread overview]
Message-ID: <8c1a2037-1bdc-cdb8-7c57-5e84448cc1d0@arm.com> (raw)
In-Reply-To: <386e765e-8bb8-32a0-9170-11db3978a17a@suse.com>
On 22.06.2022 12:16, Jan Beulich wrote:
> On 20.06.2022 09:02, Michal Orzel wrote:
>> --- a/xen/include/public/physdev.h
>> +++ b/xen/include/public/physdev.h
>> @@ -211,8 +211,8 @@ struct physdev_manage_pci_ext {
>> /* IN */
>> uint8_t bus;
>> uint8_t devfn;
>> - unsigned is_extfn;
>> - unsigned is_virtfn;
>> + unsigned int is_extfn;
>> + unsigned int is_virtfn;
>
> It is wrong for us to use unsigned (or unsigned int) here and in sysctl.h.
> It should be uint32_t instead, and I think this is a great opportunity to
> correct that mistake.
>
That is perfectly fine for me to do.
> Jan
Cheers,
Michal
next prev parent reply other threads:[~2022-06-22 10:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 7:02 [PATCH 0/9] MISRA C 2012 8.1 rule fixes Michal Orzel
2022-06-20 7:02 ` [PATCH 1/9] xen/arm: Use explicitly specified types Michal Orzel
2022-06-20 9:47 ` Julien Grall
2022-06-20 7:02 ` [PATCH 2/9] xen/domain: " Michal Orzel
2022-06-20 9:48 ` Julien Grall
2022-06-20 7:02 ` [PATCH 3/9] xen/common: " Michal Orzel
2022-06-20 9:49 ` Julien Grall
2022-06-20 9:51 ` Juergen Gross
2022-06-20 7:02 ` [PATCH 4/9] include/xen: " Michal Orzel
2022-06-20 9:53 ` Julien Grall
2022-06-20 7:02 ` [PATCH 5/9] include/public: " Michal Orzel
2022-06-20 9:54 ` Julien Grall
2022-06-20 10:07 ` Andrew Cooper
2022-06-21 8:43 ` Michal Orzel
2022-06-21 8:46 ` Julien Grall
2022-06-22 10:16 ` Jan Beulich
2022-06-22 10:56 ` Michal Orzel [this message]
2022-06-20 7:02 ` [PATCH 6/9] xsm/flask: " Michal Orzel
2022-06-21 14:27 ` Jason Andryuk
2022-06-20 7:02 ` [PATCH 7/9] common/libfdt: " Michal Orzel
2022-06-20 9:56 ` Julien Grall
2022-06-20 7:02 ` [PATCH 8/9] common/inflate: " Michal Orzel
2022-06-20 7:02 ` [PATCH 9/9] drivers/acpi: " Michal Orzel
2022-06-22 10:36 ` Jan Beulich
2022-06-22 11:09 ` Michal Orzel
2022-06-22 11:45 ` Jan Beulich
2022-06-22 10:25 ` [PATCH 0/9] MISRA C 2012 8.1 rule fixes Jan Beulich
2022-06-22 12:55 ` Michal Orzel
2022-06-22 13:01 ` Jan Beulich
2022-06-22 13:55 ` Bertrand Marquis
2022-06-22 14:10 ` Jan Beulich
2022-06-22 14:27 ` Bertrand Marquis
2022-06-22 14:41 ` Jan Beulich
2022-06-22 19:23 ` Stefano Stabellini
2022-06-23 7:32 ` Jan Beulich
2022-06-23 7:37 ` Roberto Bagnara
2022-06-23 7:51 ` Jan Beulich
2022-06-23 18:23 ` Stefano Stabellini
2022-06-23 21:14 ` Roberto Bagnara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c1a2037-1bdc-cdb8-7c57-5e84448cc1d0@arm.com \
--to=michal.orzel@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.