From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161539AbdAFUxn convert rfc822-to-8bit (ORCPT ); Fri, 6 Jan 2017 15:53:43 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:49121 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756490AbdAFUxc (ORCPT ); Fri, 6 Jan 2017 15:53:32 -0500 Subject: Re: [PATCH 1/3] xen: clean up xenbus internal headers To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170106150544.10836-1-jgross@suse.com> <20170106150544.10836-2-jgross@suse.com> From: Boris Ostrovsky Message-ID: <8c36bfb8-066f-1373-9558-54c2a1fb28d0@oracle.com> Date: Fri, 6 Jan 2017 15:52:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170106150544.10836-2-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2017 10:05 AM, Juergen Gross wrote: > The xenbus driver has an awful mixture of internal and global visible > headers: some of the internal used only stuff is defined in the > global header include/xen/xenbus.h while some stuff defined in internal > headers is used by other drivers, too. > > Clean this up by moving the external used symbols to > include/xen/xenbus.h and the symbols used internal only to a new I think s/external/externally/ s/internal/internally/ > header drivers/xen/xenbus/xenbus.h ... and remove xenbus_comms.h > > Signed-off-by: Juergen Gross > --- > drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} | 64 ++++++++++++++----------- > drivers/xen/xenbus/xenbus_client.c | 2 +- > drivers/xen/xenbus/xenbus_comms.c | 2 +- > drivers/xen/xenbus/xenbus_comms.h | 51 -------------------- > drivers/xen/xenbus/xenbus_dev_backend.c | 2 +- > drivers/xen/xenbus/xenbus_dev_frontend.c | 4 +- > drivers/xen/xenbus/xenbus_probe.c | 3 +- > drivers/xen/xenbus/xenbus_probe_backend.c | 3 +- > drivers/xen/xenbus/xenbus_probe_frontend.c | 3 +- > drivers/xen/xenbus/xenbus_xs.c | 3 +- > drivers/xen/xenfs/super.c | 2 +- > drivers/xen/xenfs/xenstored.c | 2 +- > include/xen/xenbus.h | 12 ++--- > 13 files changed, 52 insertions(+), 101 deletions(-) > rename drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} (58%) > delete mode 100644 drivers/xen/xenbus/xenbus_comms.h > > diff --git a/drivers/xen/xenbus/xenbus_probe.h b/drivers/xen/xenbus/xenbus.h > similarity index 58% > rename from drivers/xen/xenbus/xenbus_probe.h > rename to drivers/xen/xenbus/xenbus.h > index c9ec7ca..6a80c1e 100644 > --- a/drivers/xen/xenbus/xenbus_probe.h > +++ b/drivers/xen/xenbus/xenbus.h > @@ -1,10 +1,7 @@ > -/****************************************************************************** > - * xenbus_probe.h > - * > - * Talks to Xen Store to figure out what devices we have. > +/* > + * Private include for xenbus communications. > * > * Copyright (C) 2005 Rusty Russell, IBM Corporation > - * Copyright (C) 2005 XenSource Ltd. Why is this? -boris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 1/3] xen: clean up xenbus internal headers Date: Fri, 6 Jan 2017 15:52:32 -0500 Message-ID: <8c36bfb8-066f-1373-9558-54c2a1fb28d0@oracle.com> References: <20170106150544.10836-1-jgross@suse.com> <20170106150544.10836-2-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPbUu-00007S-Bj for xen-devel@lists.xenproject.org; Fri, 06 Jan 2017 20:52:24 +0000 In-Reply-To: <20170106150544.10836-2-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gMDEvMDYvMjAxNyAxMDowNSBBTSwgSnVlcmdlbiBHcm9zcyB3cm90ZToKPiBUaGUgeGVuYnVz IGRyaXZlciBoYXMgYW4gYXdmdWwgbWl4dHVyZSBvZiBpbnRlcm5hbCBhbmQgZ2xvYmFsIHZpc2li bGUKPiBoZWFkZXJzOiBzb21lIG9mIHRoZSBpbnRlcm5hbCB1c2VkIG9ubHkgc3R1ZmYgaXMgZGVm aW5lZCBpbiB0aGUKPiBnbG9iYWwgaGVhZGVyIGluY2x1ZGUveGVuL3hlbmJ1cy5oIHdoaWxlIHNv bWUgc3R1ZmYgZGVmaW5lZCBpbiBpbnRlcm5hbAo+IGhlYWRlcnMgaXMgdXNlZCBieSBvdGhlciBk cml2ZXJzLCB0b28uCj4KPiBDbGVhbiB0aGlzIHVwIGJ5IG1vdmluZyB0aGUgZXh0ZXJuYWwgdXNl ZCBzeW1ib2xzIHRvCj4gaW5jbHVkZS94ZW4veGVuYnVzLmggYW5kIHRoZSBzeW1ib2xzIHVzZWQg aW50ZXJuYWwgb25seSB0byBhIG5ldwoKSSB0aGluawoKcy9leHRlcm5hbC9leHRlcm5hbGx5Lwpz L2ludGVybmFsL2ludGVybmFsbHkvCgo+IGhlYWRlciBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVz LmgKCi4uLiBhbmQgcmVtb3ZlIHhlbmJ1c19jb21tcy5oCgo+Cj4gU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3hlbi94ZW5idXMv e3hlbmJ1c19wcm9iZS5oID0+IHhlbmJ1cy5ofSB8IDY0ICsrKysrKysrKysrKysrLS0tLS0tLS0t LS0KPiAgZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19jbGllbnQuYyAgICAgICAgICAgICAgfCAg MiArLQo+ICBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2NvbW1zLmMgICAgICAgICAgICAgICB8 ICAyICstCj4gIGRyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfY29tbXMuaCAgICAgICAgICAgICAg IHwgNTEgLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19k ZXZfYmFja2VuZC5jICAgICAgICAgfCAgMiArLQo+ICBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVz X2Rldl9mcm9udGVuZC5jICAgICAgICB8ICA0ICstCj4gIGRyaXZlcnMveGVuL3hlbmJ1cy94ZW5i dXNfcHJvYmUuYyAgICAgICAgICAgICAgIHwgIDMgKy0KPiAgZHJpdmVycy94ZW4veGVuYnVzL3hl bmJ1c19wcm9iZV9iYWNrZW5kLmMgICAgICAgfCAgMyArLQo+ICBkcml2ZXJzL3hlbi94ZW5idXMv eGVuYnVzX3Byb2JlX2Zyb250ZW5kLmMgICAgICB8ICAzICstCj4gIGRyaXZlcnMveGVuL3hlbmJ1 cy94ZW5idXNfeHMuYyAgICAgICAgICAgICAgICAgIHwgIDMgKy0KPiAgZHJpdmVycy94ZW4veGVu ZnMvc3VwZXIuYyAgICAgICAgICAgICAgICAgICAgICAgfCAgMiArLQo+ICBkcml2ZXJzL3hlbi94 ZW5mcy94ZW5zdG9yZWQuYyAgICAgICAgICAgICAgICAgICB8ICAyICstCj4gIGluY2x1ZGUveGVu L3hlbmJ1cy5oICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTIgKystLS0KPiAgMTMgZmls ZXMgY2hhbmdlZCwgNTIgaW5zZXJ0aW9ucygrKSwgMTAxIGRlbGV0aW9ucygtKQo+ICByZW5hbWUg ZHJpdmVycy94ZW4veGVuYnVzL3t4ZW5idXNfcHJvYmUuaCA9PiB4ZW5idXMuaH0gKDU4JSkKPiAg ZGVsZXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfY29tbXMuaAo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfcHJvYmUuaCBiL2RyaXZlcnMv eGVuL3hlbmJ1cy94ZW5idXMuaAo+IHNpbWlsYXJpdHkgaW5kZXggNTglCj4gcmVuYW1lIGZyb20g ZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19wcm9iZS5oCj4gcmVuYW1lIHRvIGRyaXZlcnMveGVu L3hlbmJ1cy94ZW5idXMuaAo+IGluZGV4IGM5ZWM3Y2EuLjZhODBjMWUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy94ZW4veGVuYnVzL3hlbmJ1c19wcm9iZS5oCj4gKysrIGIvZHJpdmVycy94ZW4veGVu YnVzL3hlbmJ1cy5oCj4gQEAgLTEsMTAgKzEsNyBAQAo+IC0vKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq Cj4gLSAqIHhlbmJ1c19wcm9iZS5oCj4gLSAqCj4gLSAqIFRhbGtzIHRvIFhlbiBTdG9yZSB0byBm aWd1cmUgb3V0IHdoYXQgZGV2aWNlcyB3ZSBoYXZlLgo+ICsvKgo+ICsgKiBQcml2YXRlIGluY2x1 ZGUgZm9yIHhlbmJ1cyBjb21tdW5pY2F0aW9ucy4KPiAgICoKPiAgICogQ29weXJpZ2h0IChDKSAy MDA1IFJ1c3R5IFJ1c3NlbGwsIElCTSBDb3Jwb3JhdGlvbgo+IC0gKiBDb3B5cmlnaHQgKEMpIDIw MDUgWGVuU291cmNlIEx0ZC4KCldoeSBpcyB0aGlzPwoKLWJvcmlzCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==