All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: David Hildenbrand <david@redhat.com>,
	qemu-devel@nongnu.org, David Miller <dmiller423@gmail.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
	qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eric Farman <farman@linux.ibm.com>
Subject: Re: [PATCH v6 13/13] tests/tcg/s390x: Tests for Vector Enhancements Facility 2
Date: Mon, 2 May 2022 10:12:03 +0200	[thread overview]
Message-ID: <8c399ab0-5128-1aca-0e25-8b60e2a442fd@redhat.com> (raw)
In-Reply-To: <20220428094708.84835-14-david@redhat.com>

On 28/04/2022 11.47, David Hildenbrand wrote:
> From: David Miller <dmiller423@gmail.com>
> 
> Signed-off-by: David Miller <dmiller423@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Tested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>   tests/tcg/s390x/Makefile.target |   8 ++
>   tests/tcg/s390x/vx.h            |  19 +++++
>   tests/tcg/s390x/vxeh2_vcvt.c    |  88 ++++++++++++++++++++
>   tests/tcg/s390x/vxeh2_vlstr.c   | 139 ++++++++++++++++++++++++++++++++
>   tests/tcg/s390x/vxeh2_vs.c      |  93 +++++++++++++++++++++
>   5 files changed, 347 insertions(+)
>   create mode 100644 tests/tcg/s390x/vx.h
>   create mode 100644 tests/tcg/s390x/vxeh2_vcvt.c
>   create mode 100644 tests/tcg/s390x/vxeh2_vlstr.c
>   create mode 100644 tests/tcg/s390x/vxeh2_vs.c
> 
> diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target
> index f0d474a245..e50d617f21 100644
> --- a/tests/tcg/s390x/Makefile.target
> +++ b/tests/tcg/s390x/Makefile.target
> @@ -17,6 +17,14 @@ TESTS+=trap
>   TESTS+=signals-s390x
>   TESTS+=branch-relative-long
>   
> +VECTOR_TESTS=vxeh2_vs
> +VECTOR_TESTS+=vxeh2_vcvt
> +VECTOR_TESTS+=vxeh2_vlstr
> +
> +TESTS+=$(VECTOR_TESTS)
> +
> +$(VECTOR_TESTS): CFLAGS+=-march=z15 -O2

I'm sorry, but this still fails in the QEMU CI:

https://gitlab.com/thuth/qemu/-/jobs/2401500348

s390x-linux-gnu-gcc: error: unrecognized argument in option '-march=z15'

I think we either have to switch to manually encoded instructions again, or 
add a check to the Makefile and only add the tests if the compiler supports 
-march=z15 ...? Opinions? Preferences?

  Thomas



  reply	other threads:[~2022-05-02  8:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  9:46 [PATCH v6 00/13] s390x/tcg: Implement Vector-Enhancements Facility 2 David Hildenbrand
2022-04-28  9:46 ` [PATCH v6 01/13] target/s390x: Fix writeback to v1 in helper_vstl David Hildenbrand
2022-04-28  9:46 ` [PATCH v6 02/13] s390x/cpu_models: drop "msa5" from the TCG "max" model David Hildenbrand
2022-04-28  9:46 ` [PATCH v6 03/13] s390x/cpu_models: make "max" match the unmodified "qemu" CPU model under TCG David Hildenbrand
2022-04-28  9:46 ` [PATCH v6 04/13] tcg: Implement tcg_gen_{h,w}swap_{i32,i64} David Hildenbrand
2022-04-28  9:47 ` [PATCH v6 05/13] target/s390x: vxeh2: vector convert short/32b David Hildenbrand
2022-04-28  9:47 ` [PATCH v6 06/13] target/s390x: vxeh2: vector string search David Hildenbrand
2022-04-28  9:47 ` [PATCH v6 07/13] target/s390x: vxeh2: Update for changes to vector shifts David Hildenbrand
2022-04-28  9:47 ` [PATCH v6 08/13] target/s390x: vxeh2: vector shift double by bit David Hildenbrand
2022-04-28  9:47 ` [PATCH v6 09/13] target/s390x: vxeh2: vector {load, store} elements reversed David Hildenbrand
2022-04-28  9:47 ` [PATCH v6 10/13] target/s390x: vxeh2: vector {load, store} byte reversed elements David Hildenbrand
2022-04-28  9:47 ` [PATCH v6 11/13] target/s390x: vxeh2: vector {load, store} byte reversed element David Hildenbrand
2022-04-28  9:47 ` [PATCH v6 12/13] target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model David Hildenbrand
2022-04-28  9:47 ` [PATCH v6 13/13] tests/tcg/s390x: Tests for Vector Enhancements Facility 2 David Hildenbrand
2022-05-02  8:12   ` Thomas Huth [this message]
2022-05-02  9:10     ` Thomas Huth
2022-05-02  9:35   ` Thomas Huth
2022-05-02  7:20 ` [PATCH v6 00/13] s390x/tcg: Implement Vector-Enhancements " Thomas Huth
2022-05-02 15:52   ` David Hildenbrand
2022-05-02 16:06     ` David Miller
2022-05-03  6:55       ` Thomas Huth
2022-05-03 14:42         ` David Miller
2022-05-03 14:57           ` David Miller
2022-05-03 14:57             ` David Miller
2022-05-04  8:28             ` Thomas Huth
2022-05-04  9:10           ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c399ab0-5128-1aca-0e25-8b60e2a442fd@redhat.com \
    --to=thuth@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=dmiller423@gmail.com \
    --cc=farman@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.