[PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver

[PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver

[Wan Zongshun]

From: Wan Zongshun <Vincent.Wan@amd.com>

AMD has more drivers will use ACPI to platform bus driver later,
all those devices need iommu support, such as eMMC acpi driver.

Signed-off-by: Wan Zongshun <Vincent.Wan@amd.com>
---
 drivers/iommu/amd_iommu.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c430c10..547cdd4 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -21,6 +21,7 @@
 #include <linux/pci.h>
 #include <linux/acpi.h>
 #include <linux/amba/bus.h>
+#include <linux/platform_device.h>
 #include <linux/pci-ats.h>
 #include <linux/bitmap.h>
 #include <linux/slab.h>
@@ -2980,6 +2981,9 @@ int __init amd_iommu_init_api(void)
 	if (err)
 		return err;
 #endif
+	err = bus_set_iommu(&platform_bus_type, &amd_iommu_ops);
+	if (err)
+		return err;
 	return 0;
 }
 
-- 
1.9.1

[PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver

[Wan Zongshun]

From: Wan Zongshun <Vincent.Wan-5C7GfCeVMHo@public.gmane.org>

AMD has more drivers will use ACPI to platform bus driver later,
all those devices need iommu support, such as eMMC acpi driver.

Signed-off-by: Wan Zongshun <Vincent.Wan-5C7GfCeVMHo@public.gmane.org>
---
 drivers/iommu/amd_iommu.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c430c10..547cdd4 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -21,6 +21,7 @@
 #include <linux/pci.h>
 #include <linux/acpi.h>
 #include <linux/amba/bus.h>
+#include <linux/platform_device.h>
 #include <linux/pci-ats.h>
 #include <linux/bitmap.h>
 #include <linux/slab.h>
@@ -2980,6 +2981,9 @@ int __init amd_iommu_init_api(void)
 	if (err)
 		return err;
 #endif
+	err = bus_set_iommu(&platform_bus_type, &amd_iommu_ops);
+	if (err)
+		return err;
 	return 0;
 }
 
-- 
1.9.1

Re: [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver

[Joerg Roedel]

On Thu, Apr 14, 2016 at 09:28:53AM -0400, Wan Zongshun wrote:
> From: Wan Zongshun <Vincent.Wan@amd.com>
> 
> AMD has more drivers will use ACPI to platform bus driver later,
> all those devices need iommu support, such as eMMC acpi driver.
> 
> Signed-off-by: Wan Zongshun <Vincent.Wan@amd.com>
> ---
>  drivers/iommu/amd_iommu.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index c430c10..547cdd4 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -21,6 +21,7 @@
>  #include <linux/pci.h>
>  #include <linux/acpi.h>
>  #include <linux/amba/bus.h>
> +#include <linux/platform_device.h>
>  #include <linux/pci-ats.h>
>  #include <linux/bitmap.h>
>  #include <linux/slab.h>
> @@ -2980,6 +2981,9 @@ int __init amd_iommu_init_api(void)
>  	if (err)
>  		return err;
>  #endif
> +	err = bus_set_iommu(&platform_bus_type, &amd_iommu_ops);
> +	if (err)
> +		return err;

Is the platform_bus_type always defined or does this code needs to be
guarded by another ifdef?



	Joerg

Re: [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver

[Wan Zongshun]

-------- Original Message --------
> On Thu, Apr 14, 2016 at 09:28:53AM -0400, Wan Zongshun wrote:
>> From: Wan Zongshun <Vincent.Wan@amd.com>
>>
>> AMD has more drivers will use ACPI to platform bus driver later,
>> all those devices need iommu support, such as eMMC acpi driver.
>>
>> Signed-off-by: Wan Zongshun <Vincent.Wan@amd.com>
>> ---
>>  drivers/iommu/amd_iommu.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
>> index c430c10..547cdd4 100644
>> --- a/drivers/iommu/amd_iommu.c
>> +++ b/drivers/iommu/amd_iommu.c
>> @@ -21,6 +21,7 @@
>>  #include <linux/pci.h>
>>  #include <linux/acpi.h>
>>  #include <linux/amba/bus.h>
>> +#include <linux/platform_device.h>
>>  #include <linux/pci-ats.h>
>>  #include <linux/bitmap.h>
>>  #include <linux/slab.h>
>> @@ -2980,6 +2981,9 @@ int __init amd_iommu_init_api(void)
>>  	if (err)
>>  		return err;
>>  #endif
>> +	err = bus_set_iommu(&platform_bus_type, &amd_iommu_ops);
>> +	if (err)
>> +		return err;
>
> Is the platform_bus_type always defined or does this code needs to be
> guarded by another ifdef?

Joerg,

Currently, Only New eMMC driver will rely on this sdhci-acpi.c, but I 
could not find a suitable ifdef XXX micro to limit this 
platform_bus_type here like AMBA bus type before.

Do you think this MMC_SDHCI_ACPI is ok?

Vincent.

>
>
>
> 	Joerg
>

Re: [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver

[Joerg Roedel]

On Mon, May 09, 2016 at 08:17:12PM +0800, Wan Zongshun wrote:
> Currently, Only New eMMC driver will rely on this sdhci-acpi.c, but
> I could not find a suitable ifdef XXX micro to limit this
> platform_bus_type here like AMBA bus type before.
> 
> Do you think this MMC_SDHCI_ACPI is ok?

Okay, looks like platform_bus_type does not depend on any config-symbol.
So the patch is fine, but please add a comment why the iommu-ops are
needed on the platform bus.


	Joerg

Re: [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver

[Joerg Roedel]

On Mon, May 09, 2016 at 08:17:12PM +0800, Wan Zongshun wrote:
> Currently, Only New eMMC driver will rely on this sdhci-acpi.c, but
> I could not find a suitable ifdef XXX micro to limit this
> platform_bus_type here like AMBA bus type before.
> 
> Do you think this MMC_SDHCI_ACPI is ok?

Okay, looks like platform_bus_type does not depend on any config-symbol.
So the patch is fine, but please add a comment why the iommu-ops are
needed on the platform bus.


	Joerg